diff mbox

scsi: hptiop: make function hptiop_iop_request_callback_itl static

Message ID 20170622155219.22871-1-colin.king@canonical.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Colin King June 22, 2017, 3:52 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The function hptiop_iop_request_callback_itl does not need to be in
global scope, so make it static.

Cleans up sparse warning:
"symbol 'hptiop_iop_request_callback_itl' was not declared. Should it
 be static?"

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/scsi/hptiop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen June 26, 2017, 5:32 p.m. UTC | #1 
Colin,

> The function hptiop_iop_request_callback_itl does not need to be in
> global scope, so make it static.
>
> Cleans up sparse warning:
> "symbol 'hptiop_iop_request_callback_itl' was not declared. Should it
>  be static?"

Applied to 4.13/scsi-queue.
diff mbox

Patch

diff --git a/drivers/scsi/hptiop.c b/drivers/scsi/hptiop.c
index db17ad15b0c1..7226226f7383 100644
--- a/drivers/scsi/hptiop.c
+++ b/drivers/scsi/hptiop.c
@@ -800,7 +800,7 @@  static void hptiop_host_request_callback_itl(struct hptiop_hba *hba, u32 _tag)
 	hptiop_finish_scsi_req(hba, tag, req);
 }
 
-void hptiop_iop_request_callback_itl(struct hptiop_hba *hba, u32 tag)
+static void hptiop_iop_request_callback_itl(struct hptiop_hba *hba, u32 tag)
 {
 	struct hpt_iop_request_header __iomem *req;
 	struct hpt_iop_request_ioctl_command __iomem *p;