diff mbox

scsi: scsi_dh_alua: fix boolreturn.cocci warnings

Message ID 20170711141143.GA7961@intel11.lkp.intel.com (mailing list archive)
State Changes Requested, archived
Headers show

Commit Message

kernel test robot July 11, 2017, 2:11 p.m. UTC 
drivers/scsi/device_handler/scsi_dh_alua.c:594:9-10: WARNING: return of 0/1 in function 'alua_rtpg_print_check' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: cb809ba2fcbf ("scsi: scsi_dh_alua: do not print RTPG state if it remains unavailable/standby")
CC: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 scsi_dh_alua.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -591,7 +591,7 @@  static bool alua_rtpg_print_check(int ol
 	case SCSI_ACCESS_STATE_STANDBY:
 		return old_state != new_state;
 	default:
-		return 1;
+		return true;
 	}
 }