From patchwork Wed Aug 23 22:05:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9918497 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 009D2600C5 for ; Wed, 23 Aug 2017 22:05:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E7CC628A6F for ; Wed, 23 Aug 2017 22:05:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DCB1128A74; Wed, 23 Aug 2017 22:05:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 77C2028A39 for ; Wed, 23 Aug 2017 22:05:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751170AbdHWWFv (ORCPT ); Wed, 23 Aug 2017 18:05:51 -0400 Received: from mail-by2nam01on0048.outbound.protection.outlook.com ([104.47.34.48]:27040 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751093AbdHWWFo (ORCPT ); Wed, 23 Aug 2017 18:05:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vBXeFSwTQHX4IgKgu1yL2tsnCXK47hB1qTotBEoN928=; b=J/ta3O0S8qQV9t14fVyVzHuPE9E1BLTZdV0DDv2pO3g4TxqJsiTXtfoqL+K98q0uqoqndqfC31JnwHBgzXY6LZhZS+ZXKYoUWwvvEGoDtw5pNSnYDNmEymo1c4M8fTTuoEm/wT6Ah9kCEJ8OpU3JZkt5uUNMSoxPx7/6bUlph0I= Received: from DM5PR07CA0031.namprd07.prod.outlook.com (10.168.109.17) by CO2PR07MB2520.namprd07.prod.outlook.com (10.166.201.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1362.18; Wed, 23 Aug 2017 22:05:42 +0000 Received: from BL2FFO11FD037.protection.gbl (2a01:111:f400:7c09::155) by DM5PR07CA0031.outlook.office365.com (2603:10b6:3:16::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.9 via Frontend Transport; Wed, 23 Aug 2017 22:05:42 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BL2FFO11FD037.mail.protection.outlook.com (10.173.161.133) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1341.15 via Frontend Transport; Wed, 23 Aug 2017 22:05:42 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 23 Aug 2017 15:05:27 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id v7NM5QuP003190; Wed, 23 Aug 2017 15:05:26 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id v7NM5QGw003189; Wed, 23 Aug 2017 15:05:26 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH 10/31] qla2xxx: Remove extra register read Date: Wed, 23 Aug 2017 15:05:04 -0700 Message-ID: <20170823220525.3115-11-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170823220525.3115-1-himanshu.madhani@cavium.com> References: <20170823220525.3115-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(428002)(199003)(189002)(5660300001)(76176999)(101416001)(106466001)(54906002)(2950100002)(8936002)(81166006)(6666003)(42186005)(50226002)(105586002)(5003940100001)(48376002)(81156014)(50466002)(8676002)(50986999)(69596002)(33646002)(356003)(80596001)(72206003)(2906002)(47776003)(478600001)(305945005)(1076002)(87636003)(86362001)(189998001)(36756003)(626005)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2520; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD037; 1:20DxhPkmahON40NBFTl60KgRQDarAHH9s0zueWbTneWRc3Alv2Z7Z35I1bI0YzXOTr64ayJIGO2PQ8pLV6iYipqxoMebd8KvEtp4Ko2E+z1eVEhscb9G/Bx5nZsBrreh X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3bc233ac-3797-479d-0c89-08d4ea7318e6 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603190)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CO2PR07MB2520; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 3:JfFNFSWtBX/fjVTYyNW7rKcrAuM6Kh/FNG6yzT+Og1JlnzmIyZ35Yjvi0JyZLvcmgt4Gw5N+HRhitd6ZSC57uuAjx7L30gg1dEXVvQVzFxZW+JTA6MDxl7idpiBlCJ1YVvQf191cywHhkW9mYL83eBlUZTSKD3hwJJO8BHSKMl5L0W2sFgDZkSO+ifYTkNIBLmDpxJEu/lMj+A5naTdJOXTNKEVoZOHLByl2B9LG+LowDYeYE6Yr9k+uRGI7ZmMoTp7RM0/vzknW1mU8SE8IsumJUE/Ml8ic1tNskMlcNb3wr5TMAfukR7YqxGpBtL3U3nnQmcC33cp/Tq1bYhDogg==; 25:xHIgKIlMx1yfzI7mmkLFiiuidfTAKL7s0MAfUqtyRxMaCdMawI2LDo8feoqJUkVXsGvAWiLHRVNHFelMaW9krSLzW9w2jHyuyRJTrTd7yG4MXYl22ns8bR74G9i7tXGHQZQ2xCd7s7ZL5LZh1+tvjJhyUgcy8WPATy4RvLB8gMiDIpmpVxTmBaQ0I+2ydpNdIpHArV8LDwW80gQd1n+hOkX1lgqp/OciiGFIfgDnfphcMa7GFiojfnfoRdpY+e7twRvgHNHnyzo0AuKyOTnhqVN7aCCHZPvOLZaWi8Bq51pRwnv5JxxY7sf5Jtb4kmJN2CbxZLZxsLa6ldcvkIeA2Q==; 31:K8t2XUpn4uxN6psk4UXB3GEG6Zaw1xW9/GgME4IFYQJynmsKE3Vb2FG2f5VZDhDs4BIM39nrlmBz/mQ3xbQIf5Bz1OoiezQwiPmU7ryEPxAwSoqQeoPqQVW8jpgFbTEFefhXblFau2AJkDoK123C0lBmy9XZC+FyVmrWuKu4ohvo8hdzLmoup3evfh0gHqMTvCTFR9pq2Fljfodtqg8vvjWumCZWZG3StAZUIYB4wdc= X-MS-TrafficTypeDiagnostic: CO2PR07MB2520: X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 20:55y/Od3No4qzZYjwDsE6gm7FaznSqpWAoiTH+xqeeUKe1NG3xlDWUwx/6CzjLkym4vKM6Y+o+UCyYS6HTBt5Fh/CDFX/ytPw3xZIYlyjR7dYOPFHIjAfebY9on32ypnnffvQmTVuZfMjBPsqxtdImW7PBnC1zQSmQfXB1UkWqfGs5JpmYDETbCiQErUpJH3MY4RJk6KgJb6R1ZpCx7XvV5nUBKlIaTCw0fVA2rjDHXGjCKwXrtZqu8//D6FkaDE04tD04B2cS41NxAuHM2IGhDqGFoPge3CHmFgz98dWCl+IsMLmdzTh3TamFR+6Tc49vA+R2CqcUFp8FwwukRyigliabIpxuIUCDKmmghTUn0F3h7mnJci6SOW3azvuj/auvwi0O81dC2buiLwt8f9SGDc28itlIRRw+1fXONF7svYWOMgiO7GFbW3xVGqFhzjepEPMMhjM8YZ8p3gC/88+F/hZYw6dQ8PVAwwZO7y7GYoJywPP61ACOUTR/t4uGw47; 4:FD2m+9XDLKPTRMn2+4n9sclxS+pYe6RmDKqh84JSlDmzr2f7kkevGM3m7lCq3q1GanM5Gt2mPEL6MDlTPmQrWlwmxkS+Eb6K359bZCU+akCEwYWCQDGw69xAq4m/QX667gylKYsqvgOjrFGHjZxU0D577je4ykJ+ic6Hh8+3ap43CdqGgk3soGfcSEN07qzTxMd+kZEld7umGbXjIcsGM5DcQgDAQjT1wlW++JTdG7VD2wBGj43OOXHwJ5q1ihqo X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(13016025)(13018025)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6041248)(20161123558100)(20161123562025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CO2PR07MB2520; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CO2PR07MB2520; X-Forefront-PRVS: 040866B734 X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 23:edJ0rW9Mn8tS+zJjqsK1MDjUd1gV31Ecq0SXaq1Xdb1VnDlRSEnAfyUMX17U7aWqXPpk25Neyp//FhE0kEBFVv/Oe9VoPQiWFLuZOpyf+hxyV29dTRc2o5687s3kD7O3oCDg0/6SdjaAJN4QVpgBbcrJn/qyjcZ1QEtOFwDylrTYqXXJUf0K/Cb4tAcsU6J6pkjLX79xShQm66/ZcW5c/0n38iVcJE+AHKypWNIODGyan5FaPxD7+rHZnzE83EhQmWmA82wSpu1morEPwFOn1pIMHQlAprWIEgLclkv+2mgYgqhlKqREcsHYGpeX/D4ulYUZ4fs+C4e6tJ51IvL5v1RVknaDYNLC8uZ3vwZMXaHRp6KpxRyMuTTzAXDu/f//E3pNxj+4YqxHmr8IW7Ds0mwvO54vXtpVs7V5QHwFOHC+fI4T3nVS+SF0H7uc8sS4mQuY3w1VmxSDpnqVHjBsZVYFXKY9oF2riEJvi5wejiQlyV5OWz9qv9S3YjFdHEg0T4WKGLFM6sLuLr5IXIbpLDC8Snq6KeKh+mxAexCozOxh5rg/z6UR0EccYTWhamKLwsU0z77NnonsWoU7a5909eVjRNkI0pMJ8NmuHX5PXltIQFZ0rUWdwxY14xBwbCWucbG3bt1fIlR/dfcvoUtw8Op3Z/wJfW2VYOoClCcWIwMvVcDEYDHVTD6ZF0lJWf+UQB2WeBWruXbrOohHoDPEqUKs316LCqVG2+BpTAHSSKnqHJkoWkT4rhEePP59VKFJwaUFHXR1FNd/e7nbeSI8BSZT++5dHxQAHWAbEa+N9pYtHHJwJraFnp9/tf9nxODTEQ8sQ9p5nm/dsiS21W9O7PXDmNyyToFH4yAs+VhsKQAk6qfiFmjD8XzF/Zea3xfzQ4eIQMl8ryUXOJqaWXpKyCwYXDTd0mi/oW8jB8vrt XY1tN1Ez0s0JVDqYJr2dWhi X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2520; 6:JKOv+MRecMWSOWkE7liyf072pvZ2Ovh0mnCwnJdZ8wv2WOyMf5Nxd5WQXW1HnJIYY1QZDEW0whsHmZrn1n2jxkLLkz2z524byhU2aSsMIPdUqCWQ7NaVcVZUF4gwx6advARKgOWYLGkO7bWE7GvRolcaitnd5clUiHkNnnT6xbMbF6/cY10XGOi8MjC6+lMKKev096kp1ZqyDKUZXPKagQz39Q5E8yTUpM+asGnkjPzpwAA0yjU9PI4uoVZbEZeJ8ku16Vy/4kgMKj+d6Wfl+D4GN9EGNZQwHN8CgwegPItCc4qzzmz66oHeArXngHJRrUE2azYaES/iY4hsTrPYGA==; 5:A/sWS2DeaAWuwxyTwLe83WsNUceJPxCaJevuylaHsV7crjVkeMMY9l/BZq9+l37C/RU75Go0Shs4jpql+TRUgmhLzP3r99t9U4YPOv9ycjIFS0tpdeftAYnayYpiJ8gA4cHPaOpYW32LE5glWYUMPA==; 24:a8kSQ4jh8UwogwEpvtJlaPWXZBPzCFHB/FfhqtI1iGOZ0Cq0JeaHymxLgKiF5qv3biqQS5CIU5cgh7/rEyoFZ9MBbJuHV4QeeUfPmT58Q64=; 7:hfW6114uAYIiOAAawkoB3h+9ZxJMvzyvu4Va9FTDNzwNpYIZf6dmHaijayL0cOIf/JY/sxprQ+a87JeZdhabW8bsS2gi8bYIMGnte8MA6/cy4YYDFrBTTtSjiKDhyqdyxg5y/x2584z2Py3cpzfkh8CYkoK0Ju7tdwBjaMnJzKofBfAHBFJVMWOpHGNx1SD9/0jgDb+SBqrsYo04/xYzkf2LFUkEa9ddZzjffju++TQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2017 22:05:42.2518 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2520 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran Remove extra register read for each interrupt for performance improvement. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_isr.c | 9 --------- drivers/scsi/qla2xxx/qla_target.c | 1 - 2 files changed, 10 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index c6c066186d97..df8a7f378e72 100644 --- a/drivers/scsi/qla2xxx/qla_isr.c +++ b/drivers/scsi/qla2xxx/qla_isr.c @@ -3157,7 +3157,6 @@ qla24xx_msix_rsp_q(int irq, void *dev_id) struct device_reg_24xx __iomem *reg; struct scsi_qla_host *vha; unsigned long flags; - uint32_t stat = 0; rsp = (struct rsp_que *) dev_id; if (!rsp) { @@ -3171,19 +3170,11 @@ qla24xx_msix_rsp_q(int irq, void *dev_id) spin_lock_irqsave(&ha->hardware_lock, flags); vha = pci_get_drvdata(ha->pdev); - /* - * Use host_status register to check to PCI disconnection before we - * we process the response queue. - */ - stat = RD_REG_DWORD(®->host_status); - if (qla2x00_check_reg32_for_disconnect(vha, stat)) - goto out; qla24xx_process_response_queue(vha, rsp); if (!ha->flags.disable_msix_handshake) { WRT_REG_DWORD(®->hccr, HCCRX_CLR_RISC_INT); RD_REG_DWORD_RELAXED(®->hccr); } -out: spin_unlock_irqrestore(&ha->hardware_lock, flags); return IRQ_HANDLED; diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 4e2a64773060..3bcfbee2ae26 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -6530,7 +6530,6 @@ qlt_24xx_process_atio_queue(struct scsi_qla_host *vha, uint8_t ha_locked) /* Adjust ring index */ WRT_REG_DWORD(ISP_ATIO_Q_OUT(vha), ha->tgt.atio_ring_index); - RD_REG_DWORD_RELAXED(ISP_ATIO_Q_OUT(vha)); } void