From patchwork Wed Aug 23 22:05:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9918507 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 83BDE600C5 for ; Wed, 23 Aug 2017 22:06:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 76CD228A7F for ; Wed, 23 Aug 2017 22:06:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6B32728A83; Wed, 23 Aug 2017 22:06:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0AA9028A7F for ; Wed, 23 Aug 2017 22:06:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751191AbdHWWGB (ORCPT ); Wed, 23 Aug 2017 18:06:01 -0400 Received: from mail-bn3nam01on0087.outbound.protection.outlook.com ([104.47.33.87]:37568 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751112AbdHWWFw (ORCPT ); Wed, 23 Aug 2017 18:05:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=yxrYtQqbljFJ8YPIQgMqCDUtl7C4V8TPaQ3YwA5SK1w=; b=FUId/mEzCiieLknq1iN6ueV87pVAurPlN8IH7JiK4Zxv4eqO/XASP/sSMiX3BRlHIpkDb95046hKuHxW7H48QR2XsjwsDRaIQF7vyZ372VpoTkLeEOmGNnj7AlVKLD/++yg16Bn/nD/h+NDURxy/CN/1FmY9kOajLldOMjK7YOo= Received: from DM5PR07CA0027.namprd07.prod.outlook.com (10.168.109.13) by SN1PR0701MB1950.namprd07.prod.outlook.com (10.163.131.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1362.18; Wed, 23 Aug 2017 22:05:50 +0000 Received: from BL2FFO11FD037.protection.gbl (2a01:111:f400:7c09::122) by DM5PR07CA0027.outlook.office365.com (2603:10b6:3:16::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.8 via Frontend Transport; Wed, 23 Aug 2017 22:05:50 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BL2FFO11FD037.mail.protection.outlook.com (10.173.161.133) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1341.15 via Frontend Transport; Wed, 23 Aug 2017 22:05:50 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 23 Aug 2017 15:05:28 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id v7NM5ScC003222; Wed, 23 Aug 2017 15:05:28 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id v7NM5Skj003221; Wed, 23 Aug 2017 15:05:28 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH 18/31] qla2xxx: Allow SNS fabric login to be retried Date: Wed, 23 Aug 2017 15:05:12 -0700 Message-ID: <20170823220525.3115-19-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170823220525.3115-1-himanshu.madhani@cavium.com> References: <20170823220525.3115-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(428002)(199003)(189002)(33646002)(105586002)(106466001)(47776003)(36756003)(189998001)(5003940100001)(8936002)(76176999)(42186005)(101416001)(72206003)(50986999)(356003)(2950100002)(2906002)(54906002)(86362001)(81166006)(50226002)(81156014)(6666003)(4326008)(626005)(48376002)(69596002)(50466002)(5660300001)(80596001)(305945005)(87636003)(478600001)(1076002)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0701MB1950; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD037; 1:wwtox55PiS/KbUVckCGwqUarHTAAIaagsRDwae/4I/NkBs9G8arQ5Sdn9iBvnIDS6zPtVRdov/78bxYPQ2IngWCRzcuf82W75EpK+SBVvi4plu9vaEgPaGD43ENiFNDa X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1474d6c4-7975-4f81-8338-08d4ea731dcc X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603190)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:SN1PR0701MB1950; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1950; 3:0LhqNtIYewGs+4LMrSetNUbYVy6Zou6tsAqvOjnh5OTKpDPbBQ872KnvUBGsDPqqj59Xj/QYLHhK3sZi5WpuYohmiSa29awO6YEn1dgwioA81wxVbv0JDdzgphcSYTMeV98t0l0XwAWYbmtF89AmIDyE5fx5G3hGGSqudlpIZHqdEjPzFR+CrFLEc12tXLJ2AELJbZ2O/JynKy3Y7u5B9qYwqv+F1qWfQ0xqBU8REEA4z5v5MWPf/4yPtI75GxkSRTakW8nnTkJhJWuAI/8LA4OjjkXa2FoCuEPJkCMNTQXxXpzAGz0rPsWzG2+/vHBoBC7E9RHI0pK0LdbegQ6BRg==; 25:fK6phAf5bahLVd89aLRFilnR/RtNsGtn2kFe5V8yzedWBgRvfcXP2Xpfi4IQLyec791s8uJ02hl3PTXo3bOYGdwF4I9/aE4GW4S8ZjU/UZ0AzTlyB/GrP3Viup+lDmNK0u6Gngr4YN1VSlyaFJCgL/pVdltBBN0FVcrLazqXWKT/VZW/6nvOZY6RlLFz9QqL6245UTsaLcTm6yoKecdio2FI7mBjgfwwMlfedjcdePbld3uIFFyUX0M3N/YZrnssCQrdMKygWkPp0iVuZHymupA9xuxkqbZchZtX0EhsNjJ2JCEzLeEKZGXczcuJjaACn4A+AIl7ZKIIfWY0+FRjNw==; 31:N8qqDlX1O4r/2KV19gD65msW4hgHZZ5dbCVmOlst+PqJKE4PFJcKjwM92//T6zoGOpCuT5/kSAbRujFyWeJUx7+OBqHC/38qihHGQYcQctldohYySmWYSwQi7ZXjUYNYHVwPGyIIqyAx8X7cpp1FMAg75rQ97dv+mPXlgHiccVXe6tJNVkEZG9yrYFz5u45+KkaKHcOXHxaw6UTMq8sz/7pj8NHhtigivKLvwMpSE8E= X-MS-TrafficTypeDiagnostic: SN1PR0701MB1950: X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1950; 20:949GcXflNL8Y8guz1PZiyWYuxRfYWQDhe94+HMDpuJ6dQZJGun4O+lHayQ2QLH8THO036IDDbTV5gFUCduRbJXlWFAqlXqNiFD7Q3j34SgyPUDQrMR+dvjM4a3RQ6c1/HO1e6DrpmLNllLkezddBxtR6dnNFChvOOUsyaKiHjngkPaHByS1yYssM3Q374ps+JxyBr5ng2hy4h2tUtUwcdNgxC5KDs5nn/2LSYUioJjM3Le5QvjO5hErY3SgU8EPzdlU2pJGU0FQ/bc+btDVI5wz7dT7zGg/dyDKQrxxpKH06ugWyXymHkAfu1Jb8OCpL+p1Ij6TJTDp1UU7b3X8o4Ko+CDV5LsxF/EfV5toj/L5nGzrZaOyazZYhkyJvSYaiu5hqBkSqoX1+dzL/qqODDPTvjdqXS8QG4dvGNZW057a7kQBZkMZS1NTYpJulbt3/q07HqRFvt4Z2wnzonjfeLiPw/KYPjY8Z+q6kn0yW+yrMW47BJ1ySUmEVLm2NsAo4; 4:/LPrEcI8M+CvdQarLnrBOWOtbeZ1h3H8+I+A2Zmra6lKQF/6qLavzFW1X90o2EV3HHqbUcwtISpj4Q3ZnQVufA55yAxw7iWB+elHTUDUMTNyk7TIMhLxV7U9GGnVKF/frL7bMg5/M6cbTZd7F1EOg0oUh9NHubpS0Sx+9FXVtn2Ckwr2sPY/jAmw0yxK0faZSNwkZDQZFs64yB6uHkbTbcurKuJ1kKu8qZtmGEPCCT1LC5a3vx+Kkz0akqFm8hXw X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(13016025)(13018025)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6041248)(20161123558100)(20161123562025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN1PR0701MB1950; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN1PR0701MB1950; X-Forefront-PRVS: 040866B734 X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1950; 23:ue6wtYxl5+HxS8XFWxoY7YXIdzX7DSP5m4xzGXqJkqqZNJAXv0DmunaQjTZN+XSNCDAfaOPMUBfE4OCbYEhFndFRFkYW3WB5gK+9o+phZvbYat628pDovNvTKuD58k1VASzB/ZNFIoDXg2ElfECRHfJI8G4VyKuaagSkpM+NKsI6K1ILRJUlVhJDjkZJoTA0RngmqW4XncMrkgcKQsKW5qbtTA3+LMd8W0sbt6jaRpIKxpN7brheexqBXZSFxzXb2GqGySgpRtWHAl9Vumn63zMnrBCLMuShVK2yC6TtAL4rI5wbRniWZO9Dakw9lJW9/709VksZA2UccundhkN71tBjanFJ6I5jM6kGYAWhDWTLC8zD24ltCjISoq2aw3BRt6o5C0PSzg8o/NfOjpqiVMP0Z0EQaYtre4wVNdxYPOCDYn6LQDc3jIn6Tfv3AuA5zh9JwtGJYf3WcpDzAEzSVe/UJrciQwdFLVfmp3acJEJdf0fxWwQjLcmYLxWF0ZnfUKG2yHejnk2NRsq0aZJDI+rVKxhKL3bM1laoZ8oHcYCp4j0p8gN4BFRwefJtG4gnVoaWHiDdRDXnDIS2U5Zx2mVT3MzT3/AuUAcghlpenv7sapgElmSygrcv6jc21bqQJiEDtqYrlyiIUhmj8vGDGIJUOzN1b2WTWw0eXd66lyQHqxr+/uhDHs0+uv+HXkSRo6r0w3nMvdhBlf2t/jvjnWaAcLCo30uA3s9OmoqiaPZBC7oecPRFLfTXW8nuAyTFnTO3bzbg2tw9BEHYeZtI/OFmMlXFdPrvsfVry0Z190MzaBmsYD0xg2Nps2+lEYUtXPhCzCPsb+PT5wsPSwKsA9i8L96przcwaQ+nfbaz53s9mm5+ev+EOcbO83p7S249tjv961fOeGPuHvcfIJOCwPP3T3OcOEb9XZ40LK5 RlL1zXDhcBinzmDTM9gwLMtRK X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1950; 6:I6mmzv5HVqKT4b8VlNmyuAr716o0IRvrDORlY5+StKijYRLgZw+9ihdZXbT6MA0a20Un89R/eS0KUbqEJ9+84pbRYiLz4mlDwUQjVdZ5mFgIfi8qy1cOQWlbCMr3ZukoCHaJgxj9X6t/c2rSJxU4xPEAJWvvpq172X2WOx8dyGfuSgmbXwinpp5APhAALj2iyqAlDFAX2iepZiovxvQDnOZaLCLcfkjJNUkA6t9U6ATzxdQlk/UVCO9HtABr2afBVl/pen0MJcX8xkDsQ7PFAGmOGMIpueqwYKL2apQLyuFFzq2PNBdilNGzP419bJyWpfBtg0/ESK1nw1fAW122Gg==; 5:h8czsfi0MDTMy/HnWR/isqOL4GMJMwDZqfqUXUsw7rBlUPHD9YBjo3SrmBnWX72Kg2gSOVZ8hqDZttaUKFmkFlQc/l0H650f13uFuhHC6B/Ik2MomQpRnIxD5ZeAJCFWyTuxfw8RyOPiAaDKewMSqw==; 24:lXiJ7/AjuTB3qFdsC97jHYyHrBGQPnGzxu3JS3FKfbtX7HfEpFZ7HtyJgVzNIQh2MX7a4jJS87phKvyOHZVFKUHHrTUubvSyvwisO6trYMk=; 7:UchM1yIVj4WO+YZkkF2enGS3njMbwhzmfYhk8MDrdTtnqQ4OPwoFoafD+U2KFKwKYX0YlpV0MJH8RvUdgBLuQOxjYUIL+Aq1tvCee1UUXBsIXvemm9xyaIjIA/G5lLMTHalCXgwz29q2W+TnrOcwAiA7SOirGs1OCJ5ARU1fmA0U68M4oymUejZ0XAzvyEsD7kNPrE4lHyC1igGjwugvzPwabdfhiQe61vnoaxhqTlM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2017 22:05:50.4731 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0701MB1950 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Joe Carnuccio If SNS fabric login fails, set loop resync flag to retry via dpc. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index d00e0129c51b..fe2d196833aa 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -4752,24 +4752,16 @@ qla2x00_configure_fabric(scsi_qla_host_t *vha) qla2x00_fdmi_register(vha); /* Ensure we are logged into the SNS. */ - if (IS_FWI2_CAPABLE(ha)) - loop_id = NPH_SNS; - else - loop_id = SIMPLE_NAME_SERVER; + loop_id = NPH_SNS_LID(ha); rval = ha->isp_ops->fabric_login(vha, loop_id, 0xff, 0xff, 0xfc, mb, BIT_1|BIT_0); - if (rval != QLA_SUCCESS) { + if (rval != QLA_SUCCESS || mb[0] != MBS_COMMAND_COMPLETE) { + ql_dbg(ql_dbg_disc, vha, 0x20a1, + "Failed SNS login: loop_id=%x mb[0]=%x mb[1]=%x mb[2]=%x mb[6]=%x mb[7]=%x (%x).\n", + loop_id, mb[0], mb[1], mb[2], mb[6], mb[7], rval); set_bit(LOOP_RESYNC_NEEDED, &vha->dpc_flags); return rval; } - if (mb[0] != MBS_COMMAND_COMPLETE) { - ql_dbg(ql_dbg_disc, vha, 0x20a1, - "Failed SNS login: loop_id=%x mb[0]=%x mb[1]=%x mb[2]=%x " - "mb[6]=%x mb[7]=%x.\n", loop_id, mb[0], mb[1], - mb[2], mb[6], mb[7]); - return (QLA_SUCCESS); - } - if (test_and_clear_bit(REGISTER_FC4_NEEDED, &vha->dpc_flags)) { if (qla2x00_rft_id(vha)) { /* EMPTY */