From patchwork Wed Aug 23 22:05:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9918569 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 23674603FA for ; Wed, 23 Aug 2017 22:40:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1653D288F8 for ; Wed, 23 Aug 2017 22:40:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0B39B28A9F; Wed, 23 Aug 2017 22:40:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D2C0288F8 for ; Wed, 23 Aug 2017 22:40:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751197AbdHWWks (ORCPT ); Wed, 23 Aug 2017 18:40:48 -0400 Received: from mail-sn1nam02on0079.outbound.protection.outlook.com ([104.47.36.79]:29568 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751005AbdHWWkr (ORCPT ); Wed, 23 Aug 2017 18:40:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OByyCX9ffoOhl++t5ab7U+xoZVEeXu/QWSkP8MtfQEA=; b=YoMmrh2jAgBV+0iCihxzc4FuTBvLdtq00lVYu8iOnS7ay122w0ybTBJt5b6TmwRcGbKI72uifEJdf+p30QI/dhNRuhciueHtQ0v2JTIi33DyeNELYflQFTRG/JL62fmDQ9yFRaXKSYUmoYRisddEg217s/paZSEzvNjDxpr0/K0= Received: from SN4PR0701CA0002.namprd07.prod.outlook.com (10.161.192.140) by CY1PR0701MB1945.namprd07.prod.outlook.com (10.163.141.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1362.18; Wed, 23 Aug 2017 22:40:45 +0000 Received: from BN1BFFO11FD022.protection.gbl (2a01:111:f400:7c10::1:191) by SN4PR0701CA0002.outlook.office365.com (2603:10b6:803:28::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1362.18 via Frontend Transport; Wed, 23 Aug 2017 22:40:45 +0000 Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1BFFO11FD022.mail.protection.outlook.com (10.58.144.85) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1341.15 via Frontend Transport; Wed, 23 Aug 2017 22:40:45 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 23 Aug 2017 15:40:43 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id v7NM5Snd003230; Wed, 23 Aug 2017 15:05:28 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id v7NM5SXW003229; Wed, 23 Aug 2017 15:05:28 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH 20/31] qla2xxx: Print correct mailbox registers in failed summary Date: Wed, 23 Aug 2017 15:05:14 -0700 Message-ID: <20170823220525.3115-21-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170823220525.3115-1-himanshu.madhani@cavium.com> References: <20170823220525.3115-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(428002)(199003)(189002)(106466001)(50226002)(81166006)(80596001)(6666003)(305945005)(76176999)(50986999)(101416001)(105586002)(15650500001)(2950100002)(81156014)(2906002)(8676002)(8936002)(4326008)(626005)(86362001)(42186005)(5003940100001)(1076002)(54906002)(33646002)(356003)(36756003)(72206003)(5660300001)(189998001)(48376002)(87636003)(69596002)(47776003)(50466002)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1945; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD022; 1:6kOo9otrzkUgNOgrxVLAy8PL21l05gHakR8r0PWz2Cff4EGqkmSOduMGbjuMxBBGPtP00AtTr/6HoJ7kSCicoDtzVvIfqt7bEXUljQChzQj6o7d/ese6R7Qrq8qdoTmE X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4aba5b0f-0dd3-43af-be5c-08d4ea77fe4f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603190)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY1PR0701MB1945; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1945; 3:ubt7lJOryIWauks7Q7zP3zqRYLbIJPoIOCPjT9y9bdrr8ZMRoHgWE/AJU+CaMENPC3UjJSLlWkbU5lf71OY5kqTl5b0x/CJLunvP+MmBznVi8/MKq6ufTyuA6j/RaHSnpvLHTT6k4JHvriL2MXz9PFhIyLgk1RdasU9ChNs0Tb3XQMwOXyVhTxxJGEksz2onmgCzEQQ6hKUysw/JvxajE3g1Nce/IWEZnavNXBpGfDwIcVQb0Axpndx5W9QCunxBSP8q7ik2ntmpLXnbII1Lhpj5vM+oj4LGu4kln263DN6FxTNZv8C0AJYNWBMnim8S8exRCg6UAVbYZXxcAJr/OQ==; 25:fKn0rMsyTY1gbhJYqghafON5Ze+ESfv2vecjvacqBEDJe6KJBW8FEx6Ly8qVoYStX4ymAHvqrEi+MpSK20dRQQQOHNb6lJj6ELiYVWed7lwqvOxFZ53mB/v3hH3DTKvzdiEDEaGJwaWEgtycvPfZKc4MtiNCWeLV2aodn2d+nIz+WhAIF8web28dVALrjRSSV1bqRvyrV0T2fs1Un/+rIgzQu+4tI4J/50vgcnA2M9VAn9d4UGTYh/97R4diq2FOvjP/PSdQRMj9QX+FZ1nGD4SzuhtVIvbU3mre9U5R74Zit9D3SP1pquwzHv4C9xLswkXYtMn48/CywBhH2K5x9A==; 31:itqcGD3+SLji7/QcOL7yS5aTWRlweyCggizzlMiQjLa1geDslBbVFvsiQSVsTIn2OXhCrOhSBhg8PDGSQCMqgTkSDRC8r9Fjx4xSjqYECixGQNwMl197TpJ8PflG+u9K9Sg8fgZdJELNgjDBrITDjw8OuSSvXGT0FUp5NRRywtNIJr2Q8BXoZKnWTtC1rVy+lfdYMzo0fgjHhjMBRFciSP5QXQLAzjqu+VbxYPlOfCA= X-MS-TrafficTypeDiagnostic: CY1PR0701MB1945: X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1945; 20:CCryIzyvidXPSk+0CmWDxJKtWZwyHocKDjxECJYSAlTy6itdpBfWD7P3PVQyETba9UqJauE+D/sK/s6bjQiVb8tFVdWWHn4Pn30vSgrHtl22WSY0R4IQCzSGen1TZ6QZ6CqBPeTX7jz5SKiBg3TdXSdkJOqBkxYDS9WCztCwmfXpBoMDXHzC7hkrMG9L8EUjXgjVUDYEURsCpt7ECWfaER3J7wq1ywOA0QhjdBhSG4xqZT1A5RkfDK5qu7m9G8D795u2fvRpBGvA5qz8yQGZddWiLT85cXweRXIXnrez9R/6EzRm2JgpOIsGMTOOyqyh6AkY81OhNwaY3W9nKcKb6sLuMmqGWzYMkCDBR/q6qRsxNEKm7Bbx/dPYEGxAc229Eq/1QrElaq1HpN1aHpZdkASjPbCqZpgp9FC/KpP+odZ86TBYp0LPcERr7nIvBSVF69hIyIBzxZeWwuucxT8TIW0e9QPnPGAM8BsZe/aDSlLNnG1InbxtBuDHK2ofeaSv; 4:TbyxF8MHhAxZV3ooFgkFO5lIn/gyVVcijT1F99lktFasS9o4myU/XMKEArlu6ovQsgd+CJosB1ZflypuL9oDTYHDHOMInQ9qRpv+MbxXvq8HhWtA5DJyHYlx0vavkGCw3vORc3G2COFjm3xTOYksSuTZAR7vqxMsiiHs8m/RVlHwwk81sKe2JibHTXMHuvBgx6W79egjQ/+m9Whd/DsCIQFWqhVWJZ37bzW35aXGdsN0LclTIx5ySw1vqMJTeed9 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(13018025)(8121501046)(5005006)(13016025)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR0701MB1945; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR0701MB1945; X-Forefront-PRVS: 040866B734 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1945; 23:wcosspt8l7xIvnZLgV+1MK9yDuktK6Z8x+YZH+5?= =?us-ascii?Q?0XWxsCM1TgL+pLAGnyqeUdbU5QidtKSC0BJFd8ZtXF/En8gejgaj7uBE5pTT?= =?us-ascii?Q?E0ni6oki6yAnGmGpV4EIYquPHKVt6YPtndW+Jh6z38/Mq6PZUk3U0UxndCzV?= =?us-ascii?Q?xDIOf6/H+yPnstJI8SguNcMVjswY92DjI90EWsn7Grd5+Zt7emnVoScnpz6d?= =?us-ascii?Q?OkDbQiwNP3cPqxpqAMKKMDWuV3qgmTAA/byHY9i9K2vK6GBrPiKxmIJpMbXZ?= =?us-ascii?Q?sKiM0iQrW0t9uwkZzk3w4jbV1+ifY1NKbLcg6x1+Z4a1daMHK+tppquvJPdY?= =?us-ascii?Q?L2uWta3nKjiz9PX2Rpan3xLK297WOAXHxiqanWskspGxeawaHQY4NqFJN3nN?= =?us-ascii?Q?F7IrJ6FYcuezQwsPnIr9XipB12mwQ37pmvskYxIS/h8vGTUw/xTrj8UshjLW?= =?us-ascii?Q?leTU2rbPyrvmCWYZdkjukfwrd2UO8jRMVnxfCtDOGJJTBphiLaUcGFD/+zHh?= =?us-ascii?Q?l9+U68XcUlIjz9+U9bh4SPGcIk5dqKujt2YKIRqjnZiFN5uICZ9/Xmk2H7bO?= =?us-ascii?Q?v1hP/60TXwEkd1QxUBRoP48ro4w4CkXGVmt+hz31QR/YW2+zgBnjRZm3jYq0?= =?us-ascii?Q?HAhyWI81geKq7Z4Di1G47XWIW+FDA7HI//bmvj7e7rmvKPWObBQsUXJ6ZnbY?= =?us-ascii?Q?lLYDjjYBSI3egIX6cXZE4GVT0+XKmENqt7+DvjIZ4+vRH4H+FNNLd0qMy9Fq?= =?us-ascii?Q?PCsvnV3YuYZDsQozH/pbRV1JeSzxfTM3DAfg3WyHGbPgIleQvJSk5lJQdyNg?= =?us-ascii?Q?XSE2qjIKSV/schjvue8e7yaQeIwt/144usoGUX/J29ZYD0ojGwoY1zgqK4xV?= =?us-ascii?Q?mI6UsG+mL4m0LnExQsZWxdnOsjbaDZdHl/OLN2b25Y7aeCdcQd7Fala7GsUj?= =?us-ascii?Q?gzf9N7NUziIByXrXRBToC4Kl8nkM/GstIDGPFt9W4KKl2QKLXVzkIAIQO59W?= =?us-ascii?Q?x76M=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1945; 6:CHXq0iBIPXsBQZe32j6yepWR7kmVdcWgvLNYOjKsXQiv4Gyo1ObTulwsBUNb0wW+TNVZ+Ur0qRgHSzCOkTp12yVRk3uCE2ZWr9W6sO6XDKOYUfxn6RhHUQDu2lyjyPAi3ChBAJaG+H1g+7+ajDLloNDNi6elFO62P65ef1TUQMc6Zy7P/+cLktHcHzRObHKGyr78eFvHpZdzgc8ifQXoEleD/FJFWYJEIb7Dl40pkXkPHxl3V/wud5LE/zoxz1TJ6tPDq/3UO6tquXelvbgV7NZ7j5+1h/9g2u8rVjNWuB+l9kSxtmcWwHE6OD5rnWwNH5cynkBmJSqwzbDibM40rQ==; 5:sA0mwbu4fns+Gtcrib6kTQSuo3zBqpwhDpqrvwBw9qHmcK7P7I+Y8YtDsURTYIaKkLWG2MaNL2FXE3DCh0XTpRVNHnxZgzDEiC5+Hlg5VxCaI0kDTkuoNnil+W8Makh+5sCoj7efl7SRLAOk8BRV9A==; 24:8TCuohHa6oayyh6BzyGE14Yyc0JfW9lTtJE87/6dcZmpjLdQrYaa5AYPjPVJ7gMRs637+C0VqgrBo8z5oPlwv1jlE7r7VUWDYt4xll7k7gc=; 7:Gjl3Ag6cR5E6p5ZT+dXRWydk3eqjcMmqVfb3OVbhYnV61eRowMkB4vFobJbATQB+oe06BX6f2pHqStm67t4N5zb5+N2MoxP6n7AcyKjdDWAVXca3i+CDRc6eHfZUEIrj4YAPkWXtEQtEbKQCZpZUxaHAw4FmeQR5vaEq4ck41HCVJFm0CL8mWkjdeMfIIQQnw/qE+yCuh8ICrJxFTpD5x9HUlZ4U25N4sABa2x7wHYQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2017 22:40:45.1141 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1945 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mbx.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index 52cb9882bf31..da992b761402 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -106,7 +106,6 @@ qla2x00_mailbox_command(scsi_qla_host_t *vha, mbx_cmd_t *mcp) uint16_t __iomem *optr; uint32_t cnt; uint32_t mboxes; - uint16_t __iomem *mbx_reg; unsigned long wait_time; struct qla_hw_data *ha = vha->hw; scsi_qla_host_t *base_vha = pci_get_drvdata(ha->pdev); @@ -490,21 +489,24 @@ qla2x00_mailbox_command(scsi_qla_host_t *vha, mbx_cmd_t *mcp) mbx_done: if (rval) { - ql_dbg(ql_dbg_disc, base_vha, 0x1020, - "**** Failed mbx[0]=%x, mb[1]=%x, mb[2]=%x, mb[3]=%x, cmd=%x ****.\n", - mcp->mb[0], mcp->mb[1], mcp->mb[2], mcp->mb[3], command); - + if (ql2xextended_error_logging & (ql_dbg_disc|ql_dbg_mbx)) { + pr_warn("%s [%s]-%04x:%ld: **** Failed", QL_MSGHDR, + dev_name(&ha->pdev->dev), 0x1020+0x800, + vha->host_no); + mboxes = mcp->in_mb; + cnt = 4; + for (i = 0; i < ha->mbx_count && cnt; i++, mboxes >>= 1) + if (mboxes & BIT_0) { + printk(" mb[%u]=%x", i, mcp->mb[i]); + cnt--; + } + pr_warn(" cmd=%x ****\n", command); + } ql_dbg(ql_dbg_mbx, vha, 0x1198, - "host status: 0x%x, flags:0x%lx, intr ctrl reg:0x%x, intr status:0x%x\n", + "host_status=%#x intr_ctrl=%#x intr_status=%#x\n", RD_REG_DWORD(®->isp24.host_status), - ha->fw_dump_cap_flags, RD_REG_DWORD(®->isp24.ictrl), RD_REG_DWORD(®->isp24.istatus)); - - mbx_reg = ®->isp24.mailbox0; - for (i = 0; i < 6; i++) - ql_dbg(ql_dbg_mbx + ql_dbg_verbose, vha, 0x1199, - "mbox[%d] 0x%04x\n", i, RD_REG_WORD(mbx_reg++)); } else { ql_dbg(ql_dbg_mbx, base_vha, 0x1021, "Done %s.\n", __func__); }