From patchwork Wed Aug 23 22:05:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9918567 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 29B83603FA for ; Wed, 23 Aug 2017 22:40:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1CAF8288F8 for ; Wed, 23 Aug 2017 22:40:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 10F8228A9F; Wed, 23 Aug 2017 22:40:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D0BB288F8 for ; Wed, 23 Aug 2017 22:40:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751191AbdHWWkp (ORCPT ); Wed, 23 Aug 2017 18:40:45 -0400 Received: from mail-co1nam03on0064.outbound.protection.outlook.com ([104.47.40.64]:14752 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751005AbdHWWko (ORCPT ); Wed, 23 Aug 2017 18:40:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zvV4e2962Khu6KBCy1j4Fv8G5w23LdAz4UBVr1bus1w=; b=HQ7NKGejN6hTgt+Cn+fOP0nFKRwDaMThZqQ2Vu4Inhij6gXM0l6913hgOUyHvcB0FMa20soeI6kFa52sNUOn7lyntn5TfXV4F95lWm1oKwnH8tiUciMl9pAwE1e7vDnaTPXWgZuCYZdSqz8ssSSO7q0W3hKL4XjhOWT2qYrBmEk= Received: from DM5PR07CA0026.namprd07.prod.outlook.com (10.168.109.12) by SN1PR0701MB1949.namprd07.prod.outlook.com (10.163.131.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1362.18; Wed, 23 Aug 2017 22:40:42 +0000 Received: from BN1BFFO11FD026.protection.gbl (2a01:111:f400:7c10::1:125) by DM5PR07CA0026.outlook.office365.com (2603:10b6:3:16::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.8 via Frontend Transport; Wed, 23 Aug 2017 22:40:42 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; oracle.com; dkim=none (message not signed) header.d=none; oracle.com; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1BFFO11FD026.mail.protection.outlook.com (10.58.144.89) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1341.15 via Frontend Transport; Wed, 23 Aug 2017 22:40:42 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 23 Aug 2017 15:40:39 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id v7NM5UH7003270; Wed, 23 Aug 2017 15:05:30 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id v7NM5U9u003269; Wed, 23 Aug 2017 15:05:30 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH 30/31] qla2xxx: Do not call abort handler function during chip reset Date: Wed, 23 Aug 2017 15:05:24 -0700 Message-ID: <20170823220525.3115-31-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170823220525.3115-1-himanshu.madhani@cavium.com> References: <20170823220525.3115-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(428002)(189002)(199003)(2950100002)(81156014)(87636003)(86362001)(101416001)(72206003)(50986999)(8676002)(8936002)(76176999)(189998001)(48376002)(81166006)(36756003)(5660300001)(33646002)(478600001)(50466002)(106466001)(47776003)(42186005)(105586002)(1076002)(50226002)(6666003)(54906002)(356003)(5003940100001)(626005)(80596001)(305945005)(69596002)(2906002)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0701MB1949; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD026; 1:KnHBn0i//i2mKetdOevy4HQUfPrd+K8dnXUUmsIMfFZB8HwY1g8aH1d7ahDNc50qk60U37JPBqEhIPH8jMMYMUNxKkAs6u8NDq1DK93VKHkUh8KUaMJUdeNTbYoDk7eL X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9ed1b417-9797-4a08-ebb5-08d4ea77fc79 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:SN1PR0701MB1949; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1949; 3:3skRzMcHl273yHRDC9DtF3per3mL5a8cYijc60akB92/lG74xAVWsqrcsGuuGP1BdLHCmuwg0L2nQCa3iwLJEAFd+Ha7bC1KYigN66XZC54OMtJ7lMUVM0Xfny37v1+Lz9GxzDEgV6J9qciBSouAzN2/XDCaEqzacZ8IxgvUioR2ZqNzexgd01rh3mm1m7/3E4ZOBCxTsrbMvC+vQUsN/wNw40h5gfIadA43A80K22KOYzoYADS/SC0GSxBqPvdhyJbf3lC5uSo0vA7FTA6sSSA+zx9UybRr5wGYpqFP36ZqG+cASnukGL3FYAxtR0A++0kkG8mcpX/Vccx6+4YUOA==; 25:QFB4Ea3KZe3f++ONJDKkZGtvhVVojGJ2iCJoE2THOsTPFoz2oi6rHcFA9E5tyhmxQovHIsGMBd14d9+XdzCv3jmAk6wdwus21dDBo0QsK45Iw96Q/akJld+cMXDBCfC50KEqSjOKAkq82CAwvbyHNBUbiLOiK+HLR27zIGmDek/mIMh+G2Fow1j5W8mpxsW6OIS7p0ycfqU4g7nxlzEPHXo/ftZYeJm9SitUNX5UzEO8lR78XD69RqqG+0ZPI4WhJ0+nmTCOgzJ23MutTYh3mgcASRLA4e4axQGlWWlyCrWS2iuOghNxqWDa/S5oCcUVZEnrdb1lzPsMHNhGjCHqqg==; 31:c/FxH0naotiUK4c2kPDIUzkqYI4E8tlZ+e4n54qhmbbCdJ/wHSvFxL1QtNZafOtH/D4ZZ3/f1qiYR2kQgTnRdognNRceRlf2JaXwECqFM8Kz/zEtOc+dnfp+C/eQRC1MNeeekpC7ol5usdsBWIQ0q5ITrteYhhnPCzJajkfFfFp+1aQTI22GltUIcmh3AYKxMm/WJYawmG+c/Mq8bgmRj2TMJGfvHY9lwMElOd/Z2us= X-MS-TrafficTypeDiagnostic: SN1PR0701MB1949: X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1949; 20:3vD3WFyLkOYCqSrR5dzbRGJbhfJUfpNfOgq562L9zx+RKNwSlBCKapYma1joZ/d6ZwhkK6arD3aZHisqD4aRnwawwURQotbxGg+YYXqNR5YI/GFxIIDA2zMFyi4lxlr+Qt85e1fQDL0QE5vBnHGaxDJKA83rPAiCyUoPI0Mby7IQkmswkSVZxax19GuWik0+ZKp2ssC76U+4K21GTpV4DAeBKnvdLNWNXg0+LC2sUtgK0NBt9jJpb2uZUBaNjDugmE/OqIsYB1fTk7IbvC9+OBCVi7Sx+DV5dnNIPqDZGRA9JK7PDu5PX+vq4/ZR+Uzfbxr+MfnQRZoH4jo2tyEr2AEbgLTm5Crue73VXv4R6MVm2renTMBdJLS+Ox6SyJrBhpW9yhD0W3yLV3VywTjWeZicNJ5uvymIU4zj6OnFEgkMgUgHRxs3SseCDiySxAebB0awxb519lOGWu7XNnxFs7uSD3gE8ol07oAYmBtZJbPOLx/3JM2cNG6HJzLk/D4z; 4:0yhp+2S8kHr9gW6FdKGSK9VAX/XLxpep+/IIWbhkgOAUojQoEnWm2N02bicOatyvVNL6jr2MervnNdujQn4JgqdN8cOURgyyl45QJsVi54BiNCXvowiPJHjiq/VTEYVJIMfu12FjqcWmht2ef4Xqhjin5RQqlETNdGXzHNM/1P03XYJlQHXrUBHNqBYfK7NVDGMm3BPSx4a6rEqUasTJR1rn0rdIT5iOaIlXdkZ4EMYrDmr8G9NWQncanqEjB2Sh X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(13016025)(13018025)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN1PR0701MB1949; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN1PR0701MB1949; X-Forefront-PRVS: 040866B734 X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1949; 23:Bi6veRlcg/SkiZqJFzD4Y7ydJDj979BUM/tURpjFBIFgWbB6AE5kgMJ5I6HlQ4IQgwzlSWwVH0IfilCXsT2kqu+vw8bXhnIH7dXMCmxh3uolOZvXt5cBZF0TSoE22IKcCQQBXCwDRDlJzqr4X1SkeZaelRJx172yhRNY4UWp3jZh6nNbBlNGC2xuqMLWoS/f3Zkof47bh6Gpce2Rk0YUInMBLaOGfubtlkN/B2OsyHoa71fmTy7LS3rS+L5F/z4YFWRtmcKVt95rrjbIHMy5o74jM7Oe+pJACJMAX3WVwD9ylBXvqhueX+W3U2VfayPYV1a4zYyRrgZ+y3+VMobpB4ZmXIY1Hq8qInb33PgXClvoKicHVxc0ZpacNN08DuHDnOhOxmtU71caq+HT/Epoco393DgIWO5ylYjNA4QYyvR1OoFgyV4ilOYxD7fW4igXlJAM7ioEjc7sySXVW3lxqBVAntH4mtotGrtQWXhcMfyIfxvDKzWisHwK0ca2x8GUWzZN/lv87rBk3JNV3ATAKce8r72/qTdQeDUbeUOuCJPYRHVV/o8oZnloaZjvGmPanbm/ESvVK7hdVVWK/pFzAz7Hv5OrC07ZwQLJ9iaoh9Y37RJxmKJRmv5OcNgrG40tteFN0YdpQIkiMUrPfeHGjmWjT3V9SEXnng+dJQXHvpUdYqjeGCby57g58r4TI2pPeHA9iHbrxYzK8AWJYW0a/gLMbcVn+ZzgwZoVJq5Chi38kYXOyFpGgcjPQhku942p15atCMyfVtRUZIC6Mvq3Ud8Dm52KtDe5PiIxkIPjagDQu+SKWNQ1ZrVhWWY3GQIWXnmd1LKhVwonSTTGzyoeESkh45y+FtW16iQDaQTkrfcLD6XzojTd2f0eSwdudrq0zdBPcPkiQRYK1RNgEW6XUZnHTc5WfW8sQg64A5t mEPPrXFZDo/GU9pa6mjIXVXcJ X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1949; 6:W6/pKfmGPZew+UeyNFTkv5OIuSJ7TXePWnqAiiDgLLIa3jRxi4ecxDpDMK7c6bR29Jhltwmxj9PeMj3L2jFBbF8dv8BoLG1bjQudfWch5z7XQhUZ8JTZxmZLW8Hcr4dxPpfo2ENcM2X8xum3iBPyO+R6vmwvC6iKgfQdGL6f7VNF9r51B3dxWfK44mt/1t+u9Wnx+QNT7Z6nXdq7/68YPG5qJXq8nsDBmisLEzka/Wc2Vc7Uux8WvQRVFeUDGGMkonyMZVtEFEEcgXcqJIBs/jCd+R30HySDlSPqQ5Xc5oPsgRucTdMkv+f++IvfGoe+RvAcTeYXnLZ3qudQN46YTA==; 5:1YXRkhL68ymK6HfOeCw4fJHbM8cOX96qyQOU+6rCEtErAkM6jpWnDZtFSq33m1JfgM9TNDr03TpouSzrVQ3y2PiUS3QX38C9r6wJAZDVVKqhf5Q8vywsjA/MBaQxCvJkDDj+2q9L+N02uVS2On8R3g==; 24:YoAx4gQfgvaImEuuIY1l7+KCQ3JnyEJFCyyjAO3ytHjTNRTEvug0HgbVadrSs0LEbZNuxcwvMdbbF2HM2U9gLr/1IIvleMW9OH6I7TGHe8E=; 7:j1XoKW4ku+oRGtXkz+7lyTJnjXCuzdCAdQ1Ns7aqkvK7ITo2Z0x1OEXT9JY2N5QdNPARfN60zL31irx1qIj82YOXrPSC2ES8j7r/orAQOrqdsf1xcDxL4up37eiKDi3gJmpXzKUsxuGEY6/Ht4XS5fmmnz5Yacjqr6EOmrWq0RGz4XxQ/EvFrKk8FJb5wi5WdWoeCt7EnF5mhq/G+LkL+fofgw1AMyTQaP/XbFUpiLY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2017 22:40:42.0506 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0701MB1949 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sawan Chandak If there are IO's running and host reset or chip reset is triggered, IO's can fail due to rport time out. During chip reset recovery process, driver notifies the transport layer that remote port no longer exist, by calling fc_remote_port_delete(). When this function is called, it actually delays deletion by "blocking" it. It sets the remote port state to "FC_PORTSTATE_BLOCKED" and sets FC_RPORT_DEVLOSS_PENDING. When driver tries to abort the command by calling its abort handler function, abort handler will wait until remote port state is blocked state or wait for dev_loss_tmo time. Due to this bocking, rport times out and results in an IO failure. This patch adds a check for any active reset process before calling abort handler function. Signed-off-by: Sawan Chandak Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_os.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 715427f8e732..56bd086b79ea 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -1732,6 +1732,8 @@ qla2x00_abort_all_cmds(scsi_qla_host_t *vha, int res) &ha->hardware_lock, flags); } else if (GET_CMD_SP(sp) && !ha->flags.eeh_busy && + (!test_bit(ABORT_ISP_ACTIVE, + &vha->dpc_flags)) && (sp->type == SRB_SCSI_CMD)) { /* * Don't abort commands in