Message ID | 20170823220525.3115-8-himanshu.madhani@cavium.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers | show
Return-Path: <linux-scsi-owner@kernel.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C1844600C5 for <patchwork-linux-scsi@patchwork.kernel.org>; Wed, 23 Aug 2017 22:05:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B410828A39 for <patchwork-linux-scsi@patchwork.kernel.org>; Wed, 23 Aug 2017 22:05:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A8CB928A74; Wed, 23 Aug 2017 22:05:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0D49928A39 for <patchwork-linux-scsi@patchwork.kernel.org>; Wed, 23 Aug 2017 22:05:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751140AbdHWWFn (ORCPT <rfc822;patchwork-linux-scsi@patchwork.kernel.org>); Wed, 23 Aug 2017 18:05:43 -0400 Received: from mail-sn1nam01on0081.outbound.protection.outlook.com ([104.47.32.81]:49952 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751093AbdHWWFk (ORCPT <rfc822;linux-scsi@vger.kernel.org>); Wed, 23 Aug 2017 18:05:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=fw5D5RXv6yzcKLo2kOnAEcZiwH23IedSULgA5HSMafc=; b=E8hVZ1uCZ3RGomsWMgzJBRcXFCSxkA4q5kZQ6sI5Ao/Yz5r4uyU50PP2gy69p1IFJDwIGVNf6vwsN3HOAnInyDiM3lwPm3Hb0oOp4Q+/O/ky7x2Myu2uLv/AlO/ovSeftx/ZJnD8ngf266QRINfMkQ3dHR+dDGZAeMDsavMVybQ= Received: from DM5PR07CA0031.namprd07.prod.outlook.com (10.168.109.17) by BN3PR07MB2515.namprd07.prod.outlook.com (10.167.4.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1362.18; Wed, 23 Aug 2017 22:05:37 +0000 Received: from BL2FFO11FD037.protection.gbl (2a01:111:f400:7c09::155) by DM5PR07CA0031.outlook.office365.com (2603:10b6:3:16::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.9 via Frontend Transport; Wed, 23 Aug 2017 22:05:37 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BL2FFO11FD037.mail.protection.outlook.com (10.173.161.133) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1341.15 via Frontend Transport; Wed, 23 Aug 2017 22:05:37 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 23 Aug 2017 15:05:26 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id v7NM5QZE003178; Wed, 23 Aug 2017 15:05:26 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id v7NM5Q2n003177; Wed, 23 Aug 2017 15:05:26 -0700 From: Himanshu Madhani <himanshu.madhani@cavium.com> To: <James.Bottomley@HansenPartnership.com>, <martin.petersen@oracle.com> CC: <himanshu.madhani@cavium.com>, <linux-scsi@vger.kernel.org> Subject: [PATCH 07/31] qla2xxx: Fix system panic due to pointer access problem Date: Wed, 23 Aug 2017 15:05:01 -0700 Message-ID: <20170823220525.3115-8-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170823220525.3115-1-himanshu.madhani@cavium.com> References: <20170823220525.3115-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(979002)(6009001)(2980300002)(428002)(189002)(199003)(2950100002)(5003940100001)(54906002)(76176999)(2906002)(4326008)(101416001)(50226002)(36756003)(87636003)(478600001)(1076002)(45080400002)(575784001)(47776003)(5660300001)(105586002)(80596001)(48376002)(72206003)(86362001)(50466002)(106466001)(189998001)(33646002)(42186005)(6666003)(50986999)(626005)(8676002)(305945005)(8936002)(81156014)(69596002)(356003)(81166006)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2515; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD037; 1:YsGQM70u8xvTpp3HlC2U3ZeVFJKbrMVtBXghsn090XUZ+LatRy0u0+jHUbAP+epuGMHR7EUYL+Iw6miQRjTkK3bfXTSaPczb+VmG/tnz6Hd84c79G45WwjyRYS803+v6 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 679748fb-d2d6-4e20-e6e0-08d4ea7315d6 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603190)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BN3PR07MB2515; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2515; 3:AbRlqOudKDKttr7pQDmphg5Smbfb3cW7Xm1+KKmRa8MMw/1QICjdjbriILzfrGCUSzBQJG7nsKj+2L79LeiG4U1GW6A2L5NtpwCFotW5Ll3xDlv63Vg0vrkGuj+pGokkDa+EI3ijl73OaChe+idVCQ92tX0c1RbhJXoltjJVfIoPAZNHvKcHcs42SSDCKYTmDilCMxRv5z9F+PIF/ByWNo/OUnPHWOVKZ1lLBHwc+6YzOKEN/3RrMl6bMYZOokWOa/a+wtnzNCcxw6L63eCx/DFJhYtxiJx7e5uLMs3+7frXjH4gp6noK3iPE2w9bhGSq9u1EMq8QwJinfC4Mftq8w==; 25:cenNUAK7xWh+pNUHvMOOJHq47G0DQbEuxEy7lAFbUE/4Cn50d8UCkDko1vIlBviQYPkocpgo0FCdiO6+YoPKLHhaSI9sHK2VhJ7SrX+39i2f09hsncwSI/FPMYV8bEl55Rz10s8aKQw3aiuscV5qFL0xXXRldtHxSyDz9fiiWoCeKlsZkJkyDyrYspLvcSLNA3crEDe/mrXyfD38I8IdFIe8Sm/viYA7bdoO3Inhvi5o5fieG0bwpYNfW4qUnsgK71a9U08ZuzG1uJg57Afn/74BqTT+iy8VdhQlOd4n7nOz8SIaXgBBWN8kVaeifuk3Gzo4j5pEgUqGSrKJ8qTXAQ==; 31:H4LhoJX4eo8hguJodB3qFPGQxEyhy0KtKXz/YT/7NwwnSz52ZxYV10eGXYKpfin6bVOU3QsdhHBLNgR9twnlm64IuXBSBMOFqh1hdW/596JI9dJIJBzC9qXoRfZnHuTll6LH662bOMKimVxRtgT10tPDa8JuQebHzESjPZjWpY2jKdLqmjA+fKQGf+AEjVoaU83uiOlwO9G41/hh+gNcEFv9TkhTA3gY/NsuGKSxo7A= X-MS-TrafficTypeDiagnostic: BN3PR07MB2515: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2515; 20:5RzzCaW7JpadKWx5Fp2DGoEO/w0uaAgBnPOotGeHXibZghjvCggwelKaJom/zLycOu8Sr+knjDV2HjbQ8jbLCbsbtx5wYIbIxWMT1csgR2SCTWSdV+StkQWLP1TT3DVGmKQCxtSZIXacPr5Ir+AT1c5ISFESibeQUbMD2odThCQAtzQtdV8NemnJY3KmCwGdD9Wc9+DhGhsxuIQtUVBYdpE3QJOvs8g7HJiuyDCJc2ncaXCd4L7S5RAZnkIGKQl9mUT6xM/8jWeaSVcP9I3V4y6pDP1/WTslfQa4TXClNGWDL56b+MRiOsuc0TcBxnrdQvlp/XOtkWq6Fv52IyyEtJWCbietAiOEPfGW4mbbgo/EuTWfbzJhBh6+y0CIlnsiOHRxieohTYKCwpigxzoJSpRp3auy6du6qQt6LnnsQjeY+RFPp4CL0wXxfqhtv59JAPw841Vng4lFuNHGkAHIQuKpC2Fk4q7bEuEs9B3umLDpdEJtlKrc0V8V9V/4n8lW; 4:GlimcXdwaqF2XS4LNDccgq8cdP9p1mldFVSSh6M1HM9JWTGDRnbg0jrjwyQhtiLFyZNRr7xXjP5V27MrkzQKoTzwg5U5TELidHTO4+R5U23xyeLInw0k0o7i1nSZkGeT7FH4qcHw2cy62MHyEEwCrF5+BPkKC8BHnIbbnx8MCqWN5dHkJQbPYB5Om+4ksbZlRNsOcMFqvIfwWVaJEmTE9TeSkCTsaLymzm8Ig2dhpJ0YW5HNpNZFNN/Zlq0KVKCZ X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: <BN3PR07MB2515E3AB1156DE52BC93C63EF5850@BN3PR07MB2515.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(13018025)(13016025)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6041248)(20161123560025)(20161123555025)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR07MB2515; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR07MB2515; X-Forefront-PRVS: 040866B734 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2515; 23:LJ+GRIfRiz1KHSXyXUdqBu+bu+WjnNvtNM9dXM4Jg?= =?us-ascii?Q?vQMi/+Nyg7+FunDiIHL+URb9oRciRjyfs+UqNqvPeArntE8cYX65qHM3gV/Q?= =?us-ascii?Q?gQiOsPMNodGgQww/O5eOyxZUhPKgN6nQMnBTSu/AOp4xr+TI8tu757adm29o?= =?us-ascii?Q?6Ewi0H9n+G/+MmPDeeGVb5+C3ww+/aEnu8SN4DDyHl1eB+p4TecUiG5bhFCr?= =?us-ascii?Q?0jLu2qGxTzh4nw3oo7CIvy+v2EXTfCCBelTBugUu5yLs0gLNbiax9Qr4qPO6?= =?us-ascii?Q?juzjTM0ALtnIg66EsUTpVQ+JBteGebxmUT+Kv7hOkVsfJBDa5PI8LGciPZqf?= =?us-ascii?Q?kua7ntt0dcPhrWugz646cwlhFIGEuCyTitkSzH1jcQjojwXVmnRamWCEvu0m?= =?us-ascii?Q?rjDgSOAKxpCrM+IVWVRvOCPoOD4ARFz3oUqn44bF6znQ/ciDZ1UDWry/U7se?= =?us-ascii?Q?zd43JSjnbC6rHSN5zvenw83zb8ey02coWSXQ7K6tCjRiudXLAx9UTThl4tRN?= =?us-ascii?Q?/YQHp1lJsqpJZ231fIHWWThqCLHa2TLV9p/fa2ccfLaphmaBdNsHybmyYVtb?= =?us-ascii?Q?P2BjsdILBgfl8PFxK1cq9xYbuk7t9j2k8Rcb4/Rg2bYWnVP3Bqe39neL/0Dg?= =?us-ascii?Q?pvxpdlACGdorHIv3gYpiDIoG2WI8QsBCmq7Wi4N8YMfeqlzyfRNhnVdDymnk?= =?us-ascii?Q?fUPV4FM/sLQywRp7S1xWCE5Wo4TjDpbzebDt8jGcSWPFCmNXFKnksG9iM62N?= =?us-ascii?Q?LBFUJIGFW5bmw6tBYQEJIbBneWx1ot3tC+opCBRKWGq57jtJVT3RDnMASNlL?= =?us-ascii?Q?RXxyjGcb0we/TjxjHtrR/M4lhgMa7KXcYddPojwblW5noP46u8l82M87EJiJ?= =?us-ascii?Q?d5FQ/kgnF1X2M11TfwUGI5eeoUCrz/U/ZMy4w1W8mmWYA49WDHEqSR2L6LO8?= =?us-ascii?Q?i3cMSqeOvwFuau2v3C12ybVHvidaLNoRkS1/ecu9XTXS+xfjfv/iPbGtD60c?= =?us-ascii?Q?AkEoRHef+3202oGa26EuLBwF38pIBv/ZjvNr/go7QpW9SFuxgSI6HIG+ZAZ0?= =?us-ascii?Q?qhsSjShKq3vxC7ycAnfLHqtI4rAt4Nz2ccGygVF2nQVXKqoZQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2515; 6:n+3SJcnkHGzcvn8aewxMSgPlE5WTu2NlwybfJ9lCJ0isxaoB2B2NbbV/auGcyvP0cSX9amULxHJaJNCl0fk6kcUcvZftB6FFhzHkRari7PYLQe++fKB17DUkG5yQeGqV5sLEiGvcURV9hka8qit/Hzfkfzg4y9qVBVfwJCprJ/TGuoIfEam76o9VQCROl0++xyiCkoXxvjsPBUpXi5xfXawe3ashxaXYaCdpt3fpRVsZ9+XBQDA64mQOy81LkxKf3j+tAya/fSI+F/kM3oyMB7i2fxaBoZSJdrN0g6i9h16ppValBhORh1aBpOEC02wE67BN6CqLWUfi/VejjQ116w==; 5:JIYJKR12RbS25ue6MyDXjOiyYD1Ube1rJxsVIW+rNMVkO3MiHLz+wSBUUsA1PcX3RRY8gS1PcNZofl1S+GuxzQuk/fwvcymctXU+8bcsDkKwJqr0qeWnuaxSsI7MqWbrcMTPinKJK+1lBC3bBlgHAw==; 24:ZLgXiYtMjAWWDarq/i+QvyH7Kh3czqlcxY16eDp3n/+Ypdrb9Nl3oJNgiwE1VM9i3tRxy+SeZR9J9gYksv/yveciGwL/KrFdAh0N+xJ+D3E=; 7:nMs+FfwArRbO5sCEGx1+3ob1Ob3z3lzK2Lb+6sJGR4fYVHtWTU+HHam2c/vKye5J6uRBNJQ6z5157W34DSpfWtLVmbZSZ42gk81hJythq5pW5NKs5LP41rvRdw3l1H3HQPqcwBNDZ6OsnE97K6aViIqRRU7byakabmIuX6dhb+FZgJsPYoMNgtc2vr28LEGJxN255GzlkpssX0Xyqtvu8tAlz6Qdoom6QzLdhhRPj9Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2017 22:05:37.1194 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2515 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: <linux-scsi.vger.kernel.org> X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index d3a51df27b0d..c6c066186d97 100644 --- a/drivers/scsi/qla2xxx/qla_isr.c +++ b/drivers/scsi/qla2xxx/qla_isr.c @@ -1537,8 +1537,6 @@ qla24xx_els_ct_entry(scsi_qla_host_t *vha, struct req_que *req, sp = qla2x00_get_sp_from_handle(vha, func, req, pkt); if (!sp) return; - bsg_job = sp->u.bsg_job; - bsg_reply = bsg_job->reply; type = NULL; switch (sp->type) { @@ -1577,6 +1575,8 @@ qla24xx_els_ct_entry(scsi_qla_host_t *vha, struct req_que *req, /* return FC_CTELS_STATUS_OK and leave the decoding of the ELS/CT * fc payload to the caller */ + bsg_job = sp->u.bsg_job; + bsg_reply = bsg_job->reply; bsg_reply->reply_data.ctels_reply.status = FC_CTELS_STATUS_OK; bsg_job->reply_len = sizeof(struct fc_bsg_reply) + sizeof(fw_status);