From patchwork Tue Oct 10 19:08:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9997101 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C4F50603B5 for ; Tue, 10 Oct 2017 19:08:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B43AD28722 for ; Tue, 10 Oct 2017 19:08:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A793628742; Tue, 10 Oct 2017 19:08:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0013428722 for ; Tue, 10 Oct 2017 19:08:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751428AbdJJTI3 (ORCPT ); Tue, 10 Oct 2017 15:08:29 -0400 Received: from mail-dm3nam03on0078.outbound.protection.outlook.com ([104.47.41.78]:26612 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751168AbdJJTI2 (ORCPT ); Tue, 10 Oct 2017 15:08:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HQxURCl75oEDCMpcK1s/4uzKheIp1GSXogEUpnQi31g=; b=f/vLCHIkgtpmQlYgh8ZYk4ksMupYP/2A8E4C5KjZymj3tGFNhJcHXnwOfETt6UeFRvh7RI0mtBHJXFMYF0YJ7hmdIRfVBUvn9kxtgb1dAbxyBvZWdRk9KjdPahJONDIu7xRmjD7tP0iBEOY1SurcrOP5OzJDdpoIEp2YHhNB7iE= Received: from BY2PR07CA0033.namprd07.prod.outlook.com (2a01:111:e400:7bff::28) by SN4PR0701MB3823.namprd07.prod.outlook.com (2603:10b6:803:4f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Tue, 10 Oct 2017 19:08:26 +0000 Received: from BY2FFO11FD005.protection.gbl (2a01:111:f400:7c0c::189) by BY2PR07CA0033.outlook.office365.com (2a01:111:e400:7bff::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.77.7 via Frontend Transport; Tue, 10 Oct 2017 19:08:26 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BY2FFO11FD005.mail.protection.outlook.com (10.1.14.126) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.77.10 via Frontend Transport; Tue, 10 Oct 2017 19:08:25 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Tue, 10 Oct 2017 12:08:22 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id v9AJ8MDC027011; Tue, 10 Oct 2017 12:08:22 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id v9AJ8MpO027010; Tue, 10 Oct 2017 12:08:22 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH] qla2xxx: Fix uninitialize work element Date: Tue, 10 Oct 2017 12:08:22 -0700 Message-ID: <20171010190822.26976-1-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(2980300002)(428002)(199003)(189002)(478600001)(2906002)(42186006)(36756003)(48376002)(5660300001)(72206003)(356003)(69596002)(4326008)(54906003)(50466002)(110136005)(16586007)(50226002)(305945005)(87636003)(5003940100001)(81166006)(80596001)(316002)(189998001)(47776003)(8676002)(33646002)(81156014)(101416001)(1076002)(8936002)(106466001)(50986999)(86362001)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN4PR0701MB3823; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD005; 1:V/atxaDJu+wL/KDxBZptcxSUgvyuNUSDyTzWJvPBjQMUjGIrRy8jJIcScek/kit2l6mRKtZOcn5v81G3NyiT0HYX8ryqLzDsf8654E9LLiEd0dYBOYtmwENO5C7sZ2ot X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2338c7d0-10a0-4e1b-b716-08d5101248f0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:SN4PR0701MB3823; X-Microsoft-Exchange-Diagnostics: 1; SN4PR0701MB3823; 3:1+6FXPR4DMNzZaPylmCdZD2sKPHR0W0q1EOQN5qSR9ITjea04YsJju+atdHRxr/u368NrXBlnmTRf1aFWey8kobB30hjgh3hl5Uz6wjjPALpwkPsFq2VcK59rRpq/2Fe5ybllpEn0Pe6+T1aroSTEmlunLJQKMtf9yl5GDyMWpmVP/Jv04i39oazFUOjLhDnBoO1w44s1RDCocEdx0Wrt7G0p0XtSE/J5Aeda7H82FhT7k+He/DrsRRrvK4nv14yLElkvXXsu4OTQA353Ls6FM59kilvNGlF5Co9hT0AtWIy4GOVLI7FmcfcFSWBvzlcSvtL9M/xsto17G4Uj1AKvA==; 25:bJTEpJq+vwasRivDh3/s5PqBDMxgHqaymjNI6s7U+Z4feSBkSW6MtscPDNlLLgWSft9wf+CuqZAWOOC7JDWI4CNC+rQT3V1AzBP1cZTdOoEdOdrP2/MvZULS0rZDzI+SPQnT5YFYnRa9d4BK0BlvwLGtK11pUza0zuc7pMylmwMNO/oYx1iqW458c3LUzvXhUcKOnvsOLbkltpFmOFtTonbxqcRuWT1qhv32HAgaTfqdfhYdziLRQ0r8+Ic4Tbt6tsV/hd3wsGNfkkezL8MM8B0VAHpySO9ja/plf0SvubbvxOnpz8M9lt9B1N8gggJalDCkl4UhPhhFuG3UMmuvYw==; 31:4hSWdsX+tWzpso8DiWqgxGz9cKwyCqcUF4/z5H3GiVOC69hI2+yWgmJ27MIbqeQyWxYI84T4dCXURUecNVZdjvH3uBIOrPdWV1Kwr37TVCp7XHtJKZ8zQ2pw+84x4DSK0SC1RZqgTTVbEkmaFr9OLjn7Jt8/aNHkwgvAuIJ/IRsnQOhAnGbCpfGn7KfSqGfwWi++Yb7Pw/UbW+Rcquu6oGYl9+8XN/PBPF3A8W/MxT4= X-MS-TrafficTypeDiagnostic: SN4PR0701MB3823: X-Microsoft-Exchange-Diagnostics: 1; SN4PR0701MB3823; 20:u1t1A/26SGKX+AHnN5ozZKis/DlYL47EqqsegpMHTN8PKS2A/kcTzQ6Y5D8+FhmfRvSHA7EJ87Dq0Y9s9l4HOiHH5D4yTl23Vz0297g6E/7IYbl22Q4rDRuVsGY8EmeQAqWbUXfT+csOQctxfqePqo8G+gMLgcl7ELxt6AjYclqq9ae6vqBFtjyhjtiPRJm3yL2srqwYG2VNoLRNAYOlczWJUfiJHgLrnz0d7SBUSBWO1F8+mIYvUJfIi2xYfTCbXfKbJmLu6WogyCrJyUhSByYDpHAzAk+gmFNYFXwURRCxMOqerU+ULxBZ49eyCZWmM3b5ogiMTQS4moRZV2wAEqkKuFb4yjsWxMtQ0xkHcgzwrmcUj9OiVmDSxf/ir7Nb+ODNnvEDIjKzGX9I4LjFJSrUWcfYbWAQOa+9Lhxc66upccvy054LFGpUA+4rpNz3Hbr+Fdq7unauz44nheZ9kdViZPh3ZJPkSFVY/gekjtDqZ+c2btbVIyY/WCvcmTjy; 4:5EN5xyHaqIQlTe0ujsucqi0c6vkd52xyFGgJ3pXv5fA0POPhfoVmu8bP4aE6PHd2na02Zj/oI+IpMgZlZ2mY8eWUFJn07eAvswXcbssIgI8mvF+S6NDM39xoTzKayI3LDhTtv2oml1v+rB+JrVxnbxXzl9REHW5s5hVGDi4tyvBniOKyRmzjAO5DrWORCLLdVK0GGhmhSo/cCQ0anF2dr9Ea9oWBR1eVEKFjeZ0u29geeXh/TCtvNIieoPGwfykA8RlhJzSo3KJ6MrEwhRPD0vS1qYZVvjpqDin4MNRT4B4= X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6041248)(20161123562025)(20161123560025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN4PR0701MB3823; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN4PR0701MB3823; X-Forefront-PRVS: 04569283F9 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN4PR0701MB3823; 23:oiB8T4PKj8jf6OvxZbYCuCgYfLMLzRUPAyfb/bs?= =?us-ascii?Q?sla6eZHVCouOXloKvS8m88C/apI3LFFN9IYcODk89Wl1fxO4IkrAgyXVRHTf?= =?us-ascii?Q?xRnDyGK4V9vEgj+Vo3JHoKQ7lkW8iDh7K58SIdHe5x6+wN7mZ9YD0O41XXyR?= =?us-ascii?Q?bjifr3JmIuY43qF6mUlbAgugxMC9p+gXUR2tT8edjlKnBwBKluBfe3bnsawX?= =?us-ascii?Q?lrkIA5lF5KfOd76Rn4iulce0nt2s61wfYe5eU5GRYFax++XHyjkTZQd6iCqR?= =?us-ascii?Q?FVQi4cl9I0479+YUnUUCS1HXElAu52dcNTC/TCPK4EbJLH45vUhNMMkLo+dF?= =?us-ascii?Q?Sh0YygMD4EFBN550bzjHDoffJ8xiTWk+Toz5e//A55QZTK4QbLHmoSHGKh6n?= =?us-ascii?Q?MRxhOWvCHaujC6fWesM0juWkZxW8H/ObOIMHcRSj07DzV7wK2U2RrFIuCClk?= =?us-ascii?Q?BeP+fcYOk8oVZ+wt+U6DdASTiKoGjJY/bII9P3mA/dLBqsWFabKxsafYhwre?= =?us-ascii?Q?PIwGZt2kwTY0vOarstF/gD1Ynrqnf8uTNkJm0+XuUbN6GePN04zskbrqALiZ?= =?us-ascii?Q?Lyus5SXbT+NjCLe1BYtxXlbL3lrUbGOpnLFpM9dX1Sc3erqFvzzLtD2ECPgE?= =?us-ascii?Q?W5vz/PW0Dpzxh1nXZ4FSn9phffEUOr0YMWL2+LORh5FNqQGne4urKyDFkM7X?= =?us-ascii?Q?LRs6emt8fk8QvswaIBFxE3aH648fuvTVdLX3tYpwuRPh1RWNMp1kngiHr639?= =?us-ascii?Q?zE+amqLxotKo0mj+heNKRYwd5h4+xNy63HhZ94kcTG49J+NzeJRwinCJpwEl?= =?us-ascii?Q?CUQpbkE4dyQcE8z4BGtzY/2L7JLuIbUDgd5KHZt9/LCwP1S7QRvNGGzPUgio?= =?us-ascii?Q?IFgqNa3KlKRoAyzzynIP7ZLnEd4syehilwQjYJwwCiHjUfmT16mb1PMk1qY4?= =?us-ascii?Q?RnXQEDsZABJRqAC1jRVeYmVV28CAbEF4qou/VNQgM1A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN4PR0701MB3823; 6:LncZ3ftbWy5Xv7MSy0uF+TYKT14TOd0VANl3fGgy49LRvptnDjysVLM9hzgrWGfjqsn72bIwCJfSu5/J+MmzJVQFaj25OYcfoytfBKQgvdaQ0PCM0dFD5sbus8yP7DtI+htOxE12R8BpFFtziKwiLhab8RdF3e/KkAmkZNl9yjNUD9FP+8ijdWNBIXnCSLkkGOuO8x90/Yz+z29Ix7sVTsm2nldF+yHIlcLgCWcHM7ShOa1Vpsd0sI4IqE5vPZQbPb/3ogrmpgM5TQxnDxzz3yAobneUopt26GFEDYPIWEmkUMGeqDm2+gT6gJgrxrIlgTF/rn4ss5HSyMyDozaLAw==; 5:tK3HJWWVwNsQY0YPK+F96sNTwwkRlp443GZa7tDgY/t9/eaSInuxAn8Q3Az105MEQEVuN5kVPDLWY7L8sfB5aiTA99sfOdrkv8f4t/07bgpHHGs0FTh32RYGoiVYZ3awC6vCnGhlP+R/wOgwLroP2Q==; 24:4NEnBR/lGAEnXeMOXeEcOvMK7rjxyqQO99J1a74x0shGKNCZ+GmetAyraO4iyXeGhEzqUk3rqGLkpY88lFk57FJfOfC6qGR1o6BMPSrRkwc=; 7:aVTGK4mRiMbSkXit1KKNomxHMXETdtPyjTKuVk+1tbXpKiyxLf9aKG7kAzHSVgXDiT3/GUINv+aSw5iNV/YAsOHffOMemtAGusrx6M+Ec6+rOOiF3LM3b277WQFINOrcHGyVpa+W+OKQB0VMPU/ld0hguSWHyPZPL0m5Stsqhp/xhm50YeY5+Kq1lo+Y8O1RtjIblkQ8ON8jA8sH7kkCwrH54IAU+xj5hN2VWp0UxLE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2017 19:08:25.9800 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0701MB3823 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran Fixes following stack trace kernel: Call Trace: kernel: dump_stack+0x63/0x84 kernel: __warn+0xd1/0xf0 kernel: warn_slowpath_null+0x1d/0x20 kernel: __queue_work+0x37a/0x420 kernel: queue_work_on+0x27/0x40 kernel: queue_work+0x14/0x20 [qla2xxx] kernel: schedule_work+0x13/0x20 [qla2xxx] kernel: qla2x00_post_work+0xab/0xb0 [qla2xxx] kernel: qla2x00_post_aen_work+0x3b/0x50 [qla2xxx] kernel: qla2x00_async_event+0x20d/0x15d0 [qla2xxx] kernel: ? lock_timer_base+0x7d/0xa0 kernel: qla24xx_intr_handler+0x1da/0x310 [qla2xxx] kernel: qla2x00_poll+0x36/0x60 [qla2xxx] kernel: qla2x00_mailbox_command+0x659/0xec0 [qla2xxx] kernel: ? proc_create_data+0x7a/0xd0 kernel: qla25xx_init_rsp_que+0x15b/0x240 [qla2xxx] kernel: ? request_irq+0x14/0x20 [qla2xxx] kernel: qla25xx_create_rsp_que+0x256/0x3c0 [qla2xxx] kernel: qla2xxx_create_qpair+0x2af/0x5b0 [qla2xxx] kernel: qla2x00_probe_one+0x1107/0x1c30 [qla2xxx] Fixes: ec7193e26055 ("qla2xxx: Fix delayed response to command for loop mode/direct connect.") Cc: # 4.13 Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- Hi Martin, Please apply this patch to 4.14.0-rc5. User will see call stack everytime qla2xxx driver is loaded with kernel where original patch was added. Thanks, Himanshu --- drivers/scsi/qla2xxx/qla_os.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 5b2437a5ea44..937209805baf 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -3175,6 +3175,8 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id) host->can_queue, base_vha->req, base_vha->mgmt_svr_loop_id, host->sg_tablesize); + INIT_WORK(&base_vha->iocb_work, qla2x00_iocb_work_fn); + if (ha->mqenable) { bool mq = false; bool startit = false; @@ -3223,7 +3225,6 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id) */ qla2xxx_wake_dpc(base_vha); - INIT_WORK(&base_vha->iocb_work, qla2x00_iocb_work_fn); INIT_WORK(&ha->board_disable, qla2x00_disable_board_on_pci_error); if (IS_QLA8031(ha) || IS_MCTP_CAPABLE(ha)) {