From patchwork Wed Oct 18 06:09:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viswas G X-Patchwork-Id: 10013485 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 54ECA60215 for ; Wed, 18 Oct 2017 06:09:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 469FA27B81 for ; Wed, 18 Oct 2017 06:09:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3B95E28AB1; Wed, 18 Oct 2017 06:09:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B25DB27B81 for ; Wed, 18 Oct 2017 06:09:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933431AbdJRGJp (ORCPT ); Wed, 18 Oct 2017 02:09:45 -0400 Received: from mail-by2nam01on0048.outbound.protection.outlook.com ([104.47.34.48]:38493 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933304AbdJRGJh (ORCPT ); Wed, 18 Oct 2017 02:09:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mscc365.onmicrosoft.com; s=selector1-microsemi-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xg8MxBa4E87q3LlKa6Dl5s1kUQh7sIqDQBgD6SWYtrc=; b=OBAj6liOGRpNX1sMf+MxJ3eZLUfHpXTgXrSFzr4lfkcc8nXCuFwa5MQ7PrAsWPC371DaSPTWIFi/KVz/8gVq0XNE7rnsPyKpoJNEPfEEqnRH7Yalr1vTldL5d+lUqog2EHxxAF5Qy1XgWiyXkM14FK5PfHDsgq0dJMuP+R/BkJs= Received: from BN6PR02CA0081.namprd02.prod.outlook.com (10.161.158.22) by BLUPR0201MB1827.namprd02.prod.outlook.com (10.162.239.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Wed, 18 Oct 2017 06:09:36 +0000 Received: from BN1BFFO11FD017.protection.gbl (2a01:111:f400:7c10::1:144) by BN6PR02CA0081.outlook.office365.com (2603:10b6:405:60::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.77.21 via Frontend Transport; Wed, 18 Oct 2017 06:09:35 +0000 Authentication-Results: spf=pass (sender IP is 208.19.100.21) smtp.mailfrom=microsemi.com; oracle.com; dkim=none (message not signed) header.d=none;oracle.com; dmarc=bestguesspass action=none header.from=microsemi.com; Received-SPF: Pass (protection.outlook.com: domain of microsemi.com designates 208.19.100.21 as permitted sender) receiver=protection.outlook.com; client-ip=208.19.100.21; helo=avsrvexchhts1.microsemi.net; Received: from avsrvexchhts1.microsemi.net (208.19.100.21) by BN1BFFO11FD017.mail.protection.outlook.com (10.58.144.80) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.77.10 via Frontend Transport; Wed, 18 Oct 2017 06:09:35 +0000 Received: from localhost (10.187.72.81) by avsrvexchhts1.microsemi.net (10.100.34.105) with Microsoft SMTP Server id 14.3.361.1; Tue, 17 Oct 2017 23:09:34 -0700 From: Viswas G To: CC: , , , , , Subject: [PATCH V4 8/9] pm80xx : panic on ncq error cleaning up the read log. Date: Wed, 18 Oct 2017 11:39:14 +0530 Message-ID: <20171018060915.8549-9-Viswas.G@microsemi.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20171018060915.8549-1-Viswas.G@microsemi.com> References: <20171018060915.8549-1-Viswas.G@microsemi.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:208.19.100.21; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(376002)(346002)(2980300002)(438002)(189002)(199003)(2906002)(316002)(2950100002)(106466001)(53936002)(4326008)(76176999)(50986999)(57986006)(2351001)(478600001)(305945005)(356003)(189998001)(5660300001)(76506005)(8936002)(8676002)(6666003)(104016004)(50226002)(16586007)(36756003)(6916009)(81166006)(1076002)(68736007)(97736004)(69596002)(47776003)(54906003)(77096006)(86362001)(81156014)(50466002)(5003940100001)(48376002)(106002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0201MB1827; H:avsrvexchhts1.microsemi.net; FPR:; SPF:Pass; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD017; 1:/lNCM5HIrdYgPNuyMOzdF8D+v7H8c5PDxjZ1CGbfmhODUCIoLdtnP9B1lcyzkZvpgNuoXm++xHmr7JW9jyuq84PeSNYlZ5zyLwAQ4b95ZnF8+23ByTonHWCyVRSyw7b/ X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 42c4c1bf-c9c2-4954-d09a-08d515eecee7 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(8251501002)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:BLUPR0201MB1827; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0201MB1827; 3:bPcxhFRGDV5boKHXZwJDhHHOkPGJ7LcIYsAx/OrimzqlN7BseSUNLDgAGeXclJbKS8GdtjH7aImQs969mQc1NhdIRkMTsJdxgmTUXYIs1kYRSjqpRNQveQeO5rK/hGEqPLmDqHWwNNUHwlyEt4nJUgxg116PyO4JTUYwBYIH8XrCNTHJHIfI1AfMNZ+9vabGjxP9vJ3PXKBsdFfXLiJmTozDJGhQeG23FuzioL+Kculj3rkcbUEASUfCXJ6dMLeOgUkd+ntt+AotVZXBf8musTLhigvqDjkIP0M4N85RradqqSnLMpJBBYCzzN8+XovaWu4g/1JaRzyWA7jN3K41M73gL7zgAF7+3YVoPEqWdM4=; 25:2QYGFtmg7R3juCyMcp0vcRTGzspu73db2ht3iVq0K9nYgAW8jhgArxddiXcJFfO6jR6lqmKG8txSBbhMyJn/BY+JQZcwjDzaRWa0YqKFA867V3fN39wyo/3s+69nAfh9HRDS5T4Tktu+dlssEnI9KwWQTvMSD/hbGU2bs5uIQ/i/WV0kpbjdAq258PitRr7DvExbsPQSNoLKbDHksNMDfNFNVF3EP+z+FPhoPadEXSvq2WZEe0+7afY7Pabdcsn3uytUJfHQCbUiJp+QLoa8wjFs9T0p8Qq/Cazh3AoczCGQrrNEiT4fEnbXfuUBs9P9ON0lRtWrXskBNkh9RfAXIg== X-MS-TrafficTypeDiagnostic: BLUPR0201MB1827: X-Microsoft-Exchange-Diagnostics: 1; BLUPR0201MB1827; 31:ny524VxUWKiamrrsR5LkPX+kp4s7MMS2aLEyOB5IwoamOi+koK8WQgCt62D0PZ2ZmzQkeByTVmQgK+AErB59pV/zsGoFKLHNIVeuVHd5iVsT8YrOdySwHC08Jo3v1Uepu0vXLxZRw0cvsRxZ0fpbH5gv0czmj+bfPRZJAKm5qMJtfTQPIz12imdJVn4HHeyaMk1PACf84IaDEOvcdejwJFE7Kdso+UB4T2HZVBEHdsw=; 20:ZdFZOiouVwbXW4fgRFrunVVqAS3JNogS9svG2WzsOyPL/fPyR6XHtYbSCfAvD9zxMcJeMMYyOx3JtbtLDESWWhPSVsQl56kKDpYtghJLD87LoskYNrjuTUBL+5VWN9DcG84eDwvq3pauoIu/ooFA7c7yI+2XtNb41XuNnqYWLoRuN7cH8z9VfJYLzd72NvKKW3En6mnw6FMuham7ni4Rxshd4vGJ/otG8YNINsEcE5qxI/r3gH5S3b6zF3J+Ed8ToE+aZkEu0puXniolkWXsMEDr6fNitDf/VjQqaj5MNEsMY96h1jL5rftSa7eBVou2yinIHHh2Y6Y+7TnRjBZgRjr2lvDV16zurQEj0EtHf5KNJsYCQRFQPoiy+XGOgV4Umj9JQGFx/zdPtHl0xqWyLu/8nw3ib77DkguUCYUR+wInA1n3KB6hVkxYaRQN2hYqBOOGYzTDLs8k8ikFIwWqhy7H6pHBOnmyW/DwrMd2TSz+yh7jqpeZRBHXLqMJNEPi X-Exchange-Antispam-Report-Test: UriScan:(72170198267865); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93004095)(10201501046)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123564025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BLUPR0201MB1827; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BLUPR0201MB1827; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0201MB1827; 4:EJU/1P0dDQOv333jMJkmZllBZ0G/2CC8dZbDqVBEKJoR/flaMemWwahsIfR8a0l8INRlCbx2ks/WBU9qmrUYtoriJihUUtoatIK+UUyz41koiufRk9UBG3fwhr3Rh9VjrnXgnxlfNCXFDGtcYjPtIk1puTWTILdKGFnIaYCNrjwxnKYzBeluMmM5o/YRvRtd5CzKEwS1sT8CspsAEsDJEZBydoy3DmWgoS5xyQutSb43QcAO9/W3aWcmcxuvqfxN/I1gtHrc0NUKVg+OA15Wvy4mreMzXKq8eMMDrlT0k7w= X-Forefront-PRVS: 0464DBBBC4 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0201MB1827; 23:i8kFpYepuzkCB/MBShmgLGNhWCTwIfE570Cj6Tw?= =?us-ascii?Q?hUXqy0sNuYR6haNe49eVIw0SXppABpDTTfCbWjhBu5ioFBa2aVD2k45Zv2BS?= =?us-ascii?Q?CmE4Dar/xi9d8r3++9jCaQpRb+yrEIlF++dsN3YY5EiuMfnU4KxDrw+SFj9g?= =?us-ascii?Q?K6YNyKJKT4iINkDYoDlEhOBXR1zZetfLjbCgs4mkmic7ByL4NuMHcOfH5hWq?= =?us-ascii?Q?U6FXbtSyQHyeCkezcGD8lFTzZPY6Ley5VueRwR6ks0c1m93xhs1S7gMLyYaq?= =?us-ascii?Q?ujVY+1vXZImYSXU2tdvsmm5DrVF+Hf4BvNOL4+bR8t3MWqsiq8eSVm7Rt+b6?= =?us-ascii?Q?Cr+2j435FlOfwGPB4LQLLIpk+21koRz/Dv856VgGUFwXtJovT65fEnLNtcRN?= =?us-ascii?Q?sYIKNGuukyMwEjlKS3T0TA4klQvwiB9xXhW3ZbcoQcARztbqHuxPNx49O14t?= =?us-ascii?Q?Mm7X42P0mUH4tx8KGOdhDFXrl/3SL+KPdoko4ALrdsy4s0gnHGxAjB+3q55i?= =?us-ascii?Q?6PGjM5C+I0XfP17W8qmMxYJzShF2RJsuzHkyrga4yhYJqIhQN7LimgA6FGAV?= =?us-ascii?Q?mdy70bLqNQDUUTWX5tlFYvArAk7+CAqpJTdYCvibq/IjbOqRkFR5AnK92w/Y?= =?us-ascii?Q?ZHsX/4MX92Ey0tvObmTSfKgN7H9T26vYoIZFQNYDiYH6pGgrsZjGmZ1PyBfF?= =?us-ascii?Q?B2xzQ57ulzSEvRlTiDJYW5x1WXZjclHwURHkYAvelG2os43j2g4LLQi+cRxF?= =?us-ascii?Q?ZdqR3LOXhlNrzYQxFLLNfp7LJbNt9XYgX5ZJfORxtYICDV1Wc9hMCW2ZAEf1?= =?us-ascii?Q?+O1zMZCs5ENW5eTsmPbgXARVr8l0nJ+Kuxo0Pr67aJZpNzHfFpTbs8LIuzEn?= =?us-ascii?Q?e4upsL4pEZH8pVTRbpK3Le1wPwl9xNttNb54gXaO6WghKT9xfGmHQFteth6k?= =?us-ascii?Q?hJ/Mv2Rf6GbKWuQb7p1cjVlBfJDEjqB8ZPZng+b6OeFSDR6VTNJFLUPqUXFR?= =?us-ascii?Q?gB2dD5xkcw6ZF8gLdf6yp1AG0VrjF0GbYtRiM3m0dGWv/hSvYUsv+eOvlHGC?= =?us-ascii?Q?w2AJoOajctnoEBt2ZWcEo9Mj8bIOWqiwwYp7ZNcc+FCQhqNpzfw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0201MB1827; 6:FQDadKbqF4HcUEUMkWNuwHSNglA3C/nMiFWTDnoid93kN4UxJZqGlCIe07IkoD4phqg1p5bfZ3yQA33bhq+e8ptoYiMcx8UpSaQ18PL5VAG8Hd9sla7Mbhtatu4q+oy0ydDnm75+hTDVgs6FOcXlcTtHUHvTyuoRLlQzmf6SNr1nAHRA0IwdV7/behacVwlIPBJ+1nssX7ufRibtlYqwGWX1xLsKGq43Y42UNiOULb7bm1XuIg5/qnp1lqOFM8JKD5dlGVQlSYqAyCtHKNLsJakm0VMHgodHvqaLc//TTLDRBteCbTHgPj9Ieab7Ln7CaW9HpAtPWm6OSpBBUkuJ1A==; 5:H1VFNrHtTf8/AqCQB9I6w6FEwKqdYfYdKY0XgdzjBQfZO0cPlcNMDXKkZXvK6TPb4w0WgPNqSvIP6dKFqc6vewps7S5S1V/BvJRbrG4FebHPr2osfvkhUzqsItXPzNBrhw48TRWASQDuCz5QjMhRjQ==; 24:LhpTNSqvdv4FxZO/Tkxqa4+ppqj4sVpD65wo3vGeb1h4rYjCOcPFFrD93QbYT5Ootb6NFyhn6IXnT/w8Pwa/an5t70bGpl6FWNZhRXRerpI=; 7:aojHxUtMjXpGnRGmPdf8jav+Q1iELab03Svw2/UtZzVs+dWe3948Q/+EwZhe9E1nab1wTNO3/c15XZc9XwfDOuBmtWolVv/P6nCAoQZspKuIG7OPXfSFxAi2GmhXzhv7bIN2dhswkxE2zDEA1Ei654RyxRQweL+TB87hv5ylrVtLSovNMIvgj3iJQFJaMKxllL05RR/azF79pBtnJeybZ04rSk0DUFj/s7NlA2lVfj4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsemi.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2017 06:09:35.7059 (UTC) X-MS-Exchange-CrossTenant-Id: f267a5c8-86d8-4cc9-af71-1fd2c67c8fad X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f267a5c8-86d8-4cc9-af71-1fd2c67c8fad; Ip=[208.19.100.21]; Helo=[avsrvexchhts1.microsemi.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0201MB1827 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP when there's an error in 'ncq mode' the host has to read the ncq error log (10h) to clear the error state. however, the ccb that is setup for doing this doesn't setup the ccb so that the previous state is cleared. if the ccb was previously used for an IO n_elems is set and pm8001_ccb_task_free() treats this as the signal to go free a scatter-gather list (that's already been free-ed). Signed-off-by: Deepak Ukey Signed-off-by: Viswas G Acked-by: Jack Wang --- drivers/scsi/pm8001/pm80xx_hwi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c index f6df11a7c2d5..42f0405601ad 100644 --- a/drivers/scsi/pm8001/pm80xx_hwi.c +++ b/drivers/scsi/pm8001/pm80xx_hwi.c @@ -1489,6 +1489,7 @@ static void pm80xx_send_read_log(struct pm8001_hba_info *pm8001_ha, ccb->device = pm8001_ha_dev; ccb->ccb_tag = ccb_tag; ccb->task = task; + ccb->n_elem = 0; pm8001_ha_dev->id |= NCQ_READ_LOG_FLAG; pm8001_ha_dev->id |= NCQ_2ND_RLE_FLAG;