Message ID | 20171108084415.dn443crpreqwqoiw@mwanda (mailing list archive) |
---|---|
State | Not Applicable |
Headers | show |
On Wed, 2017-11-08 at 11:44 +0300, Dan Carpenter wrote: > We added a new error path here but we forgot to drop the lock first > before returning. > > Fixes: 0d44374c1aae ("tcmu: fix double se_cmd completion") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied to target-pending/for-next. Thanks DanC !
diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index 07f2d95f7ae7..cc2468a299d3 100644 --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -888,6 +888,7 @@ tcmu_queue_cmd_ring(struct tcmu_cmd *tcmu_cmd) ret = tcmu_setup_cmd_timer(tcmu_cmd); if (ret) { tcmu_cmd_free_data(tcmu_cmd, tcmu_cmd->dbi_cnt); + mutex_unlock(&udev->cmdr_lock); return TCM_OUT_OF_RESOURCES; } entry->hdr.cmd_id = tcmu_cmd->cmd_id;
We added a new error path here but we forgot to drop the lock first before returning. Fixes: 0d44374c1aae ("tcmu: fix double se_cmd completion") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>