From patchwork Tue Nov 28 19:34:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10080931 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8D943602DC for ; Tue, 28 Nov 2017 19:35:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 818AE2811E for ; Tue, 28 Nov 2017 19:35:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 766D029619; Tue, 28 Nov 2017 19:35:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0FC092811E for ; Tue, 28 Nov 2017 19:35:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754119AbdK1TfN (ORCPT ); Tue, 28 Nov 2017 14:35:13 -0500 Received: from mail-by2nam03on0071.outbound.protection.outlook.com ([104.47.42.71]:8096 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752410AbdK1TfK (ORCPT ); Tue, 28 Nov 2017 14:35:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ohnm/9+MHrke8aC9rCPBNS++7rKiBRWH/lzKvl7izWg=; b=TeVShgZeU4kGinG2hB+xt+pxLTzKDXBMcoULIki3Jd3+XVt98nmKUbsYch/G4lxRQs/Oj0+o61HUqRUHfKfI9rs7jLXPBchescfK2TYaLCDPvf0oNWiYXLBBThGJ84zYQGYpFRZMzu+GA0F9p5Y56867cgp+MTFq151lwWKfGCI= Received: from CO2PR07CA0044.namprd07.prod.outlook.com (2603:10b6:100::12) by MWHPR0701MB3820.namprd07.prod.outlook.com (2603:10b6:301:7f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Tue, 28 Nov 2017 19:35:08 +0000 Received: from BY2FFO11FD017.protection.gbl (2a01:111:f400:7c0c::151) by CO2PR07CA0044.outlook.office365.com (2603:10b6:100::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.282.5 via Frontend Transport; Tue, 28 Nov 2017 19:35:08 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BY2FFO11FD017.mail.protection.outlook.com (10.1.14.105) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.218.12 via Frontend Transport; Tue, 28 Nov 2017 19:35:08 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Tue, 28 Nov 2017 11:35:04 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id vASJZ4s2013738; Tue, 28 Nov 2017 11:35:04 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id vASJZ4DZ013737; Tue, 28 Nov 2017 11:35:04 -0800 From: Himanshu Madhani To: , CC: , Subject: [PATCH 02/22] qla2xxx: Fix gpnid error processing Date: Tue, 28 Nov 2017 11:34:43 -0800 Message-ID: <20171128193503.13695-3-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171128193503.13695-1-himanshu.madhani@cavium.com> References: <20171128193503.13695-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(2980300002)(428002)(189002)(199003)(8936002)(42186006)(106466001)(50226002)(50986999)(8676002)(316002)(81166006)(81156014)(101416001)(76176999)(356003)(189998001)(305945005)(69596002)(80596001)(51416003)(47776003)(110136005)(5660300001)(478600001)(2906002)(105586002)(4326008)(54906003)(6666003)(48376002)(50466002)(86362001)(72206003)(16586007)(36756003)(1076002)(2950100002)(87636003)(33646002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR0701MB3820; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD017; 1:nu7REQVo/raD8rU9pdv5Ne0wekTk3jjzrdQB8OTs/1EF9/hpCcDFDqXIN7kVyP/3OmN/+V2hmBUvWoS9Y7h03hlymKCvI1Md6b/4NmihVKX8sOHtKSY5KI9oBAI2auDo X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f51eab78-a4cd-44e5-7c70-08d536972240 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603258); SRVR:MWHPR0701MB3820; X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3820; 3:yeG6uVQyRcEV67A5sYj97uZul0giW1TrqSwgAydrWN9v/h5bvHsqTaxO25FxwVS9wufDppyPOdf2HBTyKV5QE0kU6eYvEClvF3u6gKo2QIm6en/2aqho19RQBHEHen06I0K18jIAEtN0ZZTs7zeKX4YngQACV+/lmNqYS/H5Fq9L0l3LYnaTtnhr5NzAHLzC4FRHAB/7Pj8RS9gzhsS529fcbaVLyD2eRjXL40fcxx7xEJoJ8BSUI8xbN3rVDlkNoee6g0P51bil8rZBUAbu/LZwGDnkaehrFOixIBqYdFbuJpzkPlZDVDatHieqBYs84pMbDsz6WGIo3Iq4tjUg5L/ilZOX9xWZJTp6RrpUZnI=; 25:fuaSlBmXLIMsnOMczjVcUlgppn8RSy26q8gT5z7GiToOyYrNtek9Gt4Pc1gH3Ux1BgKFmA33zrVPRCzc9/fnIYDkpfII8QMr3egM/pIJceyA/0gchva2RUuJ4Sxx3l9BVYDarnbU35wgPwXnCzzcCeMDWxisTEPo3R5gvgZbMEnBoWpsaz5zQqUdeP/KnoWgUYcQEwzoGyUZZbPGTzzl+FeocZil3+NQB1gQB+oaegquQSs1bGHxT051W9LopXNx+1pMMI68V7bzecAuBoQrleQfMnVf9uOFs4cudp6x8v46J9BUTD8pRfq8QWowjpnEZGgMFj9TYd/nfkfOW0TddQ== X-MS-TrafficTypeDiagnostic: MWHPR0701MB3820: X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3820; 31:xFZV1zf/OxYu3i1sBSNvtCpGT/xtxkRN/ui6C3BJbLXftVHfkVfIHOOxB6NxXTQG5hccJ6MXorrIHRF5aNnGtHcKnlAVCKO/a1sEkN9vjibnpKwOezFHjSovgqUJbfRBnpqQCHPrUnZ5fr5VJSRq0j5w0kQMlFz6SyZu+rW9bRYYiSdaoTyiKuiJnRmHlKsD0BxrRZOd3yVIh8zagTd0t6j5epUaGy2MFrAIBq9r4Jo=; 20:pR8igG1zNmVgQJBWR4HuwKATNOluwVYQvO0fMyr7tPHKMtHQU01Ym64xJGsQMb0PRP3jld+O/jzVOtqYFSQnunDnkG53yxbZD9dq4ZGy3NsNN4SLnt1viTn+nAK121ujkIHkQSM8BDkgiNirgtl2EROfC/jk2Ie2ylRaC5z8xvmE622Jd7Fz7yx4TduHKcIeJZyEl7blYeNt32WVik006YkoigTCAF9FI5iKJFCedtl24sbiNODWGL7iTFvNA+WuQJjswLIOKNvnNgCF34oWPn2+9GhEU9qyYJSEwVn9H9wCsQqGMOgcv0KutceHcW/iocbTELLq2kIfgboQSY+WEAfl4juE+9cofrB8lE1WRavwCAZbjMIgqreASheH+UuQdHRnRj0HrdXtg2ETmZZLrwone30s7DXVxm98Xn5TGhIPokOLhQROL0HakU3hhCtAslImwy4RSVIhp4y9F+E3uKbqyUJd7I/6xlMhFcvWixURAqVLDtvopD0+Oq1rqGuY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231022)(10201501046)(6041248)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(20161123560025)(6072148)(201708071742011); SRVR:MWHPR0701MB3820; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:MWHPR0701MB3820; X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3820; 4:6ZgRttrQUkDQu/vXwkJMujp4WE/lmZVP8sWsdHQ0JohlS8bdVbivlhWJ5wrkOlh6aVAOsRgdYJySW4kNvgAld7joP1YWKFPp4QlpjcDCTsgZ0RizEtiMtdnWnrV133+yUgWQi4h5XvRdH57LJHs0rKRbw5O8VNca6+tDPH+CljtQTIDU2L/r01yjYpzp5PEY/rjidEgUEgQr0TDSqt5QZ3vE0JIbJ3l78X3U4bi1m3NB317CL9T7mXeelxTe+14REzHGEzlc93rpqXNGPFKXmYIjTGc0dKdJdRCeVDRtk0wwYT5qkntLR0qkndu20yWT X-Forefront-PRVS: 0505147DDB X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR0701MB3820; 23:ckjO0sTeLGeeGueP5Tor1iHjvXvXr8ObfzhhBgb?= =?us-ascii?Q?GunlHpEUyNHnRaH3GF5vflDJC044Mg9x0AjisYIYNDrhiYKwz+WFtSbFMEAW?= =?us-ascii?Q?lpUongvaeoQzDNFLOhGs7Qd+KgmEZk1IW0VDpdCBcoAIJ3HoPWbEAJ3AjBmL?= =?us-ascii?Q?2MarZhixmKaetbe6fC23i82dqsJKQ9kPjmE5ljqWavpiWut+Jl2usKwg+Wr+?= =?us-ascii?Q?Tog0mKQcjT/JtE0kHVZf3hWyvbg4LSRmx/4xjyjrFyZvIkP/bTLiJoFcA/pB?= =?us-ascii?Q?ROgT9Bb3l2D9SKByaeqU+358VkQmf28inhLq5aB1YsAbQKSHqowveR8SUPWs?= =?us-ascii?Q?xxDD/8VXNNalc/cHrfiVnWGGkfQMdCWaF/qr6xStuZYYqM7e3dlBwJUCic3d?= =?us-ascii?Q?uEWDp9kphGt4zYTieZBiNeg+BHgd35BONd3o8++WU6EYgYFv/6wb6AFIHLHe?= =?us-ascii?Q?7h8/uPFd2JgTlmK1WSAbZpP805HCnfgeeOKAS0Do/aeZ3s8WbH5q0RZmFlQs?= =?us-ascii?Q?hv/7A4wK0gG+00eI1n4Mnf3yL7NWxs7MxvjC4DNzvMRKkNaPySjGZuzhwt3L?= =?us-ascii?Q?yFrr2MhAMVyImsaaq11Z+681HL6Z9ZABFGogVxnDSRaPgV0CX8gPlBWwDfsW?= =?us-ascii?Q?zpvMQjvJBIHAUPnAewZtGa3/WnbSk3fF9DAl3P4IjhQouY8MfcX8Ya3B8UU+?= =?us-ascii?Q?tsU0BL7mzjN1l96OHxMNpfGolR+pzBzi/hKDwlOwTmXhrL23eaprj2gMiQO9?= =?us-ascii?Q?3adhY59//IlUG4Z9mKH1w10pu+TLMEiP67MxeKYxcep72KObAaF7Qzp2Yjbl?= =?us-ascii?Q?JBWZhs96Ty7gryVbaJbMNs4aZm1gFTO9rsbQip0oqtw58MKLBR7DNFF6DKfB?= =?us-ascii?Q?Nhku0EbzX6k77ubsvbU3RkpqhNfSJS92HHphWFqSvRjYjubyiSVWearDbE/k?= =?us-ascii?Q?zv6XeXEKmjjtGhUCM5nmrQ3H6QeS8m3vnAgzJTKCZzOne+UMD6PJ0yooNQCe?= =?us-ascii?Q?EZwzFM16ntU3RQsXjIh9EwyHI?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3820; 6:Vb4V2LnmMXkb4o+F3G5ZpNlDMC/hUyh8/tmJVB8H6iYnMGqRZb/rZME5hOmS+0Q3Iyb1fUvTxSw6whx2g1S7rqA4GqegYG6n7+hZj/guYqDtbhiDvOubOlMmZYoLGX2Vp6HSe3uiMqsih9zzDQzAzHSb7SKn5U5n9W2ZN3pdHF35/bktud20Ty8EWkrdHp9qHnTwvy81mw/WQyJ1BCnUc2e1wpGJKZXBc5eNLflQvA0XDaEQJj6llYvDflj9IAqJg9iwVC77UG3wSjZ4NxLDVBHEsDLDqt23HkucA1svsfwQ2p20sEEYQGvOLKhZaacwyI2f08LWx8gWRylncLJKv8b9rT/fsmt2K/Xg3CGfNk4=; 5:EWMtvJT6dUxEzSH+mKfk1eLjqe3a0oRinlUxMwocb08l11H/HZqBVD358JRQOd8m6//uzkU32U6lr2K+y5yUUsWVNByYpmeZ70jamD9E2hk4zwKPNTPGIrXgBBXtSoHQIJPS6gJpRo3KQqz5YJa9SQ06yhLRmHSb6HHvGLj9oqw=; 24:xjLIAfnEF1Dt+/+9PVihEPhZzw4p9VTEW7anxEL224Bc+Gfwht3cVTQnq9E8Jee0ZQLMm3loCCBSiIbzF5hF3km5eHi6rTNlu8fzjutXzr0=; 7:szTN0Ts7gG+ez3lE/9TaRCJF71rYIEc/HHl8lwzYizniybIrCPYe4Lhz1jbdyNL2Pgjdv2CtvV0WzuIcgtJmqthdGQs9G235PuZC8+HzXA/vZIhua4l/DrBUf4oMq4S3u7Bnwmy85IM9vlSkdHiEjnyDVb6JDWK67G78UZjT35w2XKz7bQmBqoj1K88PuQlmbWeMryjPO+EAfY+ZeO/esjc9rv+28FrSkNSPUSCiTqYJ8htoHty5InbOSa6nUyUz SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2017 19:35:08.3222 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f51eab78-a4cd-44e5-7c70-08d536972240 X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0701MB3820 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran Stop GPNID command from advancing if command has failed. Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery") Cc: # 4.10+ Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c index bc3db6abc9a0..ddc69d36877e 100644 --- a/drivers/scsi/qla2xxx/qla_gs.c +++ b/drivers/scsi/qla2xxx/qla_gs.c @@ -3211,6 +3211,11 @@ static void qla2x00_async_gpnid_sp_done(void *s, int res) sp->name, res, ct_req->req.port_id.port_id, ct_rsp->rsp.gpn_id.port_name); + if (res) { + sp->free(sp); + return; + } + memset(&ea, 0, sizeof(ea)); memcpy(ea.port_name, ct_rsp->rsp.gpn_id.port_name, WWN_SIZE); ea.sp = sp;