From patchwork Mon Dec 4 22:45:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10091717 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 256CC600C5 for ; Mon, 4 Dec 2017 22:46:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 17C3C29387 for ; Mon, 4 Dec 2017 22:46:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0CACA29446; Mon, 4 Dec 2017 22:46:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7F08629387 for ; Mon, 4 Dec 2017 22:46:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752436AbdLDWqG (ORCPT ); Mon, 4 Dec 2017 17:46:06 -0500 Received: from mail-sn1nam01on0087.outbound.protection.outlook.com ([104.47.32.87]:14063 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752414AbdLDWpu (ORCPT ); Mon, 4 Dec 2017 17:45:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Zbs1XvVLL6cXk1iF9eJexfVMPwAR0+sEYip8BQ3Ch0I=; b=VqBtpO00TzcIxWnfZczKEtUN/BQjAmYUjfO+yZg55ho4vPwhK4MVJYJ5gfHDMvQ3bNiZ8brd7MwP//vYomEXazc6NiEmrnMT1a6CSG3RQGeRUZrzd4+dJLaviKRQ77AoXcDg4lUnjDCyHz6eGKNfhyEDjtroYO3h9uaSoRkiljQ= Received: from CO2PR07CA0068.namprd07.prod.outlook.com (2603:10b6:100::36) by MWHPR0701MB3820.namprd07.prod.outlook.com (2603:10b6:301:7f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Mon, 4 Dec 2017 22:45:47 +0000 Received: from BL2FFO11FD054.protection.gbl (2a01:111:f400:7c09::141) by CO2PR07CA0068.outlook.office365.com (2603:10b6:100::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.282.5 via Frontend Transport; Mon, 4 Dec 2017 22:45:47 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BL2FFO11FD054.mail.protection.outlook.com (10.173.161.182) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.239.4 via Frontend Transport; Mon, 4 Dec 2017 22:45:47 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Mon, 4 Dec 2017 14:45:21 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id vB4MjL4n003505; Mon, 4 Dec 2017 14:45:21 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id vB4MjLdC003504; Mon, 4 Dec 2017 14:45:21 -0800 From: Himanshu Madhani To: , CC: , Subject: [PATCH v3 15/22] qla2xxx: Replace fcport alloc with qla2x00_alloc_fcport Date: Mon, 4 Dec 2017 14:45:10 -0800 Message-ID: <20171204224517.3409-16-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171204224517.3409-1-himanshu.madhani@cavium.com> References: <20171204224517.3409-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(2980300002)(428002)(189002)(199003)(101416001)(1076002)(86362001)(33646002)(106466001)(2950100002)(105586002)(6666003)(36756003)(2906002)(5660300001)(47776003)(4326008)(189998001)(15760500003)(69596002)(51416003)(50466002)(48376002)(80596001)(87636003)(478600001)(305945005)(8676002)(8936002)(81166006)(42186006)(81156014)(54906003)(110136005)(50226002)(76176011)(316002)(16586007)(72206003)(356003); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR0701MB3820; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD054; 1:07Zt1Ebr8ChaDiBbUJfWMTefAwKPdv6LYu5kOi8ILZan7LtK+lGQb/SpqX9DGquYDU9mTPa+yzD+cM33/j8FQpxqxzmUHwZ7IxxsbP+o6sG8GQvGETyxHGi5QbAnKFVU X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3cb49c0e-31fa-4d93-8097-08d53b68c2e7 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603286); SRVR:MWHPR0701MB3820; X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3820; 3:tT4idNTRGfTsKUEzW0tHHHXXcjMG3uBsYHXEtipOzaPNKUBnZH1I5RidAQZM8BvhfTM4bTRgjKeNNT+WOTSJhp+CIEF4CMrN4+k+G6qqka1gDpvJZkXqtM5ScTMm1MTD/dXagCMHV2IvLbpetdrL+ERbjpycBxNIXNjqYCGcgNiJl4zJE7O36Ymgx6sOW89JRJ0VgiiUHbzbiPcJy0YQJTI8jf/R6onth8UKh8egHUtPvG3h4cNGYeEVQp7lAm2XEHsmpWCLmpaznfNH+ElYIKglMLhBW8r0WlHXQAJeFY/EpNaLApbw3lG8rNhaCFk2SrmhJFi3Ke7H+PY7hAM5cQWXw8v2VIIA4abH1/EPUlU=; 25:eDHNt6FuxXk6dtPl5HdynrgHjAaiVpgZy78KfFA4R6mOfWK1/P+9BoCTVo9J+ausq6tcS6Fuusfiak3sgR/Uw7pFpb6xLlu1Z8Lo1XdjEYc+2p0meJ+LYXNXjfSM1X289t9QxWnELS56bP/lRB/JjrUrZrQRnG89uM2Ka3KFmuxDLKXQu35kqjMjQmUl91JIXxWVtvkzz6gl6kQRKDZIOnoeDGpa2h2wYEtBfixVNYqU/GNQ+b7otyBGDGaq1vPxNhVb7BS4a/WFFjyYZDA4Q669YxA6EN3DgPtqYFZbv1l6gAY6L+PquTlP2d4EXKRyKQpDgBerLHqGBsdT5yTVAQ== X-MS-TrafficTypeDiagnostic: MWHPR0701MB3820: X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3820; 31:8z3ZX2AwV5nou8qVhJMO6W829jL7HbQEP2asgnCFAxILEyqruKtyLLW7rkWNNtj6q4uY0jW+wq+kJPIV+kxaljE0qwTsCMRFX4fVrnpUggYCswADH3WcVGFLCc2/7e7m9m4NQ0LPlHaW1LvGzZFU3x2puJYKmH/yTP0YYqipQWhuUifD1MlJX/R//WJFyizUsZMy4pdX/0NLQoDfGXF0949gPlA3/iLS38CBsZrsqTc=; 20:06HsPCZJAa4cbjz7hbN7B5htN6kGXbqrE6pErUlL99T7G9mmNP1CKNXrGwgoH+390TsDBKK88+emhpPeuyUi43IQ/ARs/2jfK0XLmxR+dAKHBK3AlvxAEjDOMTZuAXwpZUNzrG2HZsC2BVS9QoccRrqUz9CwCwnzdLdET3mCRHVDUfD/aIony72chhswGFRPBEqvDJBVoZmZJFhSs+vSOzcUzhe7SHvKUaFYz6R69E0VZWpIwFBkVS4f4P13hPO6L14Lr25sxzAxEGHh5M5wGW/zEfpV0ehhn28Si9/itDMJCA6Nr3wrctc9bL+nix/evCpIXcwCtgbr+N6nroRGZXe+cNgKbn6Kq+LP+pi4X23bx2JN/uPBYnAGHjz4sRIZm1cjntVGP2aRaSRPnaLS2EoyP7OPYb8NciNYEoGrQHaJTd8MI3GFvbxR4xhHy0Bm+0oBh218+eUALirTpur6rzMv+u3VsaGONj/RLwCBmTjO/ETYdGlWO35LxiFxyVvA X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231022)(10201501046)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(6072148)(201708071742011); SRVR:MWHPR0701MB3820; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:MWHPR0701MB3820; X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3820; 4:6tN6anDqDXUBZNq2+ZptluA70sX1DeZrm4ZTVYQkjqE7D7QaLB1b33K2BZmgHzHW0/hP78+p4TUkNY5iAa6fjLEfBvn86InfkJC78/mWWE2SDjuyUhVz/5jnbArR4RNeI2Z+K3WqqVCa3ikuZFKddFT4No+Ju88gMxvwsgcujggcokiPpLDa0EgR0AT2+zNIXMq2MDnQRg7+CAjf0EFVM6BvaqsLUdytCxNcIYJzJBKb0yGEGZEqb2K9iL4umtZHsm4ywbhdTLPzCAZDD+qNMvZxMGedn7L82BkUTJ/rF9Lhv/bnlyRdD5IUOF6Qr68Q5CLqFFzXXSe4movmYFMbxA== X-Forefront-PRVS: 051158ECBB X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR0701MB3820; 23:z5J9o4nLFltAIxYiu+LaOjFmzdn0dmh9MDwth6F?= =?us-ascii?Q?Cxp4Ui85pj/oGe61g4BjzrJgtv84Y0TeiwDKeIHMxsPRzx/nutNvWyy8g8Rx?= =?us-ascii?Q?o1DmbStklty8J066QjQdOqe6iuDMfrYxw3VNYInGUINSLrKsFLgcxVeiIN9z?= =?us-ascii?Q?H34+C+B6xdJdz38UgCmnZKKlqEk7VbzgMFxpwHJ3TfL4CjbAw841szVlXyb1?= =?us-ascii?Q?VqtU/E1QJHim/qH7RRJxcJ8qKjCJSH29XwQLBz6lT2XM9JBRsdk8jhXPcg1z?= =?us-ascii?Q?QGhs75lZwFt01NZKSF4OXqUoR67I2jI1m6NaVA01A342v9a9WyxPDvqgk8aS?= =?us-ascii?Q?lTAnzQTovrdWCS17tKjVytBxMTVpcvf7EQegyv+eFeBcsC34fxXXVyW0++HF?= =?us-ascii?Q?2+K9WP0X5SU/foc26WkPx+GPex2iN6c2KSjgY+8JclDTNwoEsM1m75ra8Dtv?= =?us-ascii?Q?t5e8vuEylphcNT75hwVLyWJA5bpC1PwoHb5iASH37x6UfkSvrRMDSDh6TaIl?= =?us-ascii?Q?4Fj1QJ8f2QG7jG+ysouEoDWCb+KXa/4KQatLImAVG0bxFO1eGbK5YyVm1vLK?= =?us-ascii?Q?XZmb1re119yvKirumcAxFiKM/iatqf+eP8LE1Hp7Zh260F+T8URDbG4WjOlQ?= =?us-ascii?Q?UpI5HolV1h+E32f0bHmbX2OSckvaWK/qSF/0v1eJTzE9WM1dPsKWe0SluHy9?= =?us-ascii?Q?lAqsI8XQoULtjmw30fXdabrWKppPut2AdeTjAtajCEobCWBm1XTV8Bnfs0Nc?= =?us-ascii?Q?nL284w/2fFWcGWwRTSyd4akajmgwjbVGD1tqFnJq8c4K5I88tOb+qTBVC6Qd?= =?us-ascii?Q?aio992ZqE/K+Yt7RG7rEYbyhOguPH59qGOIByBewW+Fs+gXiPmWhJaC8PmUU?= =?us-ascii?Q?TuRTyic/b9ceue+dfKNM1hUlsysGRFGXQp8mvjq5F2H4yPf67LXUZtJIngxJ?= =?us-ascii?Q?9VoCicmUvGqBgWa5vxIxkZJ12ZG3Q/J7JFdXXUygVglkbWMLnk48pIwJhgAb?= =?us-ascii?Q?cPLMG5R+NTBiaTkqd5cp2GiSc8mckj+cnHnP+oVp+iMQJ1w=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3820; 6:4L4W0qa9JruYIegv5J0iGdYeCX9vmpDvCBlbBewKnwnax6vr8XsHo4dYmxbKPfz//m0LzZNgCFOU2jTmOOTjHWKHipBUwy4brNghe+rN8Qhj3XrwSysL7phYXdhH3cEMjGbe3HAkqr1jLViKVkgSBJocDxGLNkO8BO0dWMirElqUEMG5vWqQwzbMgp22DS4xD3nS+geZUMLaIXr+qnikIFN52f85eMzCIet+H2Qeo38RyYzJvtWX9VVXnySaBoINtRJOJZUsKkAiSXNF8HlkzomcwIEhJDPbizW5/IL+8z+3LWqc0ujoKWYw7o6CZhZvzS8Ip8LKUuliaCiBrB6AfEnFEHU71Chat3AJeOgem+0=; 5:w7Bc1TbghVSVarWzMBpgQOlWWmiHBXBlDnQjbBLghT61EsM8MMX84nRkQdJ8Dad+FPhfQf8OLCOPoOzdm3z86Esy79noHGsbQ7TmODiq61HCXRCVOqJdZxR0FDfLvCvVG7j2TDMaqDPWurEf7qwjyK1+vGzm0g3/sfuQt4dO9Bc=; 24:XowyjwTdU/kcLm7BN5KUCnfpwsSrowzaAbkTrrr0rsIM6K+P+z4Ut8mvLjUKHIjL8yVjqK1sMnlffjpICO7VPdU4W+I4RpmqumTnpLqn09o=; 7:Cl3N+85FSJghi+xS5QCBgeStgvwZetWLUHAI10bOLaK1DEMQTXPXg0nj4/QfLkfaJ4XOGeijMa45HtOE1K2dn0TA5I3s4StTAarApNYv0sRtZrCDak0sYmTQRgUr6HlUH4ZhSN9gJJ1xQGd4rfcedxPP36jB5bGWnKAiHYB/du8oELi0hE7c9pPu2unUM1zjpxpi16R10CKEOaqZNLdQkeB3So5XbWZiSN7ISz7oeJBPxSNWoonDWnUYJwTSh40D SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2017 22:45:47.1794 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3cb49c0e-31fa-4d93-8097-08d53b68c2e7 X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0701MB3820 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran Current code manually allocate an fcport structure that is not properly initialize. Replace kzalloc with qla2x00_alloc_fcport, so that all fields are initialized. Also set set scan flag to port found Cc: Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index e824cdc77139..2a6242d97a7e 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -5783,7 +5783,7 @@ static fc_port_t *qlt_get_port_database(struct scsi_qla_host *vha, unsigned long flags; u8 newfcport = 0; - fcport = kzalloc(sizeof(*fcport), GFP_KERNEL); + fcport = qla2x00_alloc_fcport(vha, GFP_KERNEL); if (!fcport) { ql_dbg(ql_dbg_tgt_mgt, vha, 0xf06f, "qla_target(%d): Allocation of tmp FC port failed",