From patchwork Mon Dec 4 22:44:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10091689 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 01B6A600C5 for ; Mon, 4 Dec 2017 22:45:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E785D29387 for ; Mon, 4 Dec 2017 22:45:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DC70029445; Mon, 4 Dec 2017 22:45:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C3FB129387 for ; Mon, 4 Dec 2017 22:45:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752298AbdLDWpd (ORCPT ); Mon, 4 Dec 2017 17:45:33 -0500 Received: from mail-sn1nam02on0080.outbound.protection.outlook.com ([104.47.36.80]:42717 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752216AbdLDWp0 (ORCPT ); Mon, 4 Dec 2017 17:45:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JlXujKAm/PiGqHbgSreykaNiQ6Gj+2s/KKq6lEV7+Ig=; b=GsPloJgzMH7PZnfrP3Tgh+IopIpmwCvZZWpnzGFbvX5cZwlOKUCY8U+/2Zvi3WUllYNqWqA72tmyLeRvDtf6HNcVIkvFwcEBlOh3lFr5JjX/6yRAS4kCCuKmkOm9eW3vstPyRBu55G37NULAEM502YRz+MAX5DvqNF2QJC3ijWA= Received: from CO2PR07CA0068.namprd07.prod.outlook.com (2603:10b6:100::36) by MWHPR0701MB3820.namprd07.prod.outlook.com (2603:10b6:301:7f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Mon, 4 Dec 2017 22:45:24 +0000 Received: from BL2FFO11FD054.protection.gbl (2a01:111:f400:7c09::141) by CO2PR07CA0068.outlook.office365.com (2603:10b6:100::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.282.5 via Frontend Transport; Mon, 4 Dec 2017 22:45:24 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BL2FFO11FD054.mail.protection.outlook.com (10.173.161.182) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.239.4 via Frontend Transport; Mon, 4 Dec 2017 22:45:23 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Mon, 4 Dec 2017 14:45:18 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id vB4MjIhY003449; Mon, 4 Dec 2017 14:45:18 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id vB4MjIKx003448; Mon, 4 Dec 2017 14:45:18 -0800 From: Himanshu Madhani To: , CC: , Subject: [PATCH v3 01/22] qla2xxx: Fix system crash for Notify ack timeout handling Date: Mon, 4 Dec 2017 14:44:56 -0800 Message-ID: <20171204224517.3409-2-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171204224517.3409-1-himanshu.madhani@cavium.com> References: <20171204224517.3409-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(2980300002)(428002)(189002)(199003)(101416001)(1076002)(86362001)(33646002)(575784001)(106466001)(2950100002)(105586002)(6666003)(36756003)(2906002)(5660300001)(47776003)(4326008)(189998001)(69596002)(51416003)(50466002)(48376002)(80596001)(87636003)(478600001)(305945005)(8676002)(8936002)(81166006)(42186006)(81156014)(54906003)(110136005)(50226002)(76176011)(316002)(16586007)(72206003)(356003); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR0701MB3820; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD054; 1:cbJ0jKjM9TjCnEpxBgamQ+wIYT/aiiRxUhPmGpaBZTH/Z8nNPK6C0GYIVvP19b4xmuKVAxK5im6REdovphCqBFOghdlcd7C2CeM3Jhn3l0oEcnT43eObKY96m0Phwd7B X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b0239dd0-ea64-4e52-c5a9-08d53b68b50c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603286); SRVR:MWHPR0701MB3820; X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3820; 3:7ppCjJ3rLsJM0dyQesypFMjdZMSxkFFGMWZmBlKfqqsJiVr+og8UR6Tzk1pOMtySV+qN1WGPSfQmAVSoJ9J4K7IuTlOkkLA3LyOTl5kTUjbUgcl/3x/YG47ZXeqSSDPwHFMkgYNVEpiz/fmssjoeUhKaEpxoi/dhWEitecWR+CLyy79fQQd8bQfycV+BHYFphL1FL4uCOAeixIo3sMWAf9su4WSHPOseesIiAY85jJRTS4lxLZCnfJu73FmyCGrtBF1H4R+5+dHbhp+VWYHIDcL3JZ1eOv97QpYLJmfbo2QgkaYmjIHxQKFFYGgzeAnlo2EgiM2ROaeYxwFsuXHl886jz0wJ1BRELdKjYAYrvlI=; 25:1/RcTMpen4HP3nR3V7vgi1jGOXkCK/CuhHQIDLUSUvHiqCVctzgJQCcojznj+X7ryHRrU6wDR8k9qJPt6tZJRH5hYFz8z2Vd8YTfsm933dwgLlqHvzJw+QNbFjpRhvBUcVHqyUE7OAA46sTMUJt6XjvQ7D8H6Ayxc2Nx3XggIg7HfgczcqPkVd8xB3LrNcEJpAatz42GlDKMmXDCq9t5lHCilxk2Mz1mGZoU/X1uNzb5zE6B6/BbvlZhHe0ncj28HpaahyGKwL1tGZ6e12qjI7dEnVMf2MI7u3wrD7jCQIZMdPESlmEjZj2bXzg2FfwFPo8SIACYhOCoZqTcL4XdKA== X-MS-TrafficTypeDiagnostic: MWHPR0701MB3820: X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3820; 31:NAeTRyCMY5BpQVomyZFf27kfzr5q+MVLiysFTWjiiTE56QThROVz5gaNSSs45tG8rjkFlnSu+vwO1jSHxe4TCB/t3VleXUBcjkuvdMlO80E66EXYI1bcQi5OzcmvC5B3VB0ZmGih0/GpUBo08gfGiQERc3wjkw654d18H0YAtmYOlhDsNoI7mwGk2AIeMwsA5eK33vlyE8LYaKKFPMJhHhc1EbnCjuOafEGDErj+c4k=; 20:sr3jWeKvYMtiCOfUGMj9SFzWZdBpNHontHiwLdb91OOw6cg65Y+vKOutz3QuWrVIRiFT/aHwMHFKRfwUE39/5ao5kFgBIrZBTrufTipx/5tDxnl/IiiZ8OrBCOcrpkMaXZVM1V470BjJ7mS06S8eO3WeatH/5exVxrqU6WJQFnRz7KnnrdpZUVKxNWgpRsOclMMT5aZqMHisxE5ea42xHIio7E1ydCC5BazNnkyBGPb3Rg2zbOf+Mtdzq1nMhPd3jL4gNUEBHONmGQ9+6DACvJlH/fKaRFWEjVNpXUdpTLD+/H9sGclfJ3vqsOtBSpgxKJcJbBOWFcHOAB4JlB6L+CPDzy+rkHusBXX9URMm//qsJ9iCZTGy3bzFJvnoyzCDpWbA+4lZXTJRs6zC3S2Kn76Y4ISqbLKgqPUpzJb9UIhM/A52l49GyN9BJQRtG+fDxNE0BLCDlwxIP5RGH5LmtC8j0fhd7+UI9LsJTIqbzjlba+ZKSBb56bhaa+j7DIv6 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231022)(10201501046)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(6072148)(201708071742011); SRVR:MWHPR0701MB3820; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:MWHPR0701MB3820; X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3820; 4:xxMFqzaYzF1rh3BvtiZ/BXi1+1eLyhGis7ZEupD0IWKQF7dSvNK+f8pusG003DRIwXOYCon1FnTkRXK79LF+wDjaC2H8uddDteFYPbFAFmg2879bXXfyzaAYXCz/Y4dHizzVGDcQW1GrqSYcvdUvrojDz0jENLeXZnrbSiSpWDvUXMU9vwwrQiSB988gBvnCs+EZ6vrMUbT0U2yJoIblqs5eoxqY48IStxzD2UTi5BjdIOnpU0DNZ5R++tyD7xXK6Bk2AVbLDoZs8RhlZblC9kCCvmbloBp+A/1wPzyrS7rvUHaL+VpHIdx0l0Q9XZ64 X-Forefront-PRVS: 051158ECBB X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR0701MB3820; 23:sUbr03qieU2Ohy6l4E5EuDS/qGBtDykHQGwxvrG?= =?us-ascii?Q?qlz3rXEoIMglKUH60DmMUuuAxvXIbC5qG2/85bqQh9tFJ0s1LzVdoDqVYpb8?= =?us-ascii?Q?+qLDEiCZlpYn/kt+DVoD2TEYwFJT5yNF2qi11JK5uhqjQdOlVNhMWpJTs2sb?= =?us-ascii?Q?O1O0fNNhFYm37zThjqzzEEQwvwkmVT9vqI+wM7UVAabF8YX9Iv63ETd9Lp9L?= =?us-ascii?Q?b8y+QJVbPE7KAoVvquUITlXLCEDxFroMGZYnyXTmvqPSyejEso9qGRXc5ibv?= =?us-ascii?Q?CIO0EmxmH/pX4nisW8PJKuQ+auZ9+Md2zKNhgjTusjzsRYGWoqqK3LPLxiJf?= =?us-ascii?Q?xZVnbbklqw7HturgYkO5MdvwX4Hwb9VHh/L52ocFBtLxnHQX1YkiTvTj4WDc?= =?us-ascii?Q?aHdcUSJP5pTUWyaRSDoNJL979KhCyhKZvaKQorrmkXHJ8W8PG2qvKcTkp4L5?= =?us-ascii?Q?hOxuuuw4AwA+E9qn5z3M2T3FKkEOhVkBikJqbCnPeKxsEbMoB9wf317rZ6HM?= =?us-ascii?Q?sSGB7eRCIbyOop3AMvrjSelGPpInksD0G6aWmihr5uewLmtSSPqhqx/hCYin?= =?us-ascii?Q?79tBlK39CBE/mcg1WbCkUWsDDCTalqkEERBM1J53PfVzVJ+50RleAv5o6qhm?= =?us-ascii?Q?OuBkvc+5L2pOY4jKozsEHhOQDMcdGrxFf8al0++jvMBalyYcOWP0ZwpKdcfE?= =?us-ascii?Q?FPhsBAzYxopjsz/eBwcaGLuY+JrwBUKE/7StkiJ/A861GCihL8JE8M/+MuNg?= =?us-ascii?Q?0vY9t18btVS39DzNeA2BjzEpvNo55E6Xz2YBiBrX1aD4BcOSfwlr5p6m53KF?= =?us-ascii?Q?zDoLsfKCl1P3xAsHBOKTprDFE8W5dgAAVPe5ulaR8KRJU4MAEHex/1lLzWQh?= =?us-ascii?Q?FoOz3kYZgBdwcLeWykMQjO6c5XrdRlDQ5TmSLzfbUdtHg3tFfUXWOzElDlsi?= =?us-ascii?Q?tYYRjkw1KF0/mmfe0aLv/Sna6kQAYR4gquuuWVYSgU5jb8pX3snAyJ1PDwnN?= =?us-ascii?Q?Mv5ykQ4eG85IuWsVK4cTBxLAr?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR0701MB3820; 6:sAROT6N6vZzv2Yr9aGVZobYxaKWsfksiN4MPdZp1ccRZFSgvDxLlWuhIC9jLHrijaIoCh1Y6m0eFlzjYqKbX3ojDN/rBBmuJVzojiUWXBfD8kN48PpHmkgWcvTzwihiCSE0x2gS7Z1/flI/mifb+Fy5CAXWvK9YXfuTpydMU14WnLkeqDFZwqpXm6h04QeS+SKuHmoFqz1iVgWntZB+53rQS09U6SiXK7/fgWES2R1r+wDeO1oKl+zcPznk2RoWLwDw+CYxwsBwa70R7MB+UVo/XerKTw3UMjnqkcQS1z0t4XAH2wjX1x0YUYy7tUXvwbJlJS9D99OIWYrOteh1vffmZ5zyCUWHeungiY8J0fE0=; 5:AoX0rk+aL6Aj/a+tP0KfVEg1ona/IW/oAbgpiwnC9i9igdXAt+ZRKxz78J5P6iCKOII2FLi0wgLGtX3oqOEy1ykS1r7de3cfHBwCYLEW/NYOpjILlDocoTt4detp5nZPNJT5Vbtc8pQPAtlQ8fvg6jZMiZ9fe320pkf3hNdMG5g=; 24:lJRfjXVTZHFmsGybViVuF4OTKSt77n5fHnKR+R3FvZer+hqj2px2Pl8piyn6kZjjA8yZPcN8h9rEZu03YajtO3vREYLxsvXUljkdgMPaCek=; 7:eFtfi6Y+BvcQ8r/otkOpHXEjt2aKhe15S3snLG/tnw7lXzxyy5mpTa0ZeCdjTUUwhxXiy0juRlqABly2GaCIcIWguoJq+SQMMLYcGlsMxO/r8RGqJU3cdQ7dIpV00dN/36vRhwS/IYXogCowu9CJjMGCEwdKlFLbIjSmBMrpVSTGD8zBbhwvfrgBfZn8u6Qi1wYkcotiTUoyBddffhC+LFJnG3Ouc0e4oUSz9tZXLo8OMB3/8HL1Afq0O4joycB2 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2017 22:45:23.9199 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b0239dd0-ea64-4e52-c5a9-08d53b68b50c X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0701MB3820 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran Fix NULL pointer crash due to missing timeout handling callback for Notify Ack IOCB. Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery") Cc: # 4.10+ Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 18069edd4773..1259ec85ec0a 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -665,7 +665,7 @@ int qla24xx_async_notify_ack(scsi_qla_host_t *vha, fc_port_t *fcport, qla2x00_init_timer(sp, qla2x00_get_async_timeout(vha)+2); sp->u.iocb_cmd.u.nack.ntfy = ntfy; - + sp->u.iocb_cmd.timeout = qla2x00_async_iocb_timeout; sp->done = qla2x00_async_nack_sp_done; rval = qla2x00_start_sp(sp);