From patchwork Tue Dec 19 18:57:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Smart X-Patchwork-Id: 10123961 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 812EF6019C for ; Tue, 19 Dec 2017 18:58:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 764DE2950F for ; Tue, 19 Dec 2017 18:58:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6B58029518; Tue, 19 Dec 2017 18:58:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EDD142950F for ; Tue, 19 Dec 2017 18:58:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751499AbdLSS6A (ORCPT ); Tue, 19 Dec 2017 13:58:00 -0500 Received: from mail-qk0-f196.google.com ([209.85.220.196]:46611 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751488AbdLSS57 (ORCPT ); Tue, 19 Dec 2017 13:57:59 -0500 Received: by mail-qk0-f196.google.com with SMTP id c85so9668870qkh.13 for ; Tue, 19 Dec 2017 10:57:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=UHi0bxF2hekTH3Ey/tP8ZZFSAl4xHeRKZ8v5rLNtygQ=; b=INu542i9Dl2J3F3quBtlCsDXqxoKHcMQ6Vkq5ZIpCBxCat3u9oraaVl2xBIhzQwz9C 59pyrkQLM7mLFDAdmKDQeWQZe/FgCk9q25fmHpveQmsffGwfeyGtZPkwkFe0woDB7UsA 5MKRi153agP6+UIUonq+kwCO9YFehlJTmaRYJshqrrO38gAGwBFLTBOAX5ScyR+0WhF6 f2XnBLt0hIUKZbzt1hOzPHAoJyCInRkOyN2X+WFzTikaiJilc6KswCf6rw2mlCC5SYss CihJLHTfiw1FZggcdn1wSqKD9wDm0jHgniIOvkj6YCA/8IB/+CFNcspLtxcE654yBeho G6bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=UHi0bxF2hekTH3Ey/tP8ZZFSAl4xHeRKZ8v5rLNtygQ=; b=SCZcP/Pj+BhImv3Ej+JyXnnAkb6iUe6UHELgBqziHxZ6Jx8Zx08PJbniUETp/NI5XW CsTJTV754muiAHhsbi2YbLr5/u7FVeea+CSRlXkt0MSCt093qjHYWGqvCkmkvEgBhvL5 YoMYn4upD7IC7eNnqU7r0/MWlbvhfH8WjDPUsp8H1mEPHM+FnmUE82piPsFZUvyVrIPs a2/06J++SvMSHIFoKIhmNhkj1T3ArSMiiNCQdg7ilaNQnII5DPON8TD2dwpjwXIHlQCj wNyXxRnOg9ldB1rJJDXGZyDOh/H/n4KMgJ5cb1mhVeAxRmZm2Yb0yzsrkVsK78DJCy64 BGtA== X-Gm-Message-State: AKGB3mKQWV49PEYAmQdpHIAfNXGzx8ehvCfauKQTOhDgkRwg+vvxOcSq Wdn+fUKG17ChN3+cHiaSL+6Hqg== X-Google-Smtp-Source: ACJfBou9SjClbrXvYKNDd35mFxytqhZqgfD6bJ5WDnNuzxuUYk/GrOcxUwrJvBBvCmClmPCnwaJD5w== X-Received: by 10.55.187.69 with SMTP id l66mr6116755qkf.6.1513709878382; Tue, 19 Dec 2017 10:57:58 -0800 (PST) Received: from pallmd1.broadcom.com ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id u8sm6284688qki.8.2017.12.19.10.57.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Dec 2017 10:57:57 -0800 (PST) From: James Smart To: linux-scsi@vger.kernel.org Cc: James Smart , James Smart Subject: [PATCH] lpfc: correct sg_seg_cnt attribute min vs default Date: Tue, 19 Dec 2017 10:57:50 -0800 Message-Id: <20171219185750.24348-1-jsmart2021@gmail.com> X-Mailer: git-send-email 2.13.1 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Prior patch mixed up what argument in the macro was what, so min value was placed as the "default" argument, and the default value was placed as the "min" argument. Thus, when the default was applied, it looked like the default was smaller than the allowed min. swap argument postions to correct. Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_attr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index 797bb42a6306..8938c867ed2c 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -5174,7 +5174,7 @@ LPFC_ATTR(delay_discovery, 0, 0, 1, * this parameter will be limited to 128 if BlockGuard is enabled under SLI4 * and will be limited to 512 if BlockGuard is enabled under SLI3. */ -LPFC_ATTR_R(sg_seg_cnt, LPFC_MIN_SG_SEG_CNT, LPFC_DEFAULT_SG_SEG_CNT, +LPFC_ATTR_R(sg_seg_cnt, LPFC_DEFAULT_SG_SEG_CNT, LPFC_MIN_SG_SEG_CNT, LPFC_MAX_SG_SEG_CNT, "Max Scatter Gather Segment Count"); /*