From patchwork Wed Dec 20 06:56:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10125111 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CC2606057F for ; Wed, 20 Dec 2017 06:58:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C49D829649 for ; Wed, 20 Dec 2017 06:58:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B97CA2964F; Wed, 20 Dec 2017 06:58:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 547022964E for ; Wed, 20 Dec 2017 06:58:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932540AbdLTG56 (ORCPT ); Wed, 20 Dec 2017 01:57:58 -0500 Received: from mail-sn1nam01on0078.outbound.protection.outlook.com ([104.47.32.78]:54675 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932433AbdLTG5e (ORCPT ); Wed, 20 Dec 2017 01:57:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4oQA02WJU/Xad/waHDC12ordcqyN3VCo+gwes/dmRWk=; b=SP8pGDhpzMBzcIc7Fqky6akKkBVuq0LXEvlzJFMNGQF1cXoRWUK1xD+zcrrcLtmNBmPI6fYiwEcn/KZW87RHQtQDWVwDzJS7UcJV36VHe7eRtzOClOcTmKiC6VWTGUwAvMCfB2Mfo+dR6oOPM3k61g9tAkN6ngQcSRvGy1eemAo= Received: from DM5PR07CA0028.namprd07.prod.outlook.com (2603:10b6:3:16::14) by SN4PR0701MB3824.namprd07.prod.outlook.com (2603:10b6:803:4f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.323.15; Wed, 20 Dec 2017 06:57:16 +0000 Received: from BN1AFFO11FD026.protection.gbl (2a01:111:f400:7c10::165) by DM5PR07CA0028.outlook.office365.com (2603:10b6:3:16::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.345.14 via Frontend Transport; Wed, 20 Dec 2017 06:57:16 +0000 Authentication-Results: spf=permerror (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: PermError (protection.outlook.com: domain of cavium.com used an invalid SPF mechanism) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1AFFO11FD026.mail.protection.outlook.com (10.58.52.86) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.302.6 via Frontend Transport; Wed, 20 Dec 2017 06:57:03 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Tue, 19 Dec 2017 22:56:50 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id vBK6uo9g021650; Tue, 19 Dec 2017 22:56:50 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id vBK6uoCS021649; Tue, 19 Dec 2017 22:56:50 -0800 From: Himanshu Madhani To: , CC: , Subject: [PATCH 26/43] qla2xxx: Fix login state machine freeze Date: Tue, 19 Dec 2017 22:56:27 -0800 Message-ID: <20171220065644.21511-27-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20171220065644.21511-1-himanshu.madhani@cavium.com> References: <20171220065644.21511-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(346002)(376002)(39380400002)(396003)(2980300002)(448002)(189003)(199004)(2906002)(478600001)(8936002)(356003)(106466001)(51416003)(81166006)(72206003)(76176011)(50226002)(48376002)(85326001)(4326008)(305945005)(87636003)(47776003)(1076002)(2950100002)(69596002)(81156014)(6666003)(5660300001)(50466002)(42186006)(8676002)(80596001)(36756003)(16586007)(86362001)(110136005)(54906003)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN4PR0701MB3824; H:CAEXCH02.caveonetworks.com; FPR:; SPF:PermError; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD026; 1:0gZA9YFU14ws/7OnMddFAcB6x+dIIXzdcA9LpX1j+YvPNUN3bCeiqbwk7vxQDwAapFp0XaOvaJ+5zKnOy/oi/kEESrVr+WYfKVTfxROwIe9tvwjrNwxTpTO8x+lx5PrN X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1c320705-f050-484e-8f90-08d54776e05f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060); SRVR:SN4PR0701MB3824; X-Microsoft-Exchange-Diagnostics: 1; SN4PR0701MB3824; 3:rB6daWa8NrETeFSXR0cZtcO4kSLvWE3/17kekMNPEmtrxJrhWan3Cniyu2RKCPUjSCe43k0MmIfXVe7giKDemIJGsPqDblXveDrL89VPUPlju/NS2jqPmYfxF3pKCargsKe3qCkKZWYoLEnGcxQIK7GcGh1RGfmabzKRVl9Dr6UmPA9lkYuIpRmHiN3GNYhLW0WvaHwa/Vof1CWlbMSRO92jLlsOR5D5xstvoR9cNjflFWHmQEc9PptKJZ6lw1zjjnDqC5a5Y9x1z1QPOG/rfpAueX6jVxG9x/okz49O+mZXeK1KjRb9iFIIJduVJiwclvunO1wUj71cPWWiNVSd3khfIYTHB+tX5lJ/kXKCyls=; 25:EuENHFvCMVotMRtHn2Zf+FUdmHW2uWtQCtc1z8W7weWJsUI3JQdzCkjWbO+Qf5Y5gaehXjeovQSKaZ2oEtWh0JfHwLgbU6FZy58SfxZaZBrJBuGTJj1uX5Kar4Xv6h3hcS9/F4ZWuGm3UaP9MqDNcAGAH5C1ZekrM+Ip9h4Kk269ihKqrhYkRgSqrd0aMrfHtuk31MLL+tGp+7E7cQnfrO3ptMisdjTuwt+81v549d4W60lQ0q+EuhZeLGAFaFqKzbue6MQV5grlkKqBkIQAaj/a1QxB5/f5AwjuhpjO5A/vhI0kS8I72gy3Fackid6fBGNw1z6pX1KkUBHFL1P7nw== X-MS-TrafficTypeDiagnostic: SN4PR0701MB3824: X-Microsoft-Exchange-Diagnostics: 1; SN4PR0701MB3824; 31:VUASxlBPTe7RfBRQ6wOEPPiBFPrI7W2AzfPqKAaHVIrAyh6wObiWoCvP6yAdxEJKtpcXeOoIQwi6FJvSl4aiotM7notICEMhxjsK3Uh20o5KpG90bpsveB1fbCGzg8CuSJjZ6qCQ/7o76AU78qdu9BzMKKPB6T0zq3Mhg5+OLOHDdO2G3iv1/gkv8nqE1kSCQZedgFSnqDy3/JptJmTlQmSRUnMgU7rNbCL0hsW8b24=; 20:GnUxjRLjBFZ+SoYLQ09Jpc0X1PfCoQtPWjIlbkC6xGa1X+53RjMuXa+/VmFLlH3alOP8Xb8QEFMrmpkW42YwAVP4re9yh1hdJjrIWJsEW5c7xuf/5GIkxIshct9/1BItxZCLTICA435hSjzkEmnqJo1RG0wTD7GFbObFV9seJLba4CVPHmVcs+gXrjGTSBRB/+5/FKY+X+gKd3rxClgwmG0WGJgFITnVrat7+fBRrHkf14rQg1/+eRt91Txdrmtnoa0+ZbFvPWyZNw4xPq3rI09+LaLOGFtIRd3m9EiPZvNjAVUq00txYXs7EJE/dGzImKYeel9ZH8IAZeNwiAnYg5SSU5nX4NDXxqKyE12eAmk2ssC5UiEq4eEylvyZprSJmYxBfYwWCMj7KwyMhwJnhOT9Njsfo89RZjRq3ROsMkMNdsHRU6NwFqKqy1z40ioBL8as0SO/0Az5VMJcYqey/y71EaYUYzEPV+/09PK1HFwoCPdDMV0aRUOTnMwnfZsG X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231023)(93006095)(93001095)(6041268)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:SN4PR0701MB3824; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:SN4PR0701MB3824; X-Microsoft-Exchange-Diagnostics: 1; SN4PR0701MB3824; 4:SY1r8RhtKwSaf7x/izcB1uUr5cucoRKmDZW/cREyw7FZJXyIbcJD0iiiDnXmvfUHtbksQOdq0EsQIaKbrkItiTb7BFI4srJLnLq+peC8yL4vX48z1SnB0yFXT09US+JBTeuNtshjyMYZsz6X7paL1kW1sboH8HlegxU1z8ht4tfx/Wi628u2wmdd4U683jrge879lv9rPaxkbCWBoiKIkWBOIH/7RDfcP3OWwyNk+2OYz84KzlrtxyBT0Ks8gA8RJ+SiiKLz2tyWxC7G1BopSQ== X-Forefront-PRVS: 0527DFA348 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN4PR0701MB3824; 23:dEbXxbnBpwIoJVToziO2RiGjQDc+CAzqXU7FsSx?= =?us-ascii?Q?RXwLuBUsyQOC7J5chtBLS6Gbxh5eQ/vDf8NKFeL2/07iHdSPOoiCmrgNLSs3?= =?us-ascii?Q?0hYNXMZ2nnSO5QoaWREP5kDgx+bl9q6l61YEpdkueOvyizdP4ZUm6FbWS/TE?= =?us-ascii?Q?fEN6u2nDqa8Et91mwhCqAEBbaqDQuM7D/Uro0CAcqI4fYPE5tQ6HFlqmdQ/X?= =?us-ascii?Q?E3QYLVlCeWt6RxFIPVCgobUAbkQKcFESG9NauOlHC1HsWL7sIC6Q/yfCQzia?= =?us-ascii?Q?Rhr3ZO02tD/lKZOmcb1UNp3x5Qv7DWi+i4weTV/zKLUhiPjNQmoVnRrZmqqE?= =?us-ascii?Q?ElaJ9GWsKb0CNPyoRqDS0Z9P8t+ytrT6SAd75A8jmGO8kmFfOD48OB6xAO8G?= =?us-ascii?Q?DAn8lW7cAYLTUN44Cx2KbDV8FjLGDuzhurphb9iSDYMutvf1uCBVw3lhpuDO?= =?us-ascii?Q?yaPhmLWn0pr3k2V/FxiJw1aKT2wJXzKyOJjvB1AhsTnKC8YKBEEM40PyE5m2?= =?us-ascii?Q?0jMqIONXJdtlaDXJ7w4H+WpFDXWbRg07GO2AL3fPlb1vPLZUR6b/j/Ezy5dL?= =?us-ascii?Q?PFp/2J4Wy1zSWlZ56gULcc/0jAOvXZqI61NbE3WpqXp41zqkzawBUw90825e?= =?us-ascii?Q?uf+59S2qCk57jz8csv3Hd92SW6yk5OWIxvJ22K5yasz2OOVe/V9w//CYWnyq?= =?us-ascii?Q?CtfMGHnQkfM3Jw+oWF6bYGfifK3SeanvOCyHP/OV5RAUlVTVNS9maLX1BOa1?= =?us-ascii?Q?9eqtdZjhWtb8bL00ZFzBoTn7LuNgBYFWd1f9IaNrch9mAI6Y3zZeCWcaeANH?= =?us-ascii?Q?/DbmH5s3CxawOpIoyhVxNTq+NbVPWs0WQfdjztrAcQwbxCffuLj4Cgtq2UHx?= =?us-ascii?Q?El8PC/rzPYYMc3Z/IxxGoX/OEo9TsOltRcjq4r3KGugp7VpriHTs1hnQ6vMI?= =?us-ascii?Q?/9e17jzzcb8ja5sN0L96o6NKJ7GYCKLT4NnlvkYENlv8yMmfd23OEEjbdBf/?= =?us-ascii?Q?A45c=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN4PR0701MB3824; 6:xsCsoUKy9y9e1SeX/ixp+CJUQTb7FYJrcRuQMqOEkCqVKDChpXbVW3oq+EBkSj12WT9i6ESWtrG5xgGJ/8+YcWjNc2oSNtK5gCUC6wdr82bGgTkz+LAf9xoCfDg1WA7TJQGWXIIF3fKYqvQOZBB1+i6s3IQBMXy4O7UPmm9JwtEKHZSSssE+TUiAPznhajQkJYb9jCtNZDegcEYeRSiIFKmqlWgQECXh7rPRN39WLxmb7P/HFbNwfLuczS/l0Ir6mTIY4ktslleyG0plb9JDKSWhpw5aF14NBFB1dkKHboxOyrJSGEAYVhvb50jCaY8z0m+L3ElIEcTxuz79Y1KFmT6E2zldtb0BgxPNu52SLMI=; 5:ehu6uT/Lm2wqv48gEz/yH8rV55poxNOVK46832G1q//rqJUCSmxL6DsThrHzBr8Cs9nIfYJLkNITd8V18XBH86rMLinYQEhHZVcQMGKctQrhurd8t4bD/NWajc7WdLRjHeO3yaQoe9ZJWjO+dN+KVmmkO6DIGJX9nz7AfuwUFSk=; 24:fcClXk6ygqNpfE+GVdgDu2Rd2sfyeoVXowd76zR0HJCF7m3/9byv5QbYaWQ27wE6JL3C4C6vkxm4gNBWzIPo9EPQ1YLVX2gut1WIL2JeHDc=; 7:Cz5M2IU1s+pF9+1XfPRttl/EoJMluVttNKZgkcd8lT4947Lnl/+FM7hPNfRQqBGpFxadSz8d8lt3W0WCvVNYogEQJyOHVQVozgZDTMZnj9sZ3Sosc3R59P0CBZh/Tm5kGizK/qyxH7jLrBt2WICaVP2c6SOznG9e+5xx7UhUvAZML3/DK531hHtwCynW9hQ3yNz4ejBRZEJPqcSW+INfloN/wOfu2+ti9w1zp542Olo7GL9SxMkkxM9Sxik8/hiL SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2017 06:57:03.5589 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1c320705-f050-484e-8f90-08d54776e05f X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0701MB3824 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran Relogin stop moving forward due to improper check of scan_state flag. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 300cd795dad4..152c808b272b 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -1270,11 +1270,6 @@ void qla24xx_handle_relogin_event(scsi_qla_host_t *vha, { fc_port_t *fcport = ea->fcport; - if (fcport->scan_state != QLA_FCPORT_FOUND) { - fcport->login_retry++; - return; - } - ql_dbg(ql_dbg_disc, vha, 0x2102, "%s %8phC DS %d LS %d P %d del %d cnfl %p rscn %d|%d login %d|%d fl %x\n", __func__, fcport->port_name, fcport->disc_state, @@ -1324,7 +1319,6 @@ void qla2x00_fcport_event_handler(scsi_qla_host_t *vha, struct event_arg *ea) int rc; switch (ea->event) { - case FCME_RELOGIN: case FCME_RSCN: case FCME_GIDPN_DONE: case FCME_GPSC_DONE: