From patchwork Wed Jan 24 22:45:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Smart X-Patchwork-Id: 10183211 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E23C360233 for ; Wed, 24 Jan 2018 22:46:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C98602861D for ; Wed, 24 Jan 2018 22:46:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BE70D28794; Wed, 24 Jan 2018 22:46:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5BA292861D for ; Wed, 24 Jan 2018 22:46:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933133AbeAXWqT (ORCPT ); Wed, 24 Jan 2018 17:46:19 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:40589 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932800AbeAXWqN (ORCPT ); Wed, 24 Jan 2018 17:46:13 -0500 Received: by mail-qt0-f195.google.com with SMTP id s39so14655158qth.7 for ; Wed, 24 Jan 2018 14:46:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=itrIHQ5Zq47Xed6IX0R1cG7mFfF8j0YM7DpF3C1RrfQ=; b=BcZWdffd5pPh4O3CjOGF7MXtKcdMpJYc98PlQE6xIDyGu7XgCR2V4g61uTz+Mvfnzp yqETYRXd6wYnBPf+qfbizIlYWAS6ZJ9OKosRPxIGpb9BY/s5Qci8q2W1GsPv+TwF7egw Ee+DfMGEPQjKg3+boIq7XOHDOTaDP9xE4ymeKsXyiASTyizR71GLc0h4DlVKUDmWl6FV HgOs2ZWoKzMdGKsAflobkHdcEYrwk41kUl5pgsHwK0Rp5GB53ID2zD/ddA5bRB4/ubQR gOIH9RoqN+fUkee17Z4Qj2jmS0i1RdYM2SfJhHD5pa69MmMNjrq1TxyWPTZ8xkncrVAW 29yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=itrIHQ5Zq47Xed6IX0R1cG7mFfF8j0YM7DpF3C1RrfQ=; b=ptZw6Xvo5pL4o0apOCnVncaYFe+kNM+eiNHQpoJvCg7L9HixXW+Zw5FNfPsZEL0wvT bTBLXB44+NZnAggKdNMwCvLQxZVOPY3byEPpPV+N/KuqLU6ubLZqNfGK32ezJHQeRDYR cM8uL8iLqa/sLwueDQbpbIwa2kZU0aaa0G5e9Y0Z7RGmn7VoyMCEkfmnQeW1gVw5pTDn tpud4I1LyrzTxDhUh1hmKzcq9CPqMCoDFRYGuk8dfXXTHk5/tRhyLZ/jQggCxKK0SE0K f/qA7jexNKoxslqmfIU5R/W+9+mZDv3p1nGDQjPrXBegEM3p3VKG84YPHoCsTLc/JMzB G0iQ== X-Gm-Message-State: AKwxytf7Bms7rxEdY2QnaIuN5Fpbeknpfo1pyK+C6QfQ1yg/xmRYdM9H P+mDdlBtXZjHVlI+E6S0NTHZSg== X-Google-Smtp-Source: AH8x226oqIjwBrrNv8j2dNrDVSmOhKTGysMY+8JcoH0Uz2DiEYzl3MOBhoSVsZIKaRg0448gdiCTLQ== X-Received: by 10.200.51.139 with SMTP id c11mr12404225qtb.90.1516833972651; Wed, 24 Jan 2018 14:46:12 -0800 (PST) Received: from pallmd1.broadcom.com ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id e5sm977713qkj.87.2018.01.24.14.46.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 24 Jan 2018 14:46:12 -0800 (PST) From: James Smart To: linux-scsi@vger.kernel.org Cc: James Smart , Dick Kennedy , James Smart Subject: [PATCH 11/19] lpfc: Fix issue_lip if link is disabled Date: Wed, 24 Jan 2018 14:45:40 -0800 Message-Id: <20180124224548.9530-12-jsmart2021@gmail.com> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20180124224548.9530-1-jsmart2021@gmail.com> References: <20180124224548.9530-1-jsmart2021@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver ignored checks on whether the link should be kept administratively down after a link bounce. Correct the checks. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Hannes Reinecke --- drivers/scsi/lpfc/lpfc_attr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index d8064e3ea0ba..b79dad7b8278 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -911,7 +911,12 @@ lpfc_issue_lip(struct Scsi_Host *shost) LPFC_MBOXQ_t *pmboxq; int mbxstatus = MBXERR_ERROR; + /* + * If the link is offline, disabled or BLOCK_MGMT_IO + * it doesn't make any sense to allow issue_lip + */ if ((vport->fc_flag & FC_OFFLINE_MODE) || + (phba->hba_flag & LINK_DISABLED) || (phba->sli.sli_flag & LPFC_BLOCK_MGMT_IO)) return -EPERM;