From patchwork Fri Jan 26 19:22:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Smart X-Patchwork-Id: 10186921 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BDA29601D5 for ; Fri, 26 Jan 2018 19:23:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AFEA628C2A for ; Fri, 26 Jan 2018 19:23:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A481929DC6; Fri, 26 Jan 2018 19:23:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 581BF28C2A for ; Fri, 26 Jan 2018 19:23:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752925AbeAZTXN (ORCPT ); Fri, 26 Jan 2018 14:23:13 -0500 Received: from mail-qt0-f194.google.com ([209.85.216.194]:33319 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752656AbeAZTXH (ORCPT ); Fri, 26 Jan 2018 14:23:07 -0500 Received: by mail-qt0-f194.google.com with SMTP id d8so4001699qtm.0 for ; Fri, 26 Jan 2018 11:23:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=itrIHQ5Zq47Xed6IX0R1cG7mFfF8j0YM7DpF3C1RrfQ=; b=qm9DjZVQ21OO0QfS9buVdsZxbhp9/w93GxMy7CDFBDmMhIQYmcGPb9wUYotKmLwQR/ GM1v0pwEy9ofj+cAyf24WYJz3jEfbEqql+utGLR2D5nlTFtKhKyQbr5FPnmqYfkbZ0kV HjpS0fAOFZzOBofePsz5uUH46Y6+mbWQbZ6wk80E2TZRhHw5cAYfXKIPiIiP5uhrHJS8 w6N9uRkcY556ockR+L+3ShZIBNBxcpknRi/C9JWaLX+BUe2dUUep+SAO3McNxo4/1bkN 19iwNp+zSvmWF2VjTzipfM8xuHaHEn1y5LWD/BB9+tR13jCpFAykrdNZplofKL0Zb4S4 DM+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=itrIHQ5Zq47Xed6IX0R1cG7mFfF8j0YM7DpF3C1RrfQ=; b=D66L5wQrj3Tp6AIsA3d7Vj0Wm5UkeXLgXlzdhd/MY+c/wESM8jXPagxLsS898Ropah p86GKei8gDJ46TJfVIobMogcNCYtOJrJHi8kS4lWRmOoO9fNjvCo0dO52mDhm8ZCvDbh SxoYMvUTTraiWZ5nFaVG6CsVueSr0+cboBnng2AChAh1vlo6EQXCWtHGqvYofh+Rubjh Jn0zEZVDjLHuy/qhljLsRWrNV6kVLg4tZyJmshyRxVvmyTEPwvbo7hL+R4lBQpizVnrZ T3LxQY3RFumbm80dz6by7s+z9GZNyZ5aj4pY1YY2vI91Y4NKOOg5xbmgPyXM/9Vwuf0a T4yQ== X-Gm-Message-State: AKwxytfo2Z20k0/rdtnvxiunkFNCnyD/TNafhiD7fvKMSG2idFIzdwrN tKDOJ6ZXyDsJ4zvkMeJjKkTtMQ== X-Google-Smtp-Source: AH8x225O/5GRZca9HyN9YRGHKqXjJBcVq7jFdsMGTnIzDvZ0BjCD9NlibhvxIZeWwqOTVzIS78xcKg== X-Received: by 10.200.26.130 with SMTP id x2mr26513495qtj.288.1516994586294; Fri, 26 Jan 2018 11:23:06 -0800 (PST) Received: from pallmd1.broadcom.com ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id f129sm3811300qke.82.2018.01.26.11.23.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 26 Jan 2018 11:23:05 -0800 (PST) From: James Smart To: linux-scsi@vger.kernel.org Cc: James Smart , Dick Kennedy , James Smart Subject: [PATCH v2 11/19] lpfc: Fix issue_lip if link is disabled Date: Fri, 26 Jan 2018 11:22:31 -0800 Message-Id: <20180126192239.10727-12-jsmart2021@gmail.com> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20180126192239.10727-1-jsmart2021@gmail.com> References: <20180126192239.10727-1-jsmart2021@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver ignored checks on whether the link should be kept administratively down after a link bounce. Correct the checks. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index d8064e3ea0ba..b79dad7b8278 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -911,7 +911,12 @@ lpfc_issue_lip(struct Scsi_Host *shost) LPFC_MBOXQ_t *pmboxq; int mbxstatus = MBXERR_ERROR; + /* + * If the link is offline, disabled or BLOCK_MGMT_IO + * it doesn't make any sense to allow issue_lip + */ if ((vport->fc_flag & FC_OFFLINE_MODE) || + (phba->hba_flag & LINK_DISABLED) || (phba->sli.sli_flag & LPFC_BLOCK_MGMT_IO)) return -EPERM;