From patchwork Fri Jan 26 19:22:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Smart X-Patchwork-Id: 10186929 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A48DC601D5 for ; Fri, 26 Jan 2018 19:23:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 967B128C2A for ; Fri, 26 Jan 2018 19:23:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8B5AC29DDC; Fri, 26 Jan 2018 19:23:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2EA3128C2A for ; Fri, 26 Jan 2018 19:23:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753009AbeAZTX0 (ORCPT ); Fri, 26 Jan 2018 14:23:26 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:38289 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752920AbeAZTXM (ORCPT ); Fri, 26 Jan 2018 14:23:12 -0500 Received: by mail-qt0-f193.google.com with SMTP id z10so3977387qti.5 for ; Fri, 26 Jan 2018 11:23:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=apUC6GobWfRtwPEF9avAkDYGdjxM7EqMfV2NUFvFBvE=; b=cCoenXPaqU8pVesnPawiFmczfzjKfmvrN4u29uYgkwNMNv83XCNJXD7Se66uVAcYi5 a44+9r9VMIsk+kQ0dRB32/7OwnsNhZnxPHqrAkAannjZ/b8vYnIumlidGUP9ccIUZSH0 7p7ii0wltXj5ByTJNYqFpbJFRExsjjHKK7IYt/kuQZhiBpHf+XoBBEDZztuGtkP0rpvV BQnm0Ikcio/7weiV2iobt7hCdFp2b9aeSKdo69S2BeYyHxbrBVtYKvus/kmvht0trlEU AFlyh+TGq4tTsBKhWspZctkw8jOvpej1i5n5ZTWqhH50rwXft7lCpkMhSQYJB+GIglpR 7RjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=apUC6GobWfRtwPEF9avAkDYGdjxM7EqMfV2NUFvFBvE=; b=VSjVLo0Zh3uG4nZt2CNqWCtwWnhMR1qbJC1EnbqvAZ4h2nix/RyLsfQNumHx7sFbls TSEKLAEgKkp46MG7pzGlCftgz6SKVrlhIkico/tohzNQRy5gsqpheLeZnJ+LkxUrgueH oxdIL5Mo0sUHxKAGvgxc/U3SgL+cXei3GhHYay1RN7xV4FgYiuHR45s1NddPIo1Mxnp/ dSodbTaXm+SdG7tVT052DHFXQz/W2Yetk4M2L6a4mgvaZnzEY2RXxfc4zFa2/Y8mczwF wNWmGzvRZi1J/v9dH8uuDN0mhQiSl0nFNbezvXarOKa9BhmYwiXq4YAskSpZHzq8DpTe elHg== X-Gm-Message-State: AKwxytfX3EasLpwrQdYLrImqArxbYIWY3WG+ffAhr5eDoYMnm/YVLbMg SCrdV7U7J5NcTD9xNopzko7UTQ== X-Google-Smtp-Source: AH8x227Y8KBlsQ2lAB9QBM3YAlRBwuSnhlfApf+RUPzgpLNbo8FLgLL8KvIBV7Rrz4Gts/bJ2uxiww== X-Received: by 10.55.21.140 with SMTP id 12mr22629475qkv.74.1516994591361; Fri, 26 Jan 2018 11:23:11 -0800 (PST) Received: from pallmd1.broadcom.com ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id f129sm3811300qke.82.2018.01.26.11.23.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 26 Jan 2018 11:23:11 -0800 (PST) From: James Smart To: linux-scsi@vger.kernel.org Cc: James Smart , Dick Kennedy , James Smart Subject: [PATCH v2 16/19] lpfc: Treat SCSI Write operation Underruns as an error Date: Fri, 26 Jan 2018 11:22:36 -0800 Message-Id: <20180126192239.10727-17-jsmart2021@gmail.com> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20180126192239.10727-1-jsmart2021@gmail.com> References: <20180126192239.10727-1-jsmart2021@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently, write underruns (mismatch of amount transferred vs scsi status and its residual) detected by the adapter are not being flagged as an error. Its expected the target controls the data transfer and would appropriately set the RSP values. Only read underruns are treated as errors. Revise the SCSI error handling to treat write underruns as an error as well. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index dcc86936e6fc..10c2dc0cf1fa 100644 --- a/drivers/scsi/lpfc/lpfc_scsi.c +++ b/drivers/scsi/lpfc/lpfc_scsi.c @@ -3772,20 +3772,18 @@ lpfc_handle_fcp_err(struct lpfc_vport *vport, struct lpfc_scsi_buf *lpfc_cmd, scsi_set_resid(cmnd, be32_to_cpu(fcprsp->rspResId)); lpfc_printf_vlog(vport, KERN_INFO, LOG_FCP_UNDER, - "9025 FCP Read Underrun, expected %d, " + "9025 FCP Underrun, expected %d, " "residual %d Data: x%x x%x x%x\n", fcpDl, scsi_get_resid(cmnd), fcpi_parm, cmnd->cmnd[0], cmnd->underflow); /* - * If there is an under run check if under run reported by + * If there is an under run, check if under run reported by * storage array is same as the under run reported by HBA. * If this is not same, there is a dropped frame. */ - if ((cmnd->sc_data_direction == DMA_FROM_DEVICE) && - fcpi_parm && - (scsi_get_resid(cmnd) != fcpi_parm)) { + if (fcpi_parm && (scsi_get_resid(cmnd) != fcpi_parm)) { lpfc_printf_vlog(vport, KERN_WARNING, LOG_FCP | LOG_FCP_ERROR, "9026 FCP Read Check Error "