From patchwork Tue Jan 30 23:58:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Smart X-Patchwork-Id: 10192929 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5B21760291 for ; Tue, 30 Jan 2018 23:59:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4D8A127F54 for ; Tue, 30 Jan 2018 23:59:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4228B27FAC; Tue, 30 Jan 2018 23:59:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D907427F54 for ; Tue, 30 Jan 2018 23:59:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754170AbeA3X73 (ORCPT ); Tue, 30 Jan 2018 18:59:29 -0500 Received: from mail-qt0-f194.google.com ([209.85.216.194]:33805 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754167AbeA3X71 (ORCPT ); Tue, 30 Jan 2018 18:59:27 -0500 Received: by mail-qt0-f194.google.com with SMTP id a27so19682042qtd.1 for ; Tue, 30 Jan 2018 15:59:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ARpUQlAFKxXQHNBqdnMlscdqtNmBmdAyX87QVpN98h4=; b=KsZq7RsavUUZUvx4OyAUc57sslg/JX+rTVpoar24LBW2H5Napg9R215VR89rLCPgtp 7bRf0WEv3KMKYKDbR3LGQK237xpY8gHq5Zs+4SFYzikDnm/7p0VgmRwezZqZ1WMTfhjS yAxTcM0C73DgCH0dnrWIHXgLd6S+14gP6rPvwwEmhN62qTj9vsBjFODSeohqgnyqAVBt 2Tkl3fqFrAHts6I5SDlApzxhZwy/AavmuwkYnvrH0HKetz0KrSkueXXKuSS6eA1Eo2ge AYQ7AfWQkdylWPye84XuG1WUM0qEP8F442YEiyAZMn2KsPWEoiXcbnmKMCVvJFNg+UiB uxYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ARpUQlAFKxXQHNBqdnMlscdqtNmBmdAyX87QVpN98h4=; b=uH8t/c16FXMWD+ZenybYyAgWg4Le+Su5RtzRBB/cMzP+I9kzPpr/FAUW9I0VbRmUGK qE4SloieHvLx3I977MT+0+IZb9ecW2JzrLyZqFS5pCkyPY7gKhJq37saD3LteklQPrUn LcBgPxIUMVT0N4AG8j1FCiR9iZiSrwbDM3r4aLB3ZG7R0DzkrllHvoCWM7D2S1iVUXix nG/DaSxcR4T3x1TxbDVmB1gTTl7XdZkyN3WVfC4gy0HSetaVA2GOx19Rwj/ilMOLeiXJ 0nLkhRgvSyOQxnJpNJIYTBFoPokhegZZ33G4oZ2mwAkswJl2Hs+uXFOLf/kkqGYZA+6F mNNg== X-Gm-Message-State: AKwxytdLOPkEhdnaaTJu6AIUaStpx05nZc4MNoBAjGoapF5LRQ3R3Eu+ pLZHGPr0vW6w3T0NOV3yNyr3Qw== X-Google-Smtp-Source: AH8x226ReIE6fOe45BUU0FvNnT3SWE5xE3WDus2JaOkvJp3/8N7EFnpRtfCgoR7EKh3jeKldJsQ7gw== X-Received: by 10.200.12.78 with SMTP id l14mr15826784qti.291.1517356766830; Tue, 30 Jan 2018 15:59:26 -0800 (PST) Received: from pallmd1.broadcom.com ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id i39sm12438537qte.19.2018.01.30.15.59.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 30 Jan 2018 15:59:26 -0800 (PST) From: James Smart To: linux-scsi@vger.kernel.org Cc: James Smart , Dick Kennedy , James Smart Subject: [PATCH v3 11/19] lpfc: Fix issue_lip if link is disabled Date: Tue, 30 Jan 2018 15:58:55 -0800 Message-Id: <20180130235903.5316-12-jsmart2021@gmail.com> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20180130235903.5316-1-jsmart2021@gmail.com> References: <20180130235903.5316-1-jsmart2021@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver ignored checks on whether the link should be kept administratively down after a link bounce. Correct the checks. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Hannes Reinecke --- drivers/scsi/lpfc/lpfc_attr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index d8064e3ea0ba..b79dad7b8278 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -911,7 +911,12 @@ lpfc_issue_lip(struct Scsi_Host *shost) LPFC_MBOXQ_t *pmboxq; int mbxstatus = MBXERR_ERROR; + /* + * If the link is offline, disabled or BLOCK_MGMT_IO + * it doesn't make any sense to allow issue_lip + */ if ((vport->fc_flag & FC_OFFLINE_MODE) || + (phba->hba_flag & LINK_DISABLED) || (phba->sli.sli_flag & LPFC_BLOCK_MGMT_IO)) return -EPERM;