From patchwork Tue Jan 30 23:58:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Smart X-Patchwork-Id: 10192915 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9381B60291 for ; Tue, 30 Jan 2018 23:59:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 870C227F54 for ; Tue, 30 Jan 2018 23:59:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7BFFF27FAC; Tue, 30 Jan 2018 23:59:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 240C727F54 for ; Tue, 30 Jan 2018 23:59:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754160AbeA3X7W (ORCPT ); Tue, 30 Jan 2018 18:59:22 -0500 Received: from mail-qk0-f194.google.com ([209.85.220.194]:43573 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753556AbeA3X7U (ORCPT ); Tue, 30 Jan 2018 18:59:20 -0500 Received: by mail-qk0-f194.google.com with SMTP id a5so12537322qkg.10 for ; Tue, 30 Jan 2018 15:59:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TSFZrTZeq7BIcbMz/rjP80gX4qohSY0ZF/RgcDipIAo=; b=Yt1SQgkD6Vym5JeRvh7gSrLfwDcpkKwO9BAPmk/NIdQsPVDVdHzX8mgQq1DkGHmL3k iCg14dIBx343ahVZDI9cV5Ar9X6Qxbz/a689FbBhs6ppzKAyKNI+mTp/Ma7wgdUYm8v1 X783c8YVJ6uiBwywlgag8UPqf2gAE+ZRXx7jMOdyPqwRXncHclxEasGmDkTG96si3j9k GFjWFwdcU9ovKXPmndPZ1fSWdyYyuv5+o6LKOKmPBa+TJWyXyC9Dw7+FZJLWnNsiGS4b y3q3be+Zijqu3y8Tup3Z+hfAdfDr18H6drmHLoXwb/mqrWGADSlsuVCKHe59VczH3gwi 3/2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TSFZrTZeq7BIcbMz/rjP80gX4qohSY0ZF/RgcDipIAo=; b=izOP5RiZR4MBj672MZW5BrHZU7F6Nxa74zanITTPqZlc/yiiK/f3fslKXfduDyekft SKX6deDNmwrBNBIeOg2eqqTr4pvzCkdore00W3HJBT+l9lyZkmrT7dxUtnKYFd6DLbMs YzA4Uoe6oow/L9TggBDMKaxgdwiFa3yONLgebLdCzlFvLtCwp8w2/XVl6lLDB8VY4IMj pvztnjS4Iavky3SyHAU+MBZiPExck8VVnfdRQZg+SawjDdBTXE0hchOYRIDwPF/pKgad KXzw8zORu8ds71rzTEyqjgpwDUfCKiIJLiOkHqeNlOOSASm2EDFlI54detc9tYviimep qhAA== X-Gm-Message-State: AKwxytefbFsbZTy3BSr4o6OrlTddibVFl67gaiS+rx9iMlyqE2jcv+L1 DveCUlhlDriM+4Nf6jL5Mbckxw== X-Google-Smtp-Source: AH8x225fzFQPqfwfI/BUMCIhRoiGYJ4oPuydqaj/KlBVwlZTMmkSPt8XmEYoAWzfQQUuQSVqIVOmZA== X-Received: by 10.55.106.193 with SMTP id f184mr31341258qkc.211.1517356759275; Tue, 30 Jan 2018 15:59:19 -0800 (PST) Received: from pallmd1.broadcom.com ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id i39sm12438537qte.19.2018.01.30.15.59.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 30 Jan 2018 15:59:18 -0800 (PST) From: James Smart To: linux-scsi@vger.kernel.org Cc: James Smart , Dick Kennedy , James Smart Subject: [PATCH v3 04/19] lpfc: correct debug counters for abort Date: Tue, 30 Jan 2018 15:58:48 -0800 Message-Id: <20180130235903.5316-5-jsmart2021@gmail.com> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20180130235903.5316-1-jsmart2021@gmail.com> References: <20180130235903.5316-1-jsmart2021@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Existing code was using the wrong field for the completion status when comparing whether to increment abort statistics Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Hannes Reinecke --- drivers/scsi/lpfc/lpfc_nvmet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c index 8dbf5c9d51aa..7927ac46d345 100644 --- a/drivers/scsi/lpfc/lpfc_nvmet.c +++ b/drivers/scsi/lpfc/lpfc_nvmet.c @@ -130,7 +130,7 @@ lpfc_nvmet_xmt_ls_rsp_cmp(struct lpfc_hba *phba, struct lpfc_iocbq *cmdwqe, if (tgtp) { if (status) { atomic_inc(&tgtp->xmt_ls_rsp_error); - if (status == IOERR_ABORT_REQUESTED) + if (result == IOERR_ABORT_REQUESTED) atomic_inc(&tgtp->xmt_ls_rsp_aborted); if (bf_get(lpfc_wcqe_c_xb, wcqe)) atomic_inc(&tgtp->xmt_ls_rsp_xb_set); @@ -541,7 +541,7 @@ lpfc_nvmet_xmt_fcp_op_cmp(struct lpfc_hba *phba, struct lpfc_iocbq *cmdwqe, rsp->transferred_length = 0; if (tgtp) { atomic_inc(&tgtp->xmt_fcp_rsp_error); - if (status == IOERR_ABORT_REQUESTED) + if (result == IOERR_ABORT_REQUESTED) atomic_inc(&tgtp->xmt_fcp_rsp_aborted); }