From patchwork Fri Feb 2 13:12:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10196669 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DD9736037D for ; Fri, 2 Feb 2018 13:19:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CEE7128E54 for ; Fri, 2 Feb 2018 13:19:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B274128E59; Fri, 2 Feb 2018 13:19:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4C3A128E54 for ; Fri, 2 Feb 2018 13:19:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751557AbeBBNTV (ORCPT ); Fri, 2 Feb 2018 08:19:21 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:62784 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416AbeBBNTU (ORCPT ); Fri, 2 Feb 2018 08:19:20 -0500 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue003 [212.227.15.129]) with ESMTPA (Nemesis) id 0MQs4Q-1eIknA2WfG-00ULgt; Fri, 02 Feb 2018 14:14:06 +0100 From: Arnd Bergmann To: linux-scsi@vger.kernel.org, "James E . J . Bottomley" , QLogic-Storage-Upstream@cavium.com, "Martin K. Petersen" Cc: Nicolas Pitre , Andi Kleen , Arnd Bergmann , Saurav Kashyap , "Dupuis, Chad" , Arun Easi , Nilesh Javali , linux-kernel@vger.kernel.org Subject: [PATCH 6/6] scsi: qedf: use correct strncpy() size Date: Fri, 2 Feb 2018 14:12:20 +0100 Message-Id: <20180202131225.1658853-7-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20180202131225.1658853-1-arnd@arndb.de> References: <20180202131225.1658853-1-arnd@arndb.de> X-Provags-ID: V03:K0:+08KeQYkcmg6YFv+BV2i7zTvTI63paVPXItNfcWmGRcY8V0r0nQ u87dufChhWViRUHUnpCcSgKbRZAo83uhIDSeq+ISur782Yp4dVQONU4yLcNVqYMlkkkvDdL /VmtB0twYi1o91at6DVRjHhHuYjJO4sIBg+6JlV0bBH3YAk/F5x28jWrP/0lfwp5UpgzBtx 7/j5pSE2Vl7IIA/ztapCw== X-UI-Out-Filterresults: notjunk:1; V01:K0:SQV6o8aQpmg=:aSUoySMBcSFw7S4d8Fn5S4 owrQKGQU1l6FagNPVob/wxdgz/yvOR5Rqpv06YTqT1wOULGkzLofIr8TFgl7jxnmYyWzGqqJE HPP4wA874zSnACKg9icOZAAERZyHHOGTloFbF5UGj6VElP9mb1KfzyizXBJSgPoxo0OHF+/h8 yJnp588nRYrLEXA6n96w/KpW8n5vVOJheccJFcaiSbK2jhBeuB2e/7eGkaejRkBtH57yyQ8Z6 4rFMP1egg9S84sab229lBOWFtqzyqizkt4AIDgfvClCIfsPLT0dZ6VL1l7ex7vKYKHSF5xr81 n1BJDaz1nrXdPyUkC4rvTkivSZGpcmxqTzcWDVQWRWakZRfuABivgYf10Tr2WcR3120tihC7y vkw0ElR7faQ/py6sW8eqXDwfP6rA7UYpYScCVoXyjMTd9D4B21mrdY4XW3+Aeucn6Oqor9pxV n+UNdBzmujGCUvg5En6xmhVRk26KspAt5HfxK5SyHPGL+YiwZ44wQUfRSb6p5rkZlHwc2XO/W WEAYCsvkoBOK6xOjkOQB7rHyOFTWZ2xDrH97svyHauPoERPiw76XR+HgsvNhk5UhzfS8QyYfu K2y77xYnCFTCc+NfgeE58qGkl7Fq1FLtIkfb75nONoAnbiTWE4oYzBF4GWGS5/Ur85tjXeEGx yrCVYh+v6ksuflD81UcD3UzBl6RFMUMMs2xGipI/SfH6mjisYIBbkNJyIoF4+bV5tBEDn2I3H u5/uLMWjRvEguAi2EZALhdZs4wmopo5yuuC/rA== Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP gcc-8 warns during link-time optimization that the strncpy() call passes the size of the source buffer rather than the destination: drivers/scsi/qedf/qedf_dbg.c: In function 'qedf_uevent_emit': include/linux/string.h:253: error: 'strncpy' specified bound depends on the length of the source argument [-Werror=stringop-overflow=] This changes it to strscpy() with the correct length, guaranteeing a properly nul-terminated string of the right size. Signed-off-by: Arnd Bergmann Acked-by: Chad Dupuis --- drivers/scsi/qedf/qedf_dbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_dbg.c b/drivers/scsi/qedf/qedf_dbg.c index e023f5d0dc12..bd1cef25a900 100644 --- a/drivers/scsi/qedf/qedf_dbg.c +++ b/drivers/scsi/qedf/qedf_dbg.c @@ -160,7 +160,7 @@ qedf_uevent_emit(struct Scsi_Host *shost, u32 code, char *msg) switch (code) { case QEDF_UEVENT_CODE_GRCDUMP: if (msg) - strncpy(event_string, msg, strlen(msg)); + strscpy(event_string, msg, sizeof(event_string)); else sprintf(event_string, "GRCDUMP=%u", shost->host_no); break;