From patchwork Sat Mar 10 01:06:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Smart X-Patchwork-Id: 10272895 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6CD786016D for ; Sat, 10 Mar 2018 01:06:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6560D29F9D for ; Sat, 10 Mar 2018 01:06:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 55D4629FEE; Sat, 10 Mar 2018 01:06:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C276129F9D for ; Sat, 10 Mar 2018 01:06:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751278AbeCJBGS (ORCPT ); Fri, 9 Mar 2018 20:06:18 -0500 Received: from mail-qk0-f194.google.com ([209.85.220.194]:40515 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbeCJBGR (ORCPT ); Fri, 9 Mar 2018 20:06:17 -0500 Received: by mail-qk0-f194.google.com with SMTP id o25so5632216qkl.7 for ; Fri, 09 Mar 2018 17:06:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=3paXl7DP9Pq0lFKPbk4H6K6Xb1lES0iem+O4Uo7l7xc=; b=rqgsHsF/KkjwXv95im72JFzdNW37tl1sln7EH/z7Bzh6XHX84QukzMY9/O5h23XBue rlV9pa2qnwefsbX0bv5jD6pzyHWyL9dfvuTxEUl9VWc+PekVlGSCy3gvjE9TsQeV+U2K exOykEoTx42EUBiTFQNGOKp436bO4SXTiup//w+Dope4SpPAkAXyYbyi1JS6C/s8ICbP eRrMq8J6dsQnN2hTxSkimQfFvMR0oJ/EkIuO9GsMCRtBY0OZmNbpYuvt/srX2StVoP6l TUVdI2U0+lAw4MyaXMgpzNzY+L999do5pdHzmjgwfpAdp7NumyVazfoR5qXOcyi8uqVK iBPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=3paXl7DP9Pq0lFKPbk4H6K6Xb1lES0iem+O4Uo7l7xc=; b=BBIrtQzvww6WiXwoixLdt2BHh1s1Yz1y67R2KTd03EColH3F61JA0cPrl67emVfmHl soBOKs0TtRoAaU+qkGw3LCuQADjQOpAVUHGNpdVBlGHWzCU0uMUIvPc8skzyDxipX9s/ LNgP4+552ueziwbM1zn8HvtsCFUGScOwuyZ14AeLeiSdkgjZsZ5MSf3kfcbfnTuSMQYZ RwQLl7zmeGIPdkcgYdX2cgH5BS5lB1Dru4tA8sTP88mOSQ7efBC0kMMln+yaND/bTf9O kgnPyz3IbiSOz8lYoYhcq/x6Tkcfm1aUMXQjq0d3qB4kB/waiCGWU8nlSHkHiMnf6w8J TUmQ== X-Gm-Message-State: AElRT7G+CQyZI9nDl83Mcy2UP1IJWNI4k5eQUPIVBnnUmIMTb1Cibedg IcrjbFVvikAn1VjrOrVOQgnfvg== X-Google-Smtp-Source: AG47ELtFp56Tml2h7PfgvF1NRMXHlr83ydqf2x/7/3JduPmsPNnYLWpzzPeBXlRXq8jXxrs1khzIfg== X-Received: by 10.55.246.17 with SMTP id y17mr669845qkj.104.1520643976586; Fri, 09 Mar 2018 17:06:16 -0800 (PST) Received: from pallmd1.broadcom.com ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id n39sm1540681qtn.16.2018.03.09.17.06.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 09 Mar 2018 17:06:16 -0800 (PST) From: James Smart To: linux-scsi@vger.kernel.org Cc: James Smart , Dick Kennedy , James Smart Subject: [PATCH] lpfc: Resolve static check error in lpfc_nvmet.c Date: Fri, 9 Mar 2018 17:06:06 -0800 Message-Id: <20180310010606.19539-1-jsmart2021@gmail.com> X-Mailer: git-send-email 2.13.1 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 6e8e1c14c61e ("scsi: lpfc: Add WQ Full Logic for NVME Target") fails the static checker. Driver is missing an unlock on an return path. Add the unlock. Fixes: 6e8e1c14c61e ("scsi: lpfc: Add WQ Full Logic for NVME Target") Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvmet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c index 66218afa1453..07f89524c320 100644 --- a/drivers/scsi/lpfc/lpfc_nvmet.c +++ b/drivers/scsi/lpfc/lpfc_nvmet.c @@ -1047,6 +1047,7 @@ lpfc_nvmet_xmt_fcp_abort(struct nvmet_fc_target_port *tgtport, lpfc_nvmet_unsol_fcp_issue_abort(phba, ctxp, ctxp->sid, ctxp->oxid); wq = phba->sli4_hba.nvme_wq[ctxp->wqeq->hba_wqidx]; + spin_unlock_irqrestore(&ctxp->ctxlock, flags); lpfc_nvmet_wqfull_flush(phba, wq, ctxp); return; }