From patchwork Mon Mar 12 15:40:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Snitzer X-Patchwork-Id: 10276625 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5281660211 for ; Mon, 12 Mar 2018 15:40:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4650328C72 for ; Mon, 12 Mar 2018 15:40:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4515D28C78; Mon, 12 Mar 2018 15:40:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B431428C72 for ; Mon, 12 Mar 2018 15:40:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751690AbeCLPkT (ORCPT ); Mon, 12 Mar 2018 11:40:19 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:49388 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751458AbeCLPkS (ORCPT ); Mon, 12 Mar 2018 11:40:18 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9B90CE44B5; Mon, 12 Mar 2018 15:40:17 +0000 (UTC) Received: from localhost (unknown [10.18.25.149]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3DB1A2166BAE; Mon, 12 Mar 2018 15:40:17 +0000 (UTC) Date: Mon, 12 Mar 2018 11:40:16 -0400 From: Mike Snitzer To: hare@suse.de, "Martin K. Petersen" , Ewan Milne , linux-scsi@vger.kernel.org Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, kbuild test robot , dm-devel@redhat.com Subject: Re: ERROR: "scsi_device_from_queue" [drivers/md/dm-multipath.ko] undefined! Message-ID: <20180312154016.GA29395@redhat.com> References: <201803110354.yaesL1Mi%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201803110354.yaesL1Mi%fengguang.wu@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 12 Mar 2018 15:40:17 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 12 Mar 2018 15:40:17 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'msnitzer@redhat.com' RCPT:'' Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sat, Mar 10 2018 at 2:29pm -0500, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 3266b5bd97eaa72793df0b6e5a106c69ccc166c4 > commit: 8d47e65948ddea4398892946d9e50778a316b397 dm mpath: remove unnecessary NVMe branching in favor of scsi_dh checks > date: 4 days ago > config: x86_64-randconfig-x004-201810 (attached as .config) > compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 > reproduce: > git checkout 8d47e65948ddea4398892946d9e50778a316b397 > # save the attached .config to linux build tree > make ARCH=x86_64 > > All errors (new ones prefixed by >>): > > >> ERROR: "scsi_device_from_queue" [drivers/md/dm-multipath.ko] undefined! > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation This error is due to CONFIG_SCSI not being set. DM commit 8d47e6594 ("dm mpath: remove unnecessary NVMe branching in favor of scsi_dh checks") updated dm-mpath.c to call scsi_device_from_queue() to determine if a device is SCSI. The following patch fixes the buildbot reported case when CONFIG_SCSI isn't set... but it is unclear if this is the best way forward. I don't want to make CONFIG_DM_MULTIPATH depend on CONFIG_SCSI, as such we either need the following patch or the equivalent in a dm-mpath.c wrapper. Thoughts? diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index 7ae177c..d6bcc96 100644 --- a/include/scsi/scsi_device.h +++ b/include/scsi/scsi_device.h @@ -333,7 +333,14 @@ extern int scsi_add_device(struct Scsi_Host *host, uint channel, extern int scsi_unregister_device_handler(struct scsi_device_handler *scsi_dh); void scsi_attach_vpd(struct scsi_device *sdev); +#ifdef CONFIG_SCSI extern struct scsi_device *scsi_device_from_queue(struct request_queue *q); +#else +static inline struct scsi_device *scsi_device_from_queue(struct request_queue *q) +{ + return NULL; +} +#endif extern int __must_check scsi_device_get(struct scsi_device *); extern void scsi_device_put(struct scsi_device *); extern struct scsi_device *scsi_device_lookup(struct Scsi_Host *,