From patchwork Mon Mar 19 10:33:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 10292079 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 46D81602C2 for ; Mon, 19 Mar 2018 10:35:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3324C291BE for ; Mon, 19 Mar 2018 10:35:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 27910291FD; Mon, 19 Mar 2018 10:35:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AD3F5291BE for ; Mon, 19 Mar 2018 10:35:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932647AbeCSKfX (ORCPT ); Mon, 19 Mar 2018 06:35:23 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:56512 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752957AbeCSKfV (ORCPT ); Mon, 19 Mar 2018 06:35:21 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w2JANqKX166578; Mon, 19 Mar 2018 10:33:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2017-10-26; bh=Bq4GxE2N8eYymoXNiTURVZFI+zG1X4olKGcrgCMyEUI=; b=Ea7dc7G334k90GLhF6iWuEykn2RFe/UBWF6OaI3G1k0oGmj5HhD5nb0ZELNxA2YZO7vZ 2lUG4i+Th1QLbWftJQd+7blLTYynTciBNdX69vSo8106LOghq1Vk6elG9xAwGLRBemye Od07BYk45IITUaI9qXkTDTY76lRVULkCdaWAGdf5DOsVUOHuXpETbRaehck1RgSd5Yu6 ZZd3fQbL2kaOwKa3a7tllzKtHHRx08qzdH0nBFspGx7iTb91euAyQiPF03EXm6BxOWnx EkATaSESn+kVH6Y0Q3R5cVD3/kIP9Jg5dgGrf5P/D7JYTedQGRjL9vzDlRDTht0RI5ON 1w== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2gtbdt013m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Mar 2018 10:33:13 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w2JAXC8U032670 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Mar 2018 10:33:12 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w2JAXBGm011809; Mon, 19 Mar 2018 10:33:11 GMT Received: from mwanda (/197.254.35.146) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 19 Mar 2018 03:33:10 -0700 Date: Mon, 19 Mar 2018 13:33:03 +0300 From: Dan Carpenter To: Adaptec OEM Raid Solutions , Christoph Hellwig Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 1/2] scsi: dpt_i2o: use after free in adpt_release() Message-ID: <20180319103303.GA8543@mwanda> MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8836 signatures=668693 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=565 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803190007 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The scsi_host_put() function frees "pHba" and then we dereference it on the next line when we do "scsi_host_put(pHba->host);". Fixes: 38e09e3bb056 ("scsi: dpt_i2o: stop using scsi_unregister") Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c index 3c667b23a801..ac2f40d9963b 100644 --- a/drivers/scsi/dpt_i2o.c +++ b/drivers/scsi/dpt_i2o.c @@ -306,8 +306,8 @@ static void adpt_release(adpt_hba *pHba) { scsi_remove_host(pHba->host); // adpt_i2o_quiesce_hba(pHba); - adpt_i2o_delete_hba(pHba); scsi_host_put(pHba->host); + adpt_i2o_delete_hba(pHba); }