From patchwork Tue Apr 17 01:04:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10344125 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8A98A60542 for ; Tue, 17 Apr 2018 01:04:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 846FB284B3 for ; Tue, 17 Apr 2018 01:04:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 79285288FE; Tue, 17 Apr 2018 01:04:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1C47E284B3 for ; Tue, 17 Apr 2018 01:04:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751893AbeDQBEt (ORCPT ); Mon, 16 Apr 2018 21:04:49 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:23670 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbeDQBEn (ORCPT ); Mon, 16 Apr 2018 21:04:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1523927084; x=1555463084; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=HhEqXLBAt3aF2Mp1VGx2lu6/seJnDx/7ZtBneIGHpis=; b=A6eWGOk/p3HIUCcx1kurhVbEkn4osDfzUVXxdLcmmirDZUqP3KIrVwNj 4m4Xpv0m39uGUAIsmqNPcrZVjiSK3ps1fN0wmVA10YHkXovTb8x443/XV Mhy2PrziAXztyVybKJ70N4DgRFDmIxo8vz+V/xN6qUFoSHOiFAJ0PGDrs eZmisEpX2uZjw4UflsYzO2fgR/BBhY909iYVC+9PfuWnYhCGk+VMrM54y X4ATUnf8eR0c7N4r2O22bRy4kY20ATNfszS9BOZdFPCaYfvEA0jDBqmws PQq/hCIxN5+7Gs6l5dCeyTnEOmOeOYKz4Y864md6D29wEcL4ixRJ2zx+/ g==; X-IronPort-AV: E=Sophos;i="5.48,461,1517846400"; d="scan'208";a="75991645" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 17 Apr 2018 09:04:43 +0800 Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP; 16 Apr 2018 17:56:30 -0700 Received: from thinkpad-bart.sdcorp.global.sandisk.com (HELO thinkpad-bart.int.fusionio.com) ([10.11.175.142]) by uls-op-cesaip01.wdc.com with ESMTP; 16 Apr 2018 18:04:42 -0700 From: Bart Van Assche To: "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, Bart Van Assche , Damien Le Moal , Christoph Hellwig , Hannes Reinecke Subject: [PATCH 2/3] sd_zbc: Let the SCSI core handle ILLEGAL REQUEST / ASC 0x21 Date: Mon, 16 Apr 2018 18:04:40 -0700 Message-Id: <20180417010441.28903-3-bart.vanassche@wdc.com> X-Mailer: git-send-email 2.16.3 In-Reply-To: <20180417010441.28903-1-bart.vanassche@wdc.com> References: <20180417010441.28903-1-bart.vanassche@wdc.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP scsi_io_completion() translates the sense key ILLEGAL REQUEST / ASC 0x21 into ACTION_FAIL. That means that setting cmd->allowed to zero in sd_zbc_complete() for this sense code / ASC combination is not necessary. Hence remove the code that resets cmd->allowed from sd_zbc_complete(). Signed-off-by: Bart Van Assche Cc: Damien Le Moal Cc: Christoph Hellwig Cc: Hannes Reinecke Reviewed-by: Damien Le Moal --- drivers/scsi/sd_zbc.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/scsi/sd_zbc.c b/drivers/scsi/sd_zbc.c index 41df75eea57b..2d0c06f7db3e 100644 --- a/drivers/scsi/sd_zbc.c +++ b/drivers/scsi/sd_zbc.c @@ -299,16 +299,6 @@ void sd_zbc_complete(struct scsi_cmnd *cmd, unsigned int good_bytes, case REQ_OP_WRITE: case REQ_OP_WRITE_ZEROES: case REQ_OP_WRITE_SAME: - - if (result && - sshdr->sense_key == ILLEGAL_REQUEST && - sshdr->asc == 0x21) - /* - * INVALID ADDRESS FOR WRITE error: It is unlikely that - * retrying write requests failed with any kind of - * alignement error will result in success. So don't. - */ - cmd->allowed = 0; break; case REQ_OP_ZONE_REPORT: