From patchwork Wed Apr 25 13:08:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dupuis, Chad" X-Patchwork-Id: 10363171 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5464C6032C for ; Wed, 25 Apr 2018 13:09:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 41CF328DF6 for ; Wed, 25 Apr 2018 13:09:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 36A4B28E00; Wed, 25 Apr 2018 13:09:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BEA1528DF6 for ; Wed, 25 Apr 2018 13:09:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754028AbeDYNJh (ORCPT ); Wed, 25 Apr 2018 09:09:37 -0400 Received: from mail-co1nam03on0055.outbound.protection.outlook.com ([104.47.40.55]:6848 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753996AbeDYNJ2 (ORCPT ); Wed, 25 Apr 2018 09:09:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rvmYT+02aeLSk4PJAcWL0Cr0elYAn7wWifLkhFNtR5o=; b=JV4efRRebhrBv+qukG5QJt44On1UgogxNDZqTjp7cGPHrmuQEejcT5/gXwbGsTFMIBIkrdHMLXATdq/Jy1fxFnZ0Y7ZzkHb0A+XSMG6dY3yw3NnXIdygwfVYgHmeDJLM+BiKslB23BdBGd5CRzFTH3VRFE4MCatFHRPY59L+ZBA= Received: from SN4PR0701CA0011.namprd07.prod.outlook.com (2603:10b6:803:28::21) by SN1PR07MB1520.namprd07.prod.outlook.com (2a01:111:e400:5837::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.15; Wed, 25 Apr 2018 13:09:27 +0000 Received: from BN1AFFO11FD006.protection.gbl (2a01:111:f400:7c10::187) by SN4PR0701CA0011.outlook.office365.com (2603:10b6:803:28::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.696.13 via Frontend Transport; Wed, 25 Apr 2018 13:09:27 +0000 Authentication-Results: spf=pass (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; oracle.com; dkim=none (message not signed) header.d=none;oracle.com; dmarc=bestguesspass action=none header.from=cavium.com; Received-SPF: Pass (protection.outlook.com: domain of cavium.com designates 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1AFFO11FD006.mail.protection.outlook.com (10.58.52.66) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.653.14 via Frontend Transport; Wed, 25 Apr 2018 13:09:26 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 25 Apr 2018 06:09:22 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id w3PD98BV006468; Wed, 25 Apr 2018 06:09:08 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id w3PD98GC006467; Wed, 25 Apr 2018 06:09:08 -0700 From: Chad Dupuis To: CC: , , Subject: [PATCH 12/21] qedf: Add task id to kref_get_unless_zero() debug messages when flushing requests. Date: Wed, 25 Apr 2018 06:08:56 -0700 Message-ID: <20180425130905.6385-13-chad.dupuis@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180425130905.6385-1-chad.dupuis@cavium.com> References: <20180425130905.6385-1-chad.dupuis@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(346002)(376002)(396003)(2980300002)(438002)(189003)(199004)(26005)(51416003)(69596002)(44832011)(8676002)(11346002)(5660300001)(6916009)(126002)(2616005)(476003)(446003)(48376002)(50466002)(81156014)(81166006)(2906002)(356003)(4326008)(486006)(8936002)(305945005)(336012)(76176011)(50226002)(80596001)(16586007)(1076002)(47776003)(478600001)(87636003)(2351001)(54906003)(36756003)(107886003)(106002)(316002)(106466001)(186003)(72206003)(6666003)(42186006)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR07MB1520; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Pass; LANG:en; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD006; 1:TTLynU4bwnYeyYiETPOsIIJM5KTVy/y4ki4EMksv8OC9qmtHeK2M3SsFHUI4wWVg+A2wceWFSJkkhOEsCNg3EZl+tl4yCiOvBOH805HWtSAFhZrHyHYfkC2LEx0xGgDz X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4608076)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060); SRVR:SN1PR07MB1520; X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB1520; 3:jaGgvJtt/v8DPg4IDERt9pNPkklBdWJI4ouYtMGd8+X85D3D31/5HwGt5hRi28bi74TZ4bFqj2zl4tbR48xM0Zn+YMNOgCwbHo9JSDXoHoSu567d1TcSRflWPVFDV24RwDuADKbk6RJdxF0xLqUgYyh77Pfu3A4I8IbhhxhR1BbX0yqA/enK8nFzArAxehSPmuGfvEzCaKFrYIxB4DfIbuH2w66FBiGOMl+5WuHCR98eDhtwrZAfbCfZvCjb+wQNEPZGTukvuG6ruLCNkuF6ZO/0DUweI/DcMid3Y7w9fbJrh206C+H79RBk7X1UD9FKLBmg2sxqSNo18CoNUDW1fwJubVdSDvsRYaM5pm7/Pbw=; 25:lOMqoSInGEv65+7h2FYCmGtBwcHKsGzYgF6SCW5O+Ori33lWv75RbM4DpcJB7vh+LCn9h5oZfODV0Z4OsPN1iABURg8NQv5d2twlrNW6DAHQi3liSLuTEMRiZmm32DizJev6/YBnsrRuXUQiEYx/REKDcL7uRjT8UU0l4QWZMpZCYXmeWT/0HIwNu0cNt6W3G4uCTWs2z/PPbWYqDHC2zQxSlo06oS6DZv/YGMvvHAV6yDqJhH0xKB49eOi1EBtfCoWrKo6oWoA4ex03C1IntwX8HbZ+4u48GWsP0VTX1YDbrMNgDn8Wsw+jjmehRho7wisVM3nvihoysO7Vlcro3g== X-MS-TrafficTypeDiagnostic: SN1PR07MB1520: X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB1520; 31:Gif4iheuvEcI9mn6PXAdjxdVs7fV8h67GFxhXYNogDcZHXODbDBlgejNFR5sh2tiRRFtkNswUdzjjHB78Pmoo22tWmHVR6OruA3tb38cQAl4j1xcCp6GNBrQsQK8b65VRIS0OokAjGIFhwkYCyGRWULUOrh4reCJBVvOml9ENFMYjDRJusgEzJ8IHLwVFYAWEVF/Tt4F4RnKKccTMtrNKBooo4YrEiCkJio2ekrXqUo=; 20:TXx5NNbT0ChneSN/brPfetHe3gAaFDs8aEHd0Lx2bxsCT9WhWaxpCaXk/0gEpUcgGiYKUSIr2LwY2c1bT9JVjmFKh9uH3oNIoTasvH1XPjygCO1NBUu9KKn5iXBcRqm+3E939YIvUvVWg/lxYjhGUzn4ZbWLbgx+jfTCQU5QafRTTIVKbNAjxDlAiaqcKNYHr91/rCItODHN7/6FrfZ0mVsmi+WIVJ3GGnVp5xxoPJoAhszH+In2BTMi/jxL6vf1Y4vBLBmlieBlzOdTIjsbAVdROqHgFL/PVhsxC5GJ4+cpW9gWLdoBgkG+RQZ7VgvCBT2Hotp1lyQzMVcDYjT5gvcXxUvMzHnVGY0s+bNBYTxCHPEY0zjBfc4TAMHDnQOIbcRtQK8IITB1BAvov8va0Y8jSURN8ChZxWPywlWfXTvwklQ1e3qnYGGNHgZoqLDBnaYcabjTvtuJtZocfUjIwQescn0V8zlS3h8I5IHs729ra/skKPClx3MQkOs0HkUp X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93004095)(3231232)(944501410)(52105095)(10201501046)(3002001)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:SN1PR07MB1520; BCL:0; PCL:0; RULEID:; SRVR:SN1PR07MB1520; X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB1520; 4:8Gt0ryDBhFukT2VUWr+KXW1N6MGWVq1xIfBzJWsAB47gr/U9EqxfSNnT2yrwhbCjN/d6Mx4IfaY40uhurtzQv7abGnIHSO0dvTGyfcmN0hGzSAcceZ+6OHdz4EOSHWWrZyWjdpqvMBtyX6N3mrA/tSCBdnmVnDRZhRUqs6nUCAJUQCTcPKizlttgxL29n4g5OJoETa+vv66CfWlSKKVTpu5gBgYyuFlXg8OiarbdSVxGPtEYgj34Q7VY7NB9rHraHOZIXEQeH28EQMosUHmL6g== X-Forefront-PRVS: 06530126A4 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR07MB1520; 23:ElwUGyF00SbgALF1O/ysHgQGy036kY8dXRV8eg8pb?= =?us-ascii?Q?GpJkr6iI6qdAoVEY8ZL9udYvUkwEndIVo/1JzVsxBDOoMcCwWBn1EHu/gI+7?= =?us-ascii?Q?7ngcrePexFF+4pxjjybCD9WI0vhp0adxun6XisPdBPgjg9mETPSjnMPYuvNP?= =?us-ascii?Q?pifBJ6D7jvQFUjNucF1L7iHXQZL/dFvGYWzshZuRHigFGm/Xnfo++9XO+0k2?= =?us-ascii?Q?iQq7AFraFhpFp5zfVLVl7Vj4GvYBRmhcXAGXo/r5bhLR/Qw2wZ5Srjimq3PC?= =?us-ascii?Q?04UX5o2uvD1ikrKLo6avvd5EAajYg4ypActVKZ1fIco+G8PKhtEKlmpEFBlC?= =?us-ascii?Q?Hd1XyxQVjY1ZZd+FTI8zuGmIKn+5aa08UcQaulmCXARQ4u/ni1nwfFgq1UrJ?= =?us-ascii?Q?oYWS581eqwEbzPqhJdFYb4lzl7BcOZhvOW/jAqchV3Rlh/2abxoAz/e0t7u8?= =?us-ascii?Q?rcwrIVUYRUZBUR3j1Z9fU9DZQY2prosXawCzS5GyhhQTNlyGioFwIFoYI6OZ?= =?us-ascii?Q?DpMcegGcqtpIuPwAjKpxDkzsvA2Zabbd5QPnkjEHKmt55J/b1YMQmVMDnV0d?= =?us-ascii?Q?rqYgxnqYXSTVAf3z36r4z4Ki1aMpuv5ahaO7pIB8bPpm4Kl04h4Miu+yVUXA?= =?us-ascii?Q?VtHGWZCRks1gwY3lR35TiWMVmb86qgk5JyRatqQanWmxrninBNq8CUzr07j2?= =?us-ascii?Q?NHMib3+OMvcdwd+xDgJUBS0sRJISKO+jcca1jvrGX4ogsoxAMw1hQcifnwil?= =?us-ascii?Q?oGKUa53Nb2n9OUk1GlQ4Tv0ZqGvg+l2rKGR8EYV5ltiZlceBh49V9kT3Juy2?= =?us-ascii?Q?jNuNiLLqgAxa87wBKXvcCC5l74eMWNK6Wla7Gi9a5immWE3YI4zv1n9nU+48?= =?us-ascii?Q?C6acVrJdxidYrtvjjleFLIO30ffdFxUcKk+yjLlkkw+spzlJfOJvTQNOK88O?= =?us-ascii?Q?Dty10ufnikCnAY6RH1xw1ie2Vtrt/Qbk3XW6CM68NxQ1EL+QTOARcVslAlJh?= =?us-ascii?Q?kw5yWxrGQgNa6d463l+iVx9UoIjw1X3M1oxQLmZ1D211FqOGpRCYkl8hLRvQ?= =?us-ascii?Q?/LrwhFfmKix1zKLpvDqAnRi133XlIQ9gs8NpBoNrbr9f4LHEd1TryZrzW01I?= =?us-ascii?Q?7VtCAazI588Oh+4k+GwSlq9zVhmaZuQXjVAIFD/2Sil6P7+dWi3JA=3D=3D?= X-Microsoft-Antispam-Message-Info: QPLju2hWoBGksRRXHfBin8M9fTYHfyrq4He3ZkYP06+qmBV4tJciygWEXJCHpoOC56I6YONFVywBj+71LbI5t9OmTDTBBBHXl5KtdHJ60pZGXrIwusIOKXimtxtz7kuwE+IH+DgQCcWehoW49odgXh708eUiQE+2Rk8Cz9o4bpbqD07WBrkzOE596Z0wYWh3 X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB1520; 6:Ez7QtAL/YewQqx4gE90IBZd1LAfgAdSKvZRPiCnBfYBBZM1jWH+0gkkvcYVOYjTIs1qV4L8Y604DpolM/I3U+Dx2F3r17HF0p0EvAr1m4wCPKjt3CDJvG12CpmXx1SH5B/ufcRg3n43HlY8gIjwQUhyzi7K6jGA7p82nzgT7Lp2pNoqUvppRf8M4YpcGLLM0B1hO7fS3r2Ay5u/R+4rQlf5gbLvtXH8Xqv3ICPsB9dA8rfBRsM+LFHrzD4E9EiAri0NG8eoFgUr8eBjQe0HgJGCZF3jXvoyeQPuI050AGdNog6C1yod3SWrwHPwaCBSuSHsczNpPlp/jh+4b7hF23CyprYXirYtkjA8yfiywCXSV5XGqdhmRQ2w1iKc6IxP98Q1J+y/AvZSEbJnFIJ/de3aQTyOjefWZrcYzeRWeiTHVe6ninHvad6dwaH6U66rcnwsdRK12v/v25EPm1KIa7w==; 5:h1qqHWJ42SQrxxYe8Hki4TUllz1co2VCorhojUzDrGJ3M9qITIpZHqWubFI0tsGlOrE7YsCIF3NUb6k/ra6DnPeT6ISUYL4kAbFPz/dCXOYOC/ulifMcges5VTNPIX3nGqJqPNvYoNim1HsCxrvOWGQI7oEuSywv2xEuSqdJcz4=; 24:Bf9yrJf2q4H/AbOQrAk5+tT/w2/W+qOup29WbC6DPNv78EZbNySQPKPaN7tt5PqnjHXM3tu7lICdaBejFZoe7jQ2aBplvotWf2kphcRalVs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB1520; 7:cfVHVrP/nbCWHA3xQ8TfTWchej6O+qB3S3+xQfEUU8K/5CPslr8D1m+e+fK1ko49XjBjlF5WhUsQJooJo0wjewF7zjkZL2ADrNlQxLj/vyZ9ju+CwCRDgC8NbZ0iZ9e/Kj/3+GGN0QC6XJrQHZ8cFOO0D1J/XjuMMh8OfRshtPY/RgrKJMtX8fQbfFKibi1aT/i/+1O+0ErH6ZCk+c7l3iR8vdBSXtWaWVXLwzW5wKGet2CUUGkjb+sj7Lcbpbtf X-MS-Office365-Filtering-Correlation-Id: c7cff14b-78a5-4d81-4dc0-08d5aaadc600 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2018 13:09:26.7333 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c7cff14b-78a5-4d81-4dc0-08d5aaadc600 X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB1520 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Helps to corroborate which requests we can't get reference on and if it's real bug or not. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_io.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 78cbd126c7e5..589414f06376 100644 --- a/drivers/scsi/qedf/qedf_io.c +++ b/drivers/scsi/qedf/qedf_io.c @@ -1445,8 +1445,8 @@ void qedf_flush_active_ios(struct qedf_rport *fcport, int lun) rc = kref_get_unless_zero(&io_req->refcount); if (!rc) { QEDF_ERR(&(qedf->dbg_ctx), - "Could not get kref for io_req=0x%p.\n", - io_req); + "Could not get kref for ELS io_req=0x%p xid=0x%x.\n", + io_req, io_req->xid); continue; } qedf_flush_els_req(qedf, io_req); @@ -1472,7 +1472,7 @@ void qedf_flush_active_ios(struct qedf_rport *fcport, int lun) rc = kref_get_unless_zero(&io_req->refcount); if (!rc) { QEDF_ERR(&(qedf->dbg_ctx), "Could not get kref for " - "io_req=0x%p\n", io_req); + "io_req=0x%p xid=0x%x\n", io_req, io_req->xid); continue; } QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_IO,