From patchwork Wed Apr 25 13:08:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dupuis, Chad" X-Patchwork-Id: 10363173 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 61DB36032C for ; Wed, 25 Apr 2018 13:09:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4F7C328DF6 for ; Wed, 25 Apr 2018 13:09:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4372328E00; Wed, 25 Apr 2018 13:09:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B8FB128DF6 for ; Wed, 25 Apr 2018 13:09:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754004AbeDYNJk (ORCPT ); Wed, 25 Apr 2018 09:09:40 -0400 Received: from mail-bl2nam02on0046.outbound.protection.outlook.com ([104.47.38.46]:7506 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754014AbeDYNJc (ORCPT ); Wed, 25 Apr 2018 09:09:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hW8NRhQAZ5IzHG9nfqASTWdEnD4b/btydAH87LPMpQQ=; b=SmzQS1uMiYA3cnZrDeMxKVh3fvFCge0AMJLj41ygesfDDpXIU+dMt/6wokb6dajXWuM8dyPDZ5DMHDitcGGBPGyjrDAipx6RfmuTdZ4Htu4Ny1ZI3fnqaONGjNhwtdxbEaDHAzmmodU6tR7kZUbjCjCO8Wkzw5VFO6uplYx5vvU= Received: from SN4PR0701CA0011.namprd07.prod.outlook.com (2603:10b6:803:28::21) by CY1PR07MB1512.namprd07.prod.outlook.com (2a01:111:e400:50ed::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.15; Wed, 25 Apr 2018 13:09:29 +0000 Received: from BN1AFFO11FD006.protection.gbl (2a01:111:f400:7c10::187) by SN4PR0701CA0011.outlook.office365.com (2603:10b6:803:28::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.696.13 via Frontend Transport; Wed, 25 Apr 2018 13:09:28 +0000 Authentication-Results: spf=pass (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; oracle.com; dkim=none (message not signed) header.d=none;oracle.com; dmarc=bestguesspass action=none header.from=cavium.com; Received-SPF: Pass (protection.outlook.com: domain of cavium.com designates 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1AFFO11FD006.mail.protection.outlook.com (10.58.52.66) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.653.14 via Frontend Transport; Wed, 25 Apr 2018 13:09:28 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 25 Apr 2018 06:09:22 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id w3PD986w006472; Wed, 25 Apr 2018 06:09:08 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id w3PD98Uc006471; Wed, 25 Apr 2018 06:09:08 -0700 From: Chad Dupuis To: CC: , , Subject: [PATCH 13/21] qedf: Remove setting DCBX pending during soft context reset. Date: Wed, 25 Apr 2018 06:08:57 -0700 Message-ID: <20180425130905.6385-14-chad.dupuis@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180425130905.6385-1-chad.dupuis@cavium.com> References: <20180425130905.6385-1-chad.dupuis@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(396003)(39850400004)(346002)(376002)(39380400002)(2980300002)(438002)(189003)(199004)(356003)(2906002)(6916009)(50226002)(4326008)(72206003)(8676002)(47776003)(478600001)(81166006)(87636003)(305945005)(6666003)(81156014)(1076002)(16586007)(42186006)(106466001)(8936002)(48376002)(50466002)(336012)(51416003)(107886003)(59450400001)(186003)(2351001)(54906003)(86362001)(106002)(76176011)(5660300001)(69596002)(36756003)(44832011)(486006)(2616005)(26005)(11346002)(126002)(80596001)(446003)(316002)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB1512; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Pass; LANG:en; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD006; 1:Kd+kye/mLrPpsKAc6EE6mwbglO0exVJB/PBjXZCzDQ7ZnJazCwbnwjCziVqRaxc03S/GI+K6mQ+CezSlx8tVA4qIxR7ThrWUspgjSC/XEmVCK/1GY+wLsXgTc4++b+O9 X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4608076)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060); SRVR:CY1PR07MB1512; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1512; 3:Kwt8TO4iGl9W75whL5Oc2fz///HV7gHz3gBpP0jjyHvGlX6QjfBuHLz8EXeU0sDPJdoe0kkV/y1D62Y0VQ+OqOuHPGwyZwYxhej0ZrE3FMWfGXqWvAKSdWZpoQalaip7Pi0ZTly68xVd9cozVYrBjo645eqAfjM953nM8sowxcm/yH45jNdjoz+7a+t9EkUXX7Wl0qF0u+Nrpwp8FqYz10a83LR4nYO6CLbUEOSM605ke38L0kDdd8fwzjDdg3B8Rtyq8+9W1oqqSVGkTHl674Go3xR1imsGJd+Nzlpir6mRWcYrcE0gwZ72SDfUNNvfP6a0nFFzGb26Wgze+ijGJ5wZIgn7eqrp6nEF9q6oBmA=; 25:nMXdeA2uxZc14QtwBCUhUozkGOJM/YQiZpIaqJzw4+rPd9wC8RH6+f35sEqNkMUeEqeqTE3B0NZiriaWlPEHXKv/jOUy3XoYEZeWYso6fK8H0cOdp6fJsryM9lm6DIejizxk/Mu0uSR8BE/nrqQg8Fqild6uOlnYEW2/TsVqeaCyYq1JM6/bn5j57unioy09IGpcxFwQ+dm78D0MKZ3ndT0spaq30t38vqw1Zr3eWMMx8tXJaQ0hwXERdklO9cdPtAbe95TEu6+6HGS+p9gYpII15b5jv8Essk2nhlZiTm07boaZYcJaVn2LY79K8iHDl8+vKqrBQgh3eab7tWP8Vw== X-MS-TrafficTypeDiagnostic: CY1PR07MB1512: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1512; 31:wie1MYWxZVFjYWqPt85xJ+5UG73ROm8Oq0eTWISKOJLPsHfvykxgSPAy1Kq2PW6iET1a04yPqtRE/WAigieJjVeBVBKnsPy4RcS/4IR5omIqpQdZOX5/0OoZuxkqLBVkQAULERLogCszxr+5s8KnUxvqbuuUmlTV3kHaghBlsoj3dFWc59qF2V1bEhrCkijkWkB87jAMs39HTKXo4Oy5H9y16Z2S3ht2Y+SWQLfM9pU=; 20:Ima04XUdv4fKkZdMywVJjFS6FiUyGUmbKZ7yzFqpF0mtS+nMgbnemcjlYCU5uEBNu/Vp31X36bzHtc41yeGP5cRi2Wf2s1oVi9B6+HEzx1jL9/8JSe1rcWVAjNhcAeL2P/Em8rC/1Wn5RZzssf6kHddiVtxoRc7e7Iy284WIRsl3mTwZQisVkn7GsAIAQzy/Hi9P4pGPJ3ffgiwIUW+ASEY9tL5S1DvFKprd/I4auklzMdz54b+rjzdi+XtLuW/mxmexH6lsReRYLLxPvgDgAXY9B6MEwruAyUH8vih4Ys1t1ubsHUvneVM0bj0jSyPHroU8M8PRoMO8rTRgBCCvk2lkJcg9x/NwJkax6X4585Tm/yGVtqVcpqBIl08OftEuGQ4J6KcG0YtfT39llQLUE2Z11uSSq4U6rmF3wYDA8LRGe3lVbG+05YZ1jkkT7+7Z/eRjuuhEQiJRPdx55kZAuqOqL0OnjutuzPQftSOEnQ/MdHcF2Hl6G+ne5YMIpUFN X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93004095)(3231232)(944501410)(52105095)(3002001)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:CY1PR07MB1512; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB1512; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1512; 4:j7G4M4DIpoaho1TTUF/36ou1nPXQ0eNwBmiGa/I4KitpWpJZFNAzIq16geiuGNx3sEBLWCGoVK2cncNR0HUEGn24X+RYbgSY4ogZy0hKiAOS+1vbSRc9Zq69iezPL33KGcWscYs3+PtjvKrTlCPwlNwPsP939CM8jWmiupjWMddt8rmQNPcxoO9gOZPeZU81da+XThC6fAU9GCFpFOi1aLU4MbeIfbS9V7JjwlOi3bYbVV2JJrPTEVgKqH30d8H8JwGei42sQDNa03b8aXPpRQ== X-Forefront-PRVS: 06530126A4 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB1512; 23:BZ2hSgyiW8aKqavFz8WP/NiXyEfu6ki9aTUg5URP/?= =?us-ascii?Q?19rCpma51zN2+84A4xbEt8l8Aon+2TUKTFDE4r235RMZItbYfI2nxlvQe58n?= =?us-ascii?Q?Zj8yN+ZBMDnXPybLvC2aDyY4ihSljEaQkf0Xo9FQRBmrKr9+3qqRIIocQbTn?= =?us-ascii?Q?coCuWHyXzaRj6cFMfs9tk58Y05vQZZrnXyA7U1IC6TraaXq/fmzx3Jo9RK3l?= =?us-ascii?Q?iCBjCgQFU9sCEX8zsY3pVsms/HjVIg7j1H51Z5Zr6D6kNobAsQGtHkPpx4lm?= =?us-ascii?Q?OPTxuwrWmgK0db8bmRq1leLdOjQ1A8Ey45vyL/VhmXTHHzrQZFK77DGjk2/i?= =?us-ascii?Q?oztmR89zGTZTAO8OC5fLAU+Tn+iPiWHb7HUhQkqGS6ZIcBUAR3Qfk/ycGYxp?= =?us-ascii?Q?d1sVp0diAhVW6+2jIYpMfn9yc+8C6E8EhsehvlJMnU3ywHv47HDgecn2n2M+?= =?us-ascii?Q?wEPRoVZHNrSaSnF/7ZIZwWYu6BGYGy7Up7lS1WieH7Nh9bBAp/iBuknyb6IJ?= =?us-ascii?Q?1qpWOA16ducylAcl+4fdV8GIEFFi8J46GQc1RYGzVxmzXqOENnu6A8BwNNek?= =?us-ascii?Q?b5DIWh3/L972Cpn3crCW0YNExIHKDcm4hdErAP4NHFIt/IfWHkXLHFCeErhO?= =?us-ascii?Q?zkv1P33xZSaIN1yTH0fTXKD9FWGdr1nmE5cvChdPHfCAlQu3cKmwwCa7i7Pe?= =?us-ascii?Q?uoJ7WYXOlv/HvTkrCeqgBtFZQEUh7tO/xSKvUzHcE36pEHixVnLWRR7tOIYC?= =?us-ascii?Q?+0CyHD4Blfclvmvz/s/Qsz13vNU7mmlzgHRzWiBXWJ7pf1tzkygczMdc7H5X?= =?us-ascii?Q?kH58TT5WsaIUc9KHz5i96/HKccAbbEO5GvN7/V17yGiZPCotLZZGDpSGN/QQ?= =?us-ascii?Q?l42pmG82dhJ4SmYsEGO7JQQei83P+X+658B+oU+AKgJkSz6UJZuDSO3y57tx?= =?us-ascii?Q?R+5rb8/3cXoEDzhy8TX821JH/vBqGI4g7BGlT/RWGR0PpGxTbYgOyNkzjB/f?= =?us-ascii?Q?R1KizaVJ/feP1oOHsTz1ODKqhGgyezc5Fw4ijIYkq+uCScoLJH2zeIVcPP9c?= =?us-ascii?Q?CLjxjD/QBdBSdJmoTW75Pk/3U0HuC36UWWV7ttY3hnn+VBqU/NJqP2NZdMFK?= =?us-ascii?Q?MgMWeieySy5Lga4Z8HmQtrLM8/XUiNPZkV6aTB/Cs0ikMtRbgPCp/DnYpmyN?= =?us-ascii?Q?A3Y4BT9VLpwo9A=3D?= X-Microsoft-Antispam-Message-Info: TSai9IfcA7Y2z50JPf5yXOjlyWkOffIIH9+6bKF/zfZfK3V+DFQqmf9I6dITqsD1l1fodL/jeN2VB+8sE7dxc6fHyGECAU1JHGu8KSJtIzEv46UoYtevtsk5DX3ZGlaSUiPNEgf6dG40ewx/AodBymtEmnlzmohTbLpZYQVtf1QcE1c6hI/CPl/IpPv33EvL X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1512; 6:UtRBXfVmOiU3ohw1Nf5+n/lXuz2BWQszTl9g2S+Ry3eqPZSYhC61AQf3R6/Jftjc9ehg4zYafs/rAYL7qYk31babAy4iIIaokC3t3J2lVP+jWUu6dxBKhkDI3zpHYBsO8XjBw7RszPvsOzttGjWrkYb54CfPO3nr89FauuIWw3+k0iZeFA4I9Z5ZQcf3BWqQCwSMAILR8WWQEDkidGKeLRcJdKZCnfU+73phFkqJawDczfqo4ZJJ+yJUHhUPuYZLNzmKLRW6piWA6EMAa0AbRjIppH1U6BFn1NBtulXLorEaZZ+MlledPB5GqdRIdF+Cn5hp9alcci2at4O+/hban0EjoXZAHm8yYDmQ41NKSJF9encVnntoPfpnpMvAFoclhGPpQVVZe68XjGjcCzHDQEagkunFwMKRZkpGeGMpchzMQAm7Awhxwo+6GXCu6QIyryDVzEk5MFJlfkQtumo6mQ==; 5:F33u7Cs+MlUSSMzO/G+pjsOtie3l6Q3z1FmtEiNmVbcgMV9Qa06xBkbyJ89F7TnPdljNKYZGDJu49R6J4VZXqEwyQkvl1KhxKT12oqAS33mMC+ggdy+Wr5RDUbUHQu56OSWJr6sc9spVM7HH6NW79tMXFZ/gpoDRChthjJHt4TI=; 24:46NJCt1GRFQXPxgDy8J/hkvP0S7XRmbe4HjeEBmDz1wadLZr9fLWu9qcm/ImdFAfE9ZJCSuNW07J9D6R4WUTnP0C+Wa2f47ZV9jZDoQ2gnI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1512; 7:uYz2c8kwf8Amq0YAK2K6ZRLCJLnhaN1vwWH6DRph/2fRTyQijM9V4TsBDUg588LF1QZDIxITam1qhgwCSZA+0X/mQwDJJUXHX969q6WfzE56TikgxkH0TG5AA7oFj3HRnyNyPzWa/awzOL3duo23wPwTNLi6fmEbqzSWsI8Qwk0/1h3MYPt6mdT20YqsGTJifcOr/FIe73wsw4GA5TlSmPz2qxYTbmXQkdi2Dwt8fNPgb0GlTFx2DgJAqGQd+KXY X-MS-Office365-Filtering-Correlation-Id: 07ad486a-b261-447e-aaf2-08d5aaadc70f X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2018 13:09:28.5118 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 07ad486a-b261-447e-aaf2-08d5aaadc70f X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB1512 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Saurav Kashyap PROBLEM DESCRIPTION: According to the logs STAG was changing and it was triggering soft reset. In soft reset we used to virtual link down and up and also we were disabling DCBx flag. Since this was virtual link flap, DCBx never used to converge again. SOLUTION: Code change is to remove disabling DCBx flag from soft reset. Signed-off-by: Saurav Kashyap Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 866989ccd66e..be29c8d155c2 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -734,7 +734,6 @@ static void qedf_ctx_soft_reset(struct fc_lport *lport) /* For host reset, essentially do a soft link up/down */ atomic_set(&qedf->link_state, QEDF_LINK_DOWN); - atomic_set(&qedf->dcbx, QEDF_DCBX_PENDING); queue_delayed_work(qedf->link_update_wq, &qedf->link_update, 0); qedf_wait_for_upload(qedf);