From patchwork Wed Apr 25 13:08:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dupuis, Chad" X-Patchwork-Id: 10363155 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C7F44601D3 for ; Wed, 25 Apr 2018 13:09:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B784F28DF1 for ; Wed, 25 Apr 2018 13:09:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AB7E728E05; Wed, 25 Apr 2018 13:09:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 80F3328DF1 for ; Wed, 25 Apr 2018 13:09:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753336AbeDYNJU (ORCPT ); Wed, 25 Apr 2018 09:09:20 -0400 Received: from mail-co1nam03on0069.outbound.protection.outlook.com ([104.47.40.69]:35920 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751705AbeDYNJP (ORCPT ); Wed, 25 Apr 2018 09:09:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6b+EybOeVKsxz7VliGmAq9UIg7jfZlSaSXommmHokLs=; b=d2YwOijNCPp7m5dLp88Q/Xzxe3XUZ3eG+ORjYD0SETnn2pnfvVUB7vXOGElKvompK9u82di7Dn2Wk2jvWdubjQRty7r9B8PZw7iViHXjFgNrg+wPbtOqPIwi6Lk5Ej39guEvApUBmVoWWUjRLxY2XyVyx+Q8azPyy7lmm5EJJ2k= Received: from SN4PR0701CA0011.namprd07.prod.outlook.com (2603:10b6:803:28::21) by MWHPR07MB3181.namprd07.prod.outlook.com (2603:10b6:300:e1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.13; Wed, 25 Apr 2018 13:09:14 +0000 Received: from BN1AFFO11FD006.protection.gbl (2a01:111:f400:7c10::133) by SN4PR0701CA0011.outlook.office365.com (2603:10b6:803:28::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.696.13 via Frontend Transport; Wed, 25 Apr 2018 13:09:13 +0000 Authentication-Results: spf=pass (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; oracle.com; dkim=none (message not signed) header.d=none;oracle.com; dmarc=bestguesspass action=none header.from=cavium.com; Received-SPF: Pass (protection.outlook.com: domain of cavium.com designates 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1AFFO11FD006.mail.protection.outlook.com (10.58.52.66) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.653.14 via Frontend Transport; Wed, 25 Apr 2018 13:09:13 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 25 Apr 2018 06:09:21 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id w3PD96HP006432; Wed, 25 Apr 2018 06:09:06 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id w3PD96T5006431; Wed, 25 Apr 2018 06:09:06 -0700 From: Chad Dupuis To: CC: , , Subject: [PATCH 03/21] qedf: Add missing skb frees in error path. Date: Wed, 25 Apr 2018 06:08:47 -0700 Message-ID: <20180425130905.6385-4-chad.dupuis@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180425130905.6385-1-chad.dupuis@cavium.com> References: <20180425130905.6385-1-chad.dupuis@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39380400002)(376002)(396003)(346002)(39860400002)(2980300002)(438002)(199004)(189003)(50466002)(106002)(36756003)(11346002)(446003)(305945005)(72206003)(80596001)(42186006)(47776003)(316002)(476003)(107886003)(48376002)(69596002)(6666003)(6916009)(44832011)(126002)(1076002)(50226002)(186003)(486006)(86362001)(2616005)(336012)(478600001)(87636003)(16586007)(356003)(2351001)(106466001)(2906002)(4326008)(81156014)(81166006)(8936002)(26005)(54906003)(76176011)(8676002)(5660300001)(51416003); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3181; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Pass; LANG:en; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD006; 1:Nx05311DC+TBZMbGhLYFuss7SAjcDKjVH64UoIShsO1j1cjdLBAPGAGuNx3dakP4rfsDhq+TBriNZeg2YEdkbeFKIeiOPApinaGT9GU/5tF8mu/6V4Q3ceL+DgoKExg4 X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4608076)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060); SRVR:MWHPR07MB3181; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3181; 3:xnOjXhaE0i0Kt0HL3AgG0qd+sO+9lmUCmn4byr6PmKcElkr8wvvQWGpF8N+ml4O3qxW9TzfgghjJcJpClwBG6nAxBVaXtFIBNLeCMm5A7vA0pj0T+EfBUV6fcPUtq7sma2o930VkRVzoMEuftCP5L5l2intmixAq2e3jK0jmlByNaW+SDncLVAP0c8V1rxl8yB184BRBceCre3W2g1iqrdzkcix4iBFhB82jLY8HtvPDJT8PxVOOCLowEBrLXmjY+m3M+glWZcjce2PMzgsjgVntYKwmu6RU6dFBrWJ8khfZXAmQWYyOxH+hinestbhJMPNgvAkB01MkhA7XuQMz7f3e+Orqno7V2gt38xe3yqs=; 25:AWxRX7gXFesh/yGSdiUGB+75WD8Rsw1MSnsH72/C9BO2hsP1CB70xw0/q5M2fnykOlcu9EFa9vl46hN9WvxK0wrGRahGAXgo06UWcjLmUJFq0/rTrgsBq4zGrEgVWDS/PqHD8x3kwoRAEU+iBxSJkKgRnUuJDFpEUIWjwNErJdIfJkkzyqSx5mV1nQJ3T74YdmwoM24EiFghQJ1ENW8Jz3Azm4vDwCMA8Y5dKRIfqQpOoO3sLkozV61v5U8rov+/9ue/OCRr8PQEcEX2CfGR9XwAUajdteMKeUHNO//tgxvspNM9A3aKatTzx0Q2SAYl/izu0eqpFa5c6f4tLG8Uyw== X-MS-TrafficTypeDiagnostic: MWHPR07MB3181: X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3181; 31:SLZq5DE128XvtTaC0ltHePmcw4q2H2bUO1eKttxUCLtRt9FgndEeHaj33m1//+mv4uTQ++ctV0vgq0fleqNTzvYlOjpLBCg7LcfMOLGjrK8Ql8J7NdtlrEZZsycMH+CJ04OLSS2ja2S2wea/aSYiJPtWYCxcTzM2Q/zYIzFa2rkpv1KqWiHYu6dmPHrrvde2RkH+PsT+x1gA+A4knwFSbyETg/APvb3p0f3izCzaTR0=; 20:XRvFt0Mhi2xDRpPdeWPGD2ltgWFfLlDiFrtM3h0dJXmF95xNCA1wfqyz6HS29wIaeduWXXlwLkLgLVtMk5cuuzitKVAxTfevx97D98JCgwytLVNYgYbxVnG0BTkVhA56yuoBXTbAhbae8fYGf9A7+LV9LJAJwW8rQaQPe+ZIlRnAZMbZY2FeUffuI8bEMasvxrwA2j2ATLqcyU9QZPGbK5KuNfVwdm/TorQpAO/Y160Z2SwAzm7pTJwL+bRmhC139WMp2LfyXymcl5Ji6VR666dBAx7E5DVCV2BfdKKP7L19Uqy85TrQX6z4fmjCbRfS3pG0/mw+kMybIm9bP2ZkJghn4CoeWoaUL8/OsHIIm4gThRC02MtOoBao1hv/oUais/EXgwUs+krBUdF3YZeE0W30R5czHpFHA43XhQ6ba6yw7oGxqftkVkbWJarUUaxEeItAmoeRMl2g+tPPuiggs9SeXeyc2dvV+FERUC/iQ/UcHNLh3X1QO253uMSyZmYQ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231232)(944501410)(52105095)(93006095)(93004095)(6041310)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:MWHPR07MB3181; BCL:0; PCL:0; RULEID:; SRVR:MWHPR07MB3181; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3181; 4:8CgV899B7FQgr6FF4gsoHZmqVay9UcPl4uwTnWFYSLnIoTp3Jr5kCWW7Df9suCjbxu0g4x+xN7M0CBDNeA1QaOc/x/8L5aViJwtKzYmNw+gYFOUB2YvVHXIcYvyAwQn+vVKe6DW59t38pKFFcvJYPuNBSJ+YWYuaa6/oOSmpGjwq6YfAQYYGVwdBeWVXgosr7ARf/MTLOQ8pZuiPUO6Sv++9UO5tPm+LcdcuXXvJaA8p2j1O7ea33uaDlAtmpvN3I9D6xq4OxuufDHnDk+ufiw== X-Forefront-PRVS: 06530126A4 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR07MB3181; 23:rZFr4WQgDn3GPwbC0j7soT1izuq3UlAiivaaVJHzo?= =?us-ascii?Q?4omRdpKF0wK6aoUp+Bfrp+ebrb+hgoFF+aYT2QqTm245kOMTsPvZDwvZv7bp?= =?us-ascii?Q?jrqkUDTIPXIKh1vC4ZZo1yhHiXtw4KS/KNbQIqtj77Wo5WUtQ47xgd+jdpQC?= =?us-ascii?Q?2GHJtpYKVGw9oN1bPcBk+6eoh64AMDJ/JtdFSSaFxcgMAETRyN3W25PJ3o9P?= =?us-ascii?Q?UU0+YBfcG2lHi9PvQ4KAegaXA+s6gmFcfdh1Y2uNYMp2744dJDIvGHferztJ?= =?us-ascii?Q?mFnmMxar66iXwCM4qmXoBs54WnFXIGvkxlUhYZbqmThpLd/FWz95Xec3v+NT?= =?us-ascii?Q?TYhIk89u0K7GOpnNcM892Uga9DM0W3oqJ8qQOEjfxeyBHnyvIMf1tb3JVcln?= =?us-ascii?Q?Ecfzg84TjD9s57ujOw1ZzfNisnRnpU1Ff8wU9BqL1pAe1rdNhLllzx6eAOWE?= =?us-ascii?Q?Pb70sL/FcAHZHFn878ZBijDTFoHSRnMSYmWtBxn7ar2G8N0gdUq0mdh5fhYt?= =?us-ascii?Q?glbwPgeouaoFaHzLgwyC4TgDp++blQOl+gqOztflJaKst1U6MC9DXokIPLv+?= =?us-ascii?Q?vXEalfKRDBP6P2tyqi759VQoYKUlxge/dbrWhS0/4+GQyHRw5a1BpzyHyKTn?= =?us-ascii?Q?oDI2ag9Ku0XOfKaSl8R3+87dgzNBggMhqr3EX4QTyVmsWIladdcZS4+wLIDJ?= =?us-ascii?Q?Z7G1YrtB7zn2d1/s81Pw4gcjurw3MbmfXB+v0YSF8TFRu8FWehfoYrc6W1GJ?= =?us-ascii?Q?9NdVF7Au/AILx/Uva2aX3qkHQ5vL5xH4HbHKCZHeDJzWECDwthJYvEhr3rnP?= =?us-ascii?Q?yGA94hs1HOnLJnNMtkddTKebtdYlYnUgg90QjtZOKAJYRe7uTibLB3eMqy55?= =?us-ascii?Q?/6LZtZRK7p5WGm2wnFeJwrnDXXpYRbPen6OgtHA6a6CL7tLyFONNf0iVCenc?= =?us-ascii?Q?NbIpiY1kMDVsf/t6aCZMKbUKUe/R+PFgbC+ee+JKR1Tdpz0zX+gXS1CnQ1fb?= =?us-ascii?Q?pMVHANhW9l1v0s+AdiY0c0Nxd3ODvzysolruRff199Ep760DOwlVSfcJgN78?= =?us-ascii?Q?r8e6tLhBWxsq8n7DY5ff0cDrtWVIkV0GQ/kAylTqiHJVMCDoz28TDD5cahka?= =?us-ascii?Q?2nL91/4D+Hjykrr/SuPQ0cSiZtWe1tzP3y5fhGFx5s0jlx/K2r5jA=3D=3D?= X-Microsoft-Antispam-Message-Info: z4f03VEEiXHlRT8TRUUavVHqiN05PTLwM9FqSvROzBQfHz6bhP1ztrcK5emb3uyS0x5Pt2G74GEfqFPw2q/kJgxAwJKEIJvOB77KO3dnOKFih4KVzLygqoRZ4MF/bBOqrXgQBleW+FJwg5GuQ+DQi0PJ09h5rXVNQRMG+gEoKOg/URZQeJLEtKmn1IVK+SqP X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3181; 6:Ok/nyubJFDX5piVDcdX7dMg2cYiUWbu01dDz1/0KQ+OVrg6fKLfQOA4Z+WqaIXBMqxiEsNNbXB+yc5ek5DcywG0ONuiz7CotycSE75sJpgzRtCqc0RlYpXrXYa5/ZKA7629fi31rA9j7WARoZUUo/XNQUGo3bShNCYTUbL4eVY1iepzHBLg/Qd98uWFJJoYyb0QOeG2iOfrOOZwyi+hfsonmpqzb73Oeb2wy0WWcvkFFnXoRDYYbtLArMbG/x4O8L6jmfns7ahJEyyRABYBKAR0miJefQbIuzThnhAx4J8EL5HDzbwXl9fbZXmQxJHNCD9V0oXlbBz12G0ZHxN5o6elVYvrTJOOyhMQyeM7hyE0WIza8AvjTpxYPMxbjLEVZOLz97VlxpCyDEO5NsQDb0M4jVEDP/4BG4PXrSDdbxv8MRaNuo6BUzMae0ZVejwQ7cO8HCfZR5hoGFK5QEjRi7g==; 5:DkZRNuo0YL824AquOP9ksSMDCggKcpf+mcDCSE5HlvHHaGVsXV7K6Rre0gvehCSa5Ndo+j1Yye/QuFME3DxjU4ybaeCc28dxG0xtubYeRJJ9bhyB4XPbeSN2AULYWJKeT8hGn6ynjMRdh3rBJZJlg1paPRr6P42uSjtc+JhqTAc=; 24:S4/C93+3oOmAQXyNo2J7TJ97RulWGiToUqZExWHIhDJBo2nLK3PNRD+B9+0zl3rNCu0GR4G89elhGfvvgG5iyJk7jKFBaDekNqEeUYtA7cg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3181; 7:n3RtFSed0mzq0DpiQJSon51Iu2yFYUV6yy9l10DUG7mEtBb1Z+BL/527PzAmF203NLoGU9PEwIu+mzJz12O9QJwTj3Kvnw0IkqqmUwH7EwODrmmFWkykIGRc2+pHSHOBCuzRoiroEf22tWuNDSWGV1Z2HB/NyltL4TdfGdZzxQbBzeTA5xA5skK5nJpaXnJxH/iBPYVXuHd/dEDc736zJg+BlWa8G2Xc6k4wn3F9QcJJqDxZkE9gZuPYQ23CUERJ X-MS-Office365-Filtering-Correlation-Id: d2cb1677-b9bc-4d1a-f9ae-08d5aaadbe18 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2018 13:09:13.4733 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d2cb1677-b9bc-4d1a-f9ae-08d5aaadbe18 X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3181 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_fip.c | 1 + drivers/scsi/qedf/qedf_main.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/scsi/qedf/qedf_fip.c b/drivers/scsi/qedf/qedf_fip.c index 773558fc0697..aef199c12fb4 100644 --- a/drivers/scsi/qedf/qedf_fip.c +++ b/drivers/scsi/qedf/qedf_fip.c @@ -181,6 +181,7 @@ void qedf_fip_recv(struct qedf_ctx *qedf, struct sk_buff *skb) QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_DISC, "Dropping CVL since FCF has not been selected " "yet."); + kfree_skb(skb); return; } diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index e14b402f25d5..8dcacc5b5f60 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -2190,6 +2190,7 @@ static void qedf_recv_frame(struct qedf_ctx *qedf, if (ntoh24(&dest_mac[3]) != ntoh24(fh->fh_d_id)) { QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_LL2, "FC frame d_id mismatch with MAC %pM.\n", dest_mac); + kfree_skb(skb); return; }