diff mbox

[RFC] qedf: qedf_dcbx_no_wait can be static

Message ID 20180427014743.GA56782@cairo (mailing list archive)
State Accepted
Headers show

Commit Message

kernel test robot April 27, 2018, 1:47 a.m. UTC 
Fixes: d9867ecbae88 ("qedf: Add dcbx_not_wait module parameter so we won't wait for DCBX convergence to start discovery.")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 qedf_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dupuis, Chad April 27, 2018, 1:28 p.m. UTC | #1 
On Thu, 26 Apr 2018, 9:47pm, kbuild test robot wrote:

> 
> Fixes: d9867ecbae88 ("qedf: Add dcbx_not_wait module parameter so we won't wait for DCBX convergence to start discovery.")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  qedf_main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
> index 8df151e..b96c928 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -89,7 +89,7 @@ module_param_named(retry_delay, qedf_retry_delay, bool, S_IRUGO | S_IWUSR);
>  MODULE_PARM_DESC(retry_delay, " Enable/disable handling of FCP_RSP IU retry "
>  	"delay handling (default off).");
>  
> -bool qedf_dcbx_no_wait;
> +static bool qedf_dcbx_no_wait;
>  module_param_named(dcbx_no_wait, qedf_dcbx_no_wait, bool, S_IRUGO | S_IWUSR);
>  MODULE_PARM_DESC(dcbx_no_wait, " Do not wait for DCBX convergence to start "
>  	"sending FIP VLAN requests on link up (Default: off).");
> 

Acked-by: Chad Dupuis <chad.dupuis@cavium.com>
diff mbox

Patch

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index 8df151e..b96c928 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -89,7 +89,7 @@  module_param_named(retry_delay, qedf_retry_delay, bool, S_IRUGO | S_IWUSR);
 MODULE_PARM_DESC(retry_delay, " Enable/disable handling of FCP_RSP IU retry "
 	"delay handling (default off).");
 
-bool qedf_dcbx_no_wait;
+static bool qedf_dcbx_no_wait;
 module_param_named(dcbx_no_wait, qedf_dcbx_no_wait, bool, S_IRUGO | S_IWUSR);
 MODULE_PARM_DESC(dcbx_no_wait, " Do not wait for DCBX convergence to start "
 	"sending FIP VLAN requests on link up (Default: off).");