diff mbox

scsi: megaraid: silence a static checker bug

Message ID 20180503105432.GB5315@mwanda (mailing list archive)
State Accepted
Headers show

Commit Message

Dan Carpenter May 3, 2018, 10:54 a.m. UTC 
If we had more than 32 megaraid cards then it would cause memory
corruption.  That's not likely, of course, but it's handy to enforce it
and make the static checker happy.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Martin K. Petersen May 8, 2018, 5:29 a.m. UTC | #1 
Dan,

> If we had more than 32 megaraid cards then it would cause memory
> corruption.  That's not likely, of course, but it's handy to enforce it
> and make the static checker happy.

Applied to 4.18/scsi-queue. Thanks!
diff mbox

Patch

diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index 7195cff51d4c..9b6f5d024dba 100644
--- a/drivers/scsi/megaraid.c
+++ b/drivers/scsi/megaraid.c
@@ -4199,6 +4199,9 @@  megaraid_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
 	int irq, i, j;
 	int error = -ENODEV;
 
+	if (hba_count >= MAX_CONTROLLERS)
+		goto out;
+
 	if (pci_enable_device(pdev))
 		goto out;
 	pci_set_master(pdev);