diff mbox

aacraid: remove bogus GFP_DMA32 specifies

Message ID 20180530090959.26798-1-hch@lst.de (mailing list archive)
State Accepted
Headers show

Commit Message

Christoph Hellwig May 30, 2018, 9:09 a.m. UTC 
For one GFP_DMA32 does not actually work with kmalloc, as we only
have GFP_DMA and GFP_KERNEL caches, but not GFP_DMA32.  Second the
memory is mapped using the proper DMA API anyway, which would include
proper bounce buffering if needed by the device.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/scsi/aacraid/commctrl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Johannes Thumshirn May 30, 2018, 9:24 a.m. UTC | #1 
Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Martin K. Petersen June 6, 2018, 1:16 a.m. UTC | #2 
Christoph,

> For one GFP_DMA32 does not actually work with kmalloc, as we only
> have GFP_DMA and GFP_KERNEL caches, but not GFP_DMA32.  Second the
> memory is mapped using the proper DMA API anyway, which would include
> proper bounce buffering if needed by the device.

Applied to 4.18/scsi-fixes. Thanks!
diff mbox

Patch

diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c
index a2b3430072c7..25f6600d6c09 100644
--- a/drivers/scsi/aacraid/commctrl.c
+++ b/drivers/scsi/aacraid/commctrl.c
@@ -845,7 +845,7 @@  static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg)
 					rcode = -EINVAL;
 					goto cleanup;
 				}
-				p = kmalloc(sg_count[i], GFP_KERNEL|GFP_DMA32);
+				p = kmalloc(sg_count[i], GFP_KERNEL);
 				if (!p) {
 					dprintk((KERN_DEBUG"aacraid: Could not allocate SG buffer - size = %d buffer number %d of %d\n",
 						sg_count[i], i, usg->count));
@@ -886,7 +886,7 @@  static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg)
 					rcode = -EINVAL;
 					goto cleanup;
 				}
-				p = kmalloc(sg_count[i], GFP_KERNEL|GFP_DMA32);
+				p = kmalloc(sg_count[i], GFP_KERNEL);
 				if (!p) {
 					dprintk((KERN_DEBUG"aacraid: Could not allocate SG buffer - size = %d buffer number %d of %d\n",
 					  sg_count[i], i, upsg->count));