From patchwork Mon Jul 2 12:56:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Thumshirn X-Patchwork-Id: 10501327 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3866C6028F for ; Mon, 2 Jul 2018 12:57:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2796F287B6 for ; Mon, 2 Jul 2018 12:57:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1BE54287BF; Mon, 2 Jul 2018 12:57:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B900A287BD for ; Mon, 2 Jul 2018 12:57:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752622AbeGBM47 (ORCPT ); Mon, 2 Jul 2018 08:56:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:37218 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752203AbeGBM4z (ORCPT ); Mon, 2 Jul 2018 08:56:55 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B0A60AD1B; Mon, 2 Jul 2018 12:56:53 +0000 (UTC) Date: Mon, 2 Jul 2018 14:56:52 +0200 From: Johannes Thumshirn To: Christoph Hellwig Cc: Ming Lei , James Bottomley , linux-scsi@vger.kernel.org, "Martin K . Petersen" , linux-block@vger.kernel.org, Douglas Gilbert , Bart Van Assche , Jens Axboe , Omar Sandoval Subject: Re: [PATCH] scsi: scsi_debug: introduce module parameter of 'use_blk_mq' Message-ID: <20180702125652.jxjcig63xvljfqow@linux-x5ow.site> References: <20180702050642.26265-1-ming.lei@redhat.com> <20180702125422.GA600@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180702125422.GA600@infradead.org> User-Agent: NeoMutt/20170912 (1.9.0) Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Jul 02, 2018 at 05:54:22AM -0700, Christoph Hellwig wrote: > On Mon, Jul 02, 2018 at 01:06:42PM +0800, Ming Lei wrote: > > With the introduced module parameter of 'use_blk_mq', it is easy > > to switch between 'blk_mq' and 'non_blk_mq' by reloading scsi_debug > > module, so that we can test scsi_mq/blk_mq related regressions easily. > > No. We should not make a per driver choice. Btw, wouldn't it be time for: again and see how we've improved in the last year and a half? Johannes diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 35c909bbf8ba..bd115bab162e 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -49,6 +49,7 @@ config SCSI_NETLINK config SCSI_MQ_DEFAULT bool "SCSI: use blk-mq I/O path by default" + default y depends on SCSI ---help--- This option enables the new blk-mq based I/O path for SCSI