From patchwork Wed Jul 18 21:29:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10533327 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 03C10600F4 for ; Wed, 18 Jul 2018 21:33:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E6ADF29BDA for ; Wed, 18 Jul 2018 21:33:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D966929BE4; Wed, 18 Jul 2018 21:33:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6B7FE29BDA for ; Wed, 18 Jul 2018 21:33:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729251AbeGRWMw (ORCPT ); Wed, 18 Jul 2018 18:12:52 -0400 Received: from mail-sn1nam01on0088.outbound.protection.outlook.com ([104.47.32.88]:33870 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730003AbeGRWMv (ORCPT ); Wed, 18 Jul 2018 18:12:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Or+p1ZeMdAV7Ca5j/t+jsFNl1yHfGizX70FgFmRGWNI=; b=hhcqkwrF+ccnk9hJxb4y5/F/IphaxLCe0rY1bWEbNB3B25Mgp3vW4//UyLwls+blX/5aban5DlaJRqYpesICsT7GqU2hmNrB++Q6s/r3I7JMed3u4JhZkPo8SUuvVSSTppIWT3+TUxSmZ9CQyijL14oo419sHUJoULCwNicG7BA= Received: from CO2PR07CA0046.namprd07.prod.outlook.com (2603:10b6:100::14) by CY1PR0701MB1386.namprd07.prod.outlook.com (2a01:111:e400:4c1b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.21; Wed, 18 Jul 2018 21:30:09 +0000 Received: from BY2NAM05FT008.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e52::208) by CO2PR07CA0046.outlook.office365.com (2603:10b6:100::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.973.16 via Frontend Transport; Wed, 18 Jul 2018 21:30:09 +0000 Authentication-Results: spf=pass (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=cavium.com; Received-SPF: Pass (protection.outlook.com: domain of cavium.com designates 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BY2NAM05FT008.mail.protection.outlook.com (10.152.100.145) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.995.0 via Frontend Transport; Wed, 18 Jul 2018 21:30:09 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 18 Jul 2018 14:29:57 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id w6ILTv7O013505; Wed, 18 Jul 2018 14:29:57 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id w6ILTvsF013504; Wed, 18 Jul 2018 14:29:57 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH 5/5] qla2xxx: Return error when TMF returns Date: Wed, 18 Jul 2018 14:29:55 -0700 Message-ID: <20180718212955.13450-6-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180718212955.13450-1-himanshu.madhani@cavium.com> References: <20180718212955.13450-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(346002)(376002)(396003)(136003)(2980300002)(438002)(199004)(189003)(316002)(87636003)(476003)(11346002)(51416003)(16586007)(110136005)(81166006)(72206003)(106002)(81156014)(42186006)(76176011)(48376002)(2906002)(36756003)(8936002)(4326008)(106466001)(2616005)(126002)(478600001)(8676002)(54906003)(186003)(80596001)(305945005)(486006)(26005)(44832011)(69596002)(86362001)(5660300001)(1076002)(575784001)(47776003)(50226002)(50466002)(446003)(336012)(356003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1386; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Pass; LANG:en; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; BY2NAM05FT008; 1:Pc4aDdMYfIpfXgWhC0unM7fShxB+EKqcamY09uCHSko9BLXDnVTBcpD5279Ld0rruUQrxOCdEnGgPKjaqX2IND1lIlfNaf3Uv86yrc758ZA/QR1ABSuBUByuj1yq2tZ9 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e1b82dc2-faf4-4ef7-f474-08d5ecf5a340 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600067)(711020)(4608076)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060); SRVR:CY1PR0701MB1386; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1386; 3:jwFRMSqmj/GhKyvZKXW9Y6hunlEtXMrwTCCaa5nROMAfoN0TFAA27k1lNucIVQfof8wSlly8h/1CKxPQDNjZHfwhsheGePg+RCC6iSs2wNVTlGVx28xzNBYtj1Nw6Xa5BLVVm2HjgM+2uvTvGpik/3aorsjKNGuUomoRANjG0wy1w8pmbf7SEOgPCg8/fPmr5ofE1NvPS7M8M6k+v/sFDfs2UVy45PVM38nIRSR6Eg4Uxo7FDa7Az/p9V2k0L3UY+6HJvB9z8turJesCAz+AeLtHlNvVu6UWz9gm2BZheLR2Rx+cGPUScvboeyI7zyx/Yq8WsFVLoRbTSFJpPZrkjVrkWuLHMTOylmnfIVsSt/4=; 25:23VxSpscWxenW4MweCS9Qnqbl9q4aRN+XBqIoIpIKqD4TPRz/wMgazRsCV7POgFZgtMCLKr1l8bF2EUvHnXoUxJryfWiQtfwLmPsY+K5wwxqpK5QcSGa27+V3b3dLgri07o3MhnCwHaAYjXv/fAUUnFgdZLbNNbswFJ0NK1N3zZ+gA8iRbA0P/ea4Q0QEWtLqbI4ic2dpi0Y7zey+qdcgDAy2On+8YIupbdZf20t+QSJ9fCJrQJvXlUVYnaEVdFACHLCbXldzoFasjEEuuU3osRLKIWhOjKWrKJoWRogqtcOBzRxkPhdM7p7num48FmpAbxQJsfYrLAaMl/HIN3B8g== X-MS-TrafficTypeDiagnostic: CY1PR0701MB1386: X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1386; 31:RTJVg8dhUy/coa8M84JG6e4QO2TPbor/PGtqnWSLqcBcpJQ8TkwlHES6e3SCCAfgHtZ7e0mpvvbv7hzSHSw3vzCori8m0sR6F2xPqen5LLbrWqIP9qThrPsnGMYF6W+6YyLrDlHm/BOfXJLBUmMU12ez2ohN/Fjs/WDwe7nQ3+i7kH2TpVTdtwu8Te53GUx8bQCvvcjNkPZwjse/pkYvd62blGD5KrQgtaxjGvidl5s=; 20:jR68iyZwa2j0CF1SeOzaIRHF3mDpTkZCqwsShb/W+Th5nGTdDKwxfJpl6JRbpKMj+TLkLeqdMKD0Kk0EKOoLX/3NeFv5cChfdw4K8d/kVQMHY6PC39AtKmJnIm6bvXAoLDu2gmOU/MbCFQvJmi6HAHQZmLEoQg/ZfSU7Wqw8DnLV4bSp6PpJ59EjKk2cKhmWZ02+vnmD92jR/LbyP6K1I8poRQO0kkkgOrgBaIHPm71KIsSdAqy3kDi9QHJBo2EuXzhd25avRZR2otB/gz/pn+dVI8ikRiA3y8FkenwPAwmLe9qnt1+yjHSlr39vymRWHqDUr/9dfm1ayCxEl8YzyGGv/QmdObnDFq6Y+iiU6zWxaRXHVIG9LUHc+OX8PYerDcctYdGmn/L1Gsfh02NrBQJMncNzmuM92NtPdMnPrmaYfVmHAYVcdz0a5QwYY6cCuQL6b36Y4RMt9OTgBwFCGniZUsjnarqPUidaIUayBDm6DFj7LSXUeytCgOEY4tMB X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231311)(944501410)(52105095)(10201501046)(93006095)(93004095)(149027)(150027)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:CY1PR0701MB1386; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0701MB1386; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1386; 4:V2kYq4eJx8Ak2xTT0gBs4GcrLAV0raNgU2pgQiDol2Rr+X9alB8VoVM7VeIJ/jyHzO9Dq0Fjk7OoBwcsO8zUt3vMpDqPUDllIQPpcSLt2izroZU7qVj82mQWaNXKDtKS7Dt3oPIzI6kqGr0JK0oTU2b3YrxzdKSNh/foSUOq3Sw+5dOqMswxTKIT1YuAA96XJL1c96yVshoN6oSFMeSpMCrvlAqr4A/9GWQXqFBCkhSW3Ar3JInTL0utMkSVqdtDk7+GF6FnfBGp8m7ELYepRksjt0Pd0Ivr91eJmM4nFAgOu3erl2Efj6eM+TifwZ0L X-Forefront-PRVS: 0737B96801 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1386; 23:rw6Y0gd3zi6SdLBD9zcz6NYS+ItnCyNoYAlanlc?= =?us-ascii?Q?dil3uGfrsEustIp2d8EIrKqS70BkNOQw7g1PAX/p5gJcQAU06a1JlSPp8PaQ?= =?us-ascii?Q?e+pWfOCleJq7Jb4UU79YvZwuwDhu6mn5SHWTvkQVeCNN4ES5XB7Kl/ODun8I?= =?us-ascii?Q?xs9WJkyxOuG6Don+UCM2uO2hRJ5aOuARNtP2RpXHW+gQMZBBozbtkp3uoxkK?= =?us-ascii?Q?cnMQFi+s+RT19AlZuz4btW0dJ1oxA1rEI7mstXb7H3lfyWPSrHKKWW5MAIrM?= =?us-ascii?Q?q6U8KbgGQ8aOGOdFKP3R11BApASiBWMEXCana8/eDrWgksDP671Beb2iuDF9?= =?us-ascii?Q?w6aN9fIYTP+HA3ZAu8jtTacRjGCTi8dPTNLyQ95KF0IXdMqPRZ/0+UCaEm/a?= =?us-ascii?Q?bIfsVgpbSoWfPEy8WooWPff8eKc/HqX5aHFPBjaFVf1bTX7m0AEmwsVZvq/t?= =?us-ascii?Q?FNxeD/yhDU6CvP++9m8Zhxagav7cUsWKN2alQJV+QsYQsiZRj2gEhujapQYq?= =?us-ascii?Q?HXOrRgDZljKygYSOqlMFJs42ih0OFran+j0irt6pFjT/pO934IIo+c3D6hdO?= =?us-ascii?Q?/y1HOpBVvK/Ho7VO6f+knpJk6dbJ+kAaQ1rwtOkkksOqEi/jod8Ubiq/QeUo?= =?us-ascii?Q?Erlj4Mi0k4aymMJMIuK9D7ho0oVOt8+IF25M/dP5YGVWDUimlq8JPvlWdLEy?= =?us-ascii?Q?9w8XLEmw2cjQU8dEmt/cyHQwaoucPbzyX3wiJc9rGlj8aWmDTPAhxW+MjYsp?= =?us-ascii?Q?n8b0YuM+IHYnsxVO+UJV7BJFm/rEAFGAhclqAf5MMsckBfz3uiM+gv/Dpv3z?= =?us-ascii?Q?446TIk+glS7bZlCCKT/TuX6SLbC0V9Mlfef7fnWQ2qE3iLKoD70zHkaWSfky?= =?us-ascii?Q?YQomn357wKiajoXw1HExh90YZgKyvuRNdzDYz5c1OYO4KWRa9aRQioKQHsD9?= =?us-ascii?Q?1OzHmysPRB7AUAjCq8406cA6KlIefrArYgFFoZ5CXGebZKTbMq+rDQq6BCFw?= =?us-ascii?Q?/mPcF9aWdB+StJffIscMe7/PSI6sdKTtL413ckigK2m8m2eY7XA/p3wZN7lz?= =?us-ascii?Q?QfyqE3GvnRuw0nMJmb6tIXxl3VpLsfDFQbL4NCf/adLXy886nRvK/rDRADTW?= =?us-ascii?Q?qW4Fxs0aFm/U=3D?= X-Microsoft-Antispam-Message-Info: UX4PjdsN9k/It521kTUcws0sZYOScrAah9Qw5ID7wPZf3zlpKXide+Ac01vt+tcFRQAOaBIM0nVmJzrZNem5hUUfW8CTX8f+SCHvj+u8zaYqV4JQBrqcnm9eaUsbkwEgmXerYKxg2+R4xGnhiyBg8ADrjpvOo//UmEd2/8m3Fp5z3iRpUA8piJUXACG2mFXVELlpYFw+Drs/ltEVVlwsslP5X5B7uBBbfhJUhR8k+7lG/8PHJsmieHS9OxQ2NHhcVINF87+mVPZ5EMMT4vKURc5IEcFqr0M4eqNJoz/B0QhDidKdzwHV7qQZzaW/6WVaLx//JfyGuUcaLppgiq336SWkkxa+wTMBcdEDuiXhMrc= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1386; 6:kOztVcSTzj0t5lJ0QIKLrlHcj+wsSmZebo52dbQh+SXZoqD/7jC7avW76SPOkgRfRzzwFK9jEnS5wZwxuhadwpoVQKyH8vQ/TmpclvY9RPBWRP9nlcFQ4hkDMlPtT61GJiRU5/74VwY41AKW3oXpFQDgScRgWBwjWWaYxMoypRciMtissG2o88yydi0YN3OXpRsZ2w1EU/i1u2vQFICBaeDBnrDMe+vlQ+nkQ/Wd4U3nDm48GuCpsfzzR2xkeEe2ur2wWTjNK4TLVaaaWGa5GpXugjFuCP1Qcoitx9fj6IiJV6H0SSCm1TJU6N67gaiajpgomksrHJXe14Hh5JSHSYj8vtIN2fZ0ki4UEjctaXSgAQzDoeAKRvzr6GbBg9KbEhRDKzUBTw4Ee5TBcF+NJb9bQUb+SXK3KEEu5X8G0YKyxk+M0w4C9bVCAFPELXEXmj66wirNwkVAOKbGqNizGA==; 5:sV5MnngNu+EXKAitiz5ics87XkuNnf3Gg3zVL6Sd6vjkonTi+4NVch5scnq/kS+ygGtzhFiYH4JnIhKcAZCqLo9rulhvcC8eCYtilZJceX1XTYilPDp8YBqKBww0wsQ9mwHm+WNq6+oE5VcIw+kZQIT4DTcOC2WJzE0lyoC8aA8=; 24:hM3nlDsUWAJQsPjmCULkF5FNa2Jv2exGWTSO72R37cDKYrYweNpvgeWLXkDiaH7Dmwz6bHbmAffceFvPKB7utFZ2LWfSVonf5AgmqiHKABU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1386; 7:wimh+6aglkFdmksiWfqnPWcGsg5v9q812qTqpdBM4yY28rOoYpQv0HctV7so8dZe/SUvz4Vn0pQiZNXeEcomaqk6fZxeWMtRZuL/7hQa0Ril6QzpqzfOGZF+QYMPAaIMmpBQT1mDzJifOr+mod25c8Uc0QetbkZ/ykGOYgM8TK35p+JkWRtJso/L1G76OzZmNGyQZVEyKsSr551wfVz4DQtT3e+qt+FIc7SMf8zUxXBllkjO5Dfh48oFJZ1ZvZS/ X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2018 21:30:09.0847 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e1b82dc2-faf4-4ef7-f474-08d5ecf5a340 X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1386 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Anil Gurumurthy Propagate the task management completion status properly to avoid unnecessary waits for commands to complete. Fixes: faef62d13463 ("[SCSI] qla2xxx: Fix Task Management command asynchronous handling") Cc: Signed-off-by: Anil Gurumurthy Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index db0e3279e07a..1b19b954bbae 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -1489,11 +1489,10 @@ qla2x00_async_tm_cmd(fc_port_t *fcport, uint32_t flags, uint32_t lun, wait_for_completion(&tm_iocb->u.tmf.comp); - rval = tm_iocb->u.tmf.comp_status == CS_COMPLETE ? - QLA_SUCCESS : QLA_FUNCTION_FAILED; + rval = tm_iocb->u.tmf.data; - if ((rval != QLA_SUCCESS) || tm_iocb->u.tmf.data) { - ql_dbg(ql_dbg_taskm, vha, 0x8030, + if (rval != QLA_SUCCESS) { + ql_log(ql_log_warn, vha, 0x8030, "TM IOCB failed (%x).\n", rval); }