From patchwork Mon Aug 27 23:48:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengguang Xu X-Patchwork-Id: 10577663 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 320A15A4 for ; Mon, 27 Aug 2018 23:49:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 29869297B8 for ; Mon, 27 Aug 2018 23:49:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1AF76297CE; Mon, 27 Aug 2018 23:49:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C0866297B8 for ; Mon, 27 Aug 2018 23:49:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727101AbeH1DiD (ORCPT ); Mon, 27 Aug 2018 23:38:03 -0400 Received: from mout.gmx.net ([212.227.17.20]:35413 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727058AbeH1DiD (ORCPT ); Mon, 27 Aug 2018 23:38:03 -0400 Received: from localhost.localdomain ([116.30.193.211]) by mail.gmx.com (mrgmx103 [212.227.17.174]) with ESMTPSA (Nemesis) id 0MbOrg-1gB0AQ1pIa-00Iij1; Tue, 28 Aug 2018 01:48:59 +0200 From: Chengguang Xu To: qla2xxx-upstream@qlogic.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, Chengguang Xu Subject: [PATCH] qla2xxx: remove unnecessary condition check Date: Tue, 28 Aug 2018 07:48:49 +0800 Message-Id: <20180827234849.13980-1-cgxu519@gmx.com> X-Mailer: git-send-email 2.17.1 X-Provags-ID: V03:K1:ve82cHdix1woo9PbBRHF9szUAePl579rjwfOt71xpex0aXFZhUO chkX4ziUn87/491q5Ag7+nFSmXSvjTuW08TtkLUFfFCfZNfkQFZ0RKrJizrVn1EKKNWSCtr TxZ13UYu/QEZCuc0Ct5BNRwXJNUO5WqFTi1rtkhU0zzSIhQZ2YogqYcgvwRxhpyhUQfkefN hMa932piiytpChaaIPKrg== X-UI-Out-Filterresults: notjunk:1;V01:K0:nnkgjI7hFno=:LfM2+f2FNZc5jRFwwT0MTB pEnkqeSV0jQ96/67trSGZJhtr/NbiyeW6mMU1qG4aqeZHL6zb4wnmvVLD/k3lg5tUvzGht+jG bbIcelnw2cjJUUwxm0G2EsiaiNh1NXQDsBdvN20m1yESztLgUiehQtlk3YVn1X/YemSNlkVGU Qcm/I4DlGi0zTPoa6/+JAKxpDDQzHb/HBy3mOskFUD9VKgJwJblDegJVgnFRbqe3qH6fAs6WP +EHiTQMXuBDaOvUjH/8IA4aGMqIYXlaXnImZWj6dtop1/WQOfaV6YVWxo9qvwv0+NnqRzFesQ GZcl7tm01q9AfeSQmCz45hZL/AUwOM6eVlC8r4kUCiUwhOsDL4Su7pNGeQIOr1N7J1ChJhqix bUS88Gup5lf876FDJL/rDZtnlO1MganBW25cYtbclWSwiz+1rSsA955oH/XaLbUeynCftCuwS AYtM85gphqNLdUx2w22oUEC815+IL/gRk4PXA8WpRRabQqCrkwuplB5J6rOg9hfyMl7+F38X9 uaxLJF7RJXzLeBPdsuDz9XLHBf9yTiixDmv8JovnM2P75WKJVAhFAA704cxQBjR2oKjAT7H4h lhW+VYSXQGMVhowVffFH74wECGy0lHhYrBQyH/0wVoPqyNlmqJwcssbUf9Q13YYv+r+iqtwzh iqtM0quCKv5hu6k1+NzrxyedMa3m3y8Qj78qyMtLnfQDSmEK4VWAkGYxBUBIb4HN7s0aNoxsb aV3+OYXKovAnJN2rvzeBb3bQNerkcseqxriAbiHLGwX3aBUfYKHtNdy7PWE= Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP kmem_cache_destroy() can handle NULL pointer correctly, so there is no need to check NULL pointer before calling kmem_cache_destroy(). Signed-off-by: Chengguang Xu --- drivers/scsi/qla2xxx/qla_os.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 42b8f0d3e580..961c745532cf 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -6999,8 +6999,7 @@ qla2x00_module_exit(void) qla2x00_release_firmware(); kmem_cache_destroy(srb_cachep); qlt_exit(); - if (ctx_cachep) - kmem_cache_destroy(ctx_cachep); + kmem_cache_destroy(ctx_cachep); fc_release_transport(qla2xxx_transport_template); fc_release_transport(qla2xxx_transport_vport_template); }