From patchwork Mon Aug 27 23:50:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengguang Xu X-Patchwork-Id: 10577665 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D2A915A4 for ; Mon, 27 Aug 2018 23:50:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D536C29A22 for ; Mon, 27 Aug 2018 23:50:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C986E29B76; Mon, 27 Aug 2018 23:50:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6742A29A52 for ; Mon, 27 Aug 2018 23:50:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727101AbeH1DjU (ORCPT ); Mon, 27 Aug 2018 23:39:20 -0400 Received: from mout.gmx.net ([212.227.15.18]:59133 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727050AbeH1DjU (ORCPT ); Mon, 27 Aug 2018 23:39:20 -0400 Received: from localhost.localdomain ([116.30.193.211]) by mail.gmx.com (mrgmx002 [212.227.17.184]) with ESMTPSA (Nemesis) id 0LpL4H-1fOh1I2i85-00f8oh; Tue, 28 Aug 2018 01:50:18 +0200 From: Chengguang Xu To: jth@kernel.org, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, Chengguang Xu Subject: [PATCH] libfc: remove unnecessary condition check Date: Tue, 28 Aug 2018 07:50:08 +0800 Message-Id: <20180827235008.14051-1-cgxu519@gmx.com> X-Mailer: git-send-email 2.17.1 X-Provags-ID: V03:K1:EBrP2Ok/jvOAkPlAukMvbogvHi5NNxfsp2NY8eHdiQut9xGV2ib 0DwdXI+K698/wrvsnp8lst18yrEz0o3kYvsEpfnTans7UQRJKgZm5dgPol/+fWexYAsVHE1 IqEojubpHnAjQiA7VYHWY17MqLFLUR3mS6pLIr7v8MryISmy6VKaRYI0rnGlpg0zO9O7CpQ 2zBsqIASXGlUbbxEBbrFg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Sy21jrkegWo=:ezFQIkMjoXyoe8EyIKlGDg 1txq3cwr8iNojQRosTJtKkd+wljqAaw2bk7Hz+aODp+nff5tLQ4+t2p3tFWYxqB36KmdIhufp 26stmMWeTl7pL1xJQHzKUOARjYOa80plxa+SdnZZJP9zeABwqRFQFvJo3ri6zL+qglGftkVaC GTQ2OuE3rhMQ0GNGMC9dKSdF6Qf3WLC0Q08jiAE+KGPWeD1gT5/FwpdntNz0shaKAmWU+RQpG urCm9htpjYYF6x6I3FkXBIxA8+fY7WuUAlyTweIWz+HssotPNsgaTe7IlliBDTFaHiG+MiGVD uNQiF0bwWJS8ArJ+P7AD8Kk6iWsEknOTWAXE+MZk+DbIIjaoqKioWyBv2ATIVnKWyv+jBRYww y4Q3ZIGAmcuDR7t4Wvttos1vQ52s9ZnCQeHtTpHpk3bJGA9uhaLdwfOWE8ozjI6IH21G2cnFK Jozay6wUxA/ZiS6T9zv0U27SsciyhogUAEGcHs4JlGguEY1CirbYTNxFnBeY0I3+PQdTAJwjd Clc7XKGr2y9k+zBQ4QPdgNBbZiXTi+/6Tat27kP0scxttxliB3Iibu/pALGJbpn951wPLgE2I GxHJfRygCRxHnSM9QuKRo0InYM9py2n0pdJzzX4t5ntvMt9Ki9sEvCnne5C9niAPsFkuU5/Y5 kWjoikWng+Ecn1r5tbU7v9Y6Xyr8at5xXBz/XoYI9XZuU+/TqeWrppf7fY87pQ3Dk8T+UHfDe F3E1jrW7nu6Pw0WPpXzWPpHQFvJ+eLpJR6FxT5JcrmYbV51EHIUgJ5NHs8w= Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP kmem_cache_destroy() can handle NULL pointer correctly, so there is no need to check NULL pointer before calling kmem_cache_destroy() Signed-off-by: Chengguang Xu Acked-by: Johannes Thumshirn --- drivers/scsi/libfc/fc_fcp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c index 4fae253d4f3d..563247def49a 100644 --- a/drivers/scsi/libfc/fc_fcp.c +++ b/drivers/scsi/libfc/fc_fcp.c @@ -2295,8 +2295,7 @@ int fc_setup_fcp(void) void fc_destroy_fcp(void) { - if (scsi_pkt_cachep) - kmem_cache_destroy(scsi_pkt_cachep); + kmem_cache_destroy(scsi_pkt_cachep); } /**