From patchwork Tue Sep 4 21:19:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 10587979 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BE01B920 for ; Tue, 4 Sep 2018 21:19:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AD26E28F76 for ; Tue, 4 Sep 2018 21:19:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A12982A127; Tue, 4 Sep 2018 21:19:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 31BA028F76 for ; Tue, 4 Sep 2018 21:19:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727438AbeIEBq1 (ORCPT ); Tue, 4 Sep 2018 21:46:27 -0400 Received: from mail-co1nam03on0074.outbound.protection.outlook.com ([104.47.40.74]:36476 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727320AbeIEBq0 (ORCPT ); Tue, 4 Sep 2018 21:46:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OYdwcQ8p7FnNssGdJRfPPu/PVUHTe6fQE0fzEhoniAo=; b=V9+kdTHzv5Z7nYJO5m4XLNElTuOIgW2xUhoXsXFO8ErJrReppORU+ZNukHlEQkR8bK6h8RzMGJeBjnS6ItIheXqdC8Pmr5IOsnYEmplRrIp1tTaz6Ia2WSnaoAN4pTnrrFzOgSwCpWnh+lz1woAdDf3hqN7vqGDd2oZOwI4Cc10= Received: from DM5PR07CA0082.namprd07.prod.outlook.com (2603:10b6:4:ad::47) by SN6PR07MB4399.namprd07.prod.outlook.com (2603:10b6:805:58::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1101.18; Tue, 4 Sep 2018 21:19:29 +0000 Received: from CO1NAM05FT006.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e50::209) by DM5PR07CA0082.outlook.office365.com (2603:10b6:4:ad::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1101.16 via Frontend Transport; Tue, 4 Sep 2018 21:19:29 +0000 Authentication-Results: spf=pass (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=cavium.com; Received-SPF: Pass (protection.outlook.com: domain of cavium.com designates 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by CO1NAM05FT006.mail.protection.outlook.com (10.152.96.111) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.1143.1 via Frontend Transport; Tue, 4 Sep 2018 21:19:29 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Tue, 4 Sep 2018 14:19:20 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id w84LJL7o031974; Tue, 4 Sep 2018 14:19:21 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id w84LJLrH031973; Tue, 4 Sep 2018 14:19:21 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH 03/13] qla2xxx: Add appropriate debug info for invalid RX_ID Date: Tue, 4 Sep 2018 14:19:11 -0700 Message-ID: <20180904211921.31927-4-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180904211921.31927-1-himanshu.madhani@cavium.com> References: <20180904211921.31927-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(39850400004)(346002)(396003)(136003)(376002)(2980300002)(438002)(189003)(199004)(2906002)(48376002)(14444005)(76176011)(186003)(4326008)(36756003)(51416003)(26005)(6666003)(47776003)(8676002)(356003)(50466002)(1076002)(5660300001)(476003)(126002)(486006)(50226002)(305945005)(72206003)(575784001)(11346002)(446003)(2616005)(87636003)(44832011)(478600001)(86362001)(106002)(42186006)(316002)(110136005)(54906003)(106466001)(69596002)(16586007)(81156014)(336012)(8936002)(80596001)(81166006);DIR:OUT;SFP:1101;SCL:1;SRVR:SN6PR07MB4399;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Pass;LANG:en;PTR:50-232-66-26-static.hfc.comcastbusiness.net;MX:1;A:1; X-Microsoft-Exchange-Diagnostics: 1;CO1NAM05FT006;1:sjMWkarqU1dxeUSxDSMyNzXqcFB0VZxIfqZcyq5W0xjzksNP06mgQiSliPnPMn6QKuGsW01y5Xy9u71Up6BkLWmrbLKVHRN/RgNcnLsndjKh7AazBVOZse+v0e1YxKQ3 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 251e7f5f-4c32-4a30-a7a1-08d612ac19b8 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(4608076)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060);SRVR:SN6PR07MB4399; X-Microsoft-Exchange-Diagnostics: 1;SN6PR07MB4399;3:X+43zHzarBWGx4Ix5St6qnKxK30JK8ngmZ7WPjoI61mtyOKhf9LVRpQ1O2iGWXCtAukmy7IAK6lAfZx7sD4H4/uhIbMDzo1DHJaWZ/xv+CcqPx0UvjXTbXxR46s8Tp9ovUdNLyOLVjsKgfUDJxikPHGw6KdgeMA+26Xga6giKkjW0zc9fm7EqKropvk5IR472hh5d5gcemwJT+nP/DtTjp+72xNNExrqoBZ/SdeDtq3mR14wgShKdjoy4CY2foC7u6u8C5ys/IqnZVQ9+UlOovrfecz15rezo6lliIgE8rwFqHsQ9vb51L5ucR/CPNSRgyktmfJW75pfnWCOe5EarydiCBGCuAS+EcxektGPQx8=;25:JjFv83WEeA85EZe/9mUQyjkxK/E9dsRYiVxhBwb3eWiEd+Fg45rhNrT97Jk0zUpLIpYLTc09bOQeIO28YWcSWRAziZJw8FzZHRYZlUlX3/EoPMVtmNRM9hvyBDLd5xctz+zSbUZMW7Se/xShWIIHz3V4wx16AhBGTsfyVgJy/LcD0bznTQrOSMnZ1BxXCAoCx/2Rf1mTozpX7MHXvUa9DuNHBOoEHZNiKHYFfANpTCeL4aPpqEvic1c/LBtlOASbF6lt/zD52OpX5K8G6lpj0V+e1XvMiwFWLS7Pco+rYdbKmAtjitUw5h/RUow2mvoQP8PI1x02uUakrvdScsSAzw== X-MS-TrafficTypeDiagnostic: SN6PR07MB4399: X-Microsoft-Exchange-Diagnostics: 1;SN6PR07MB4399;31:4p9SvORAVOGBCCLtjARSjPaDSt1FDuFZnmI+xo3hCsdoi5dKOXW9BV1ejEN4Q4n8Lu29vWIhNtq0/roZLHgGfmho1m97f5GqNkAXf1DPZVm6BJydN7wiWvTLCVW/gQs7qOp1i3AKFQ74PC/Ysj8El8dGPGHB2unjgSjH+NEyMndedNfmFCedgLfrcLLBwpF6rA8qgX9sa4iGG9+kC6+XvnMkDIkZnGt5Um62vj1tm8I=;20:BF6tMMMKnN0w596z8YEAweONjHdj0bazKsf/pMPU7MzVZqJFLFXtwwVJ8egpkeL0oPudl7a8EXD9RwC83yv/stgf0GXgldSsqatxDWj5qEolwEzRQ8xJpLaYsXDkehDV8JF2gNA6jz8O3AVc6RaIDjnw49zYnivNUzcTWEaBLWqZvKPnPcpUeiJBSxlGv4Zbme/TGKQ/GNyLCatkwr2cP/ANXhsSIwBLprZY3ww0Heat2yl5fox1Q3HhbTvySC7Hw5/ITv3fGm63MJFg+AG3CQKycRlzQeL5MilMqKrh/MGUyUCwYTo/THTeCiiQ3zyQcmjlJolS6EAQyI9dJmmQTvD4KYmzR1/78ibNh1sZjL0aBf6JtkSMeQ4pwySlSkOTHzwiT4SiTkzhp15JNTkFMY30IP4LKdjlNI6XNP9E5HqYIMzBoX46cBau7f2dlLKPI77my25jJklZuZWQYdwfcIAPqy0dM8ox73Avpjr+M1mvGQq5oWNJHfNo0xrCLjrk X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231311)(944501410)(52105095)(93006095)(93004095)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699016);SRVR:SN6PR07MB4399;BCL:0;PCL:0;RULEID:;SRVR:SN6PR07MB4399; X-Microsoft-Exchange-Diagnostics: 1;SN6PR07MB4399;4:YWm4jrdcdX8H6MrBbJe4EFqQKNm/c5LbhARM7oGRdlFdQFM7lYYIvV6rsMD3k2ezO3pCZCXAjyjHq+eojJQ/2kaOAwrf0uq4Pm9laLFDLMVkdLd2hcdBFucs1tW763pAfA5usRCCTFXFlEr4C1DGMDpvc5kSlqwnS1lj+bRdXQVL4Q7/eWhBSvDjAQm/0M6uL+Z2QYAz73KtzxpJsFiCJc/v7bh71wQoK0rN9owfGRF5Ad61qaoMU0gcx3XCTnTElstzS03juMkRU3BKpNZCgA== X-Forefront-PRVS: 0785459C39 X-Microsoft-Exchange-Diagnostics: 1;SN6PR07MB4399;23:65901JU3sOgZk+zr4YOUwbm9Bz8YckcjT5IRAcEGgW/cUWjBKJfwQQDzDTK9pprFgUVG3HHo5ZuCVYXE6mrEbZbRXb7RP7ZajwcMppQYW8e4dLKrS9mmTb+QFilCdtstweSYVAOsxoBbE+MviWh/eoGrVKeLoA4rSNdi6cm+zGNzViiCaRIy5ERT5oRhiPVIMdM+hlzL5K49we4PPSSKz3j3mhN7GTc9ZRogrI3/gkU7axMshd8uiLfBHabf5YV0YpfGV9tkLNb04+YM76cB3iytl7eFklq2i2GoFaXMF9wJXe8NL7amnAYxm+PdX4/cqOSqM4aFZloFqpFTZ/QNq4m27aWG5u11w5gYf2joHVwAUNdK2lMYc9wOrmrYR+8SiQr9L6BqSTlN41D4PSUUqohLmyxxUY7IVUTgX412OxQ1V/6jwxpWU+xkzVT38v22CoijRQbIEYshG1pFilPkikNIQ3yu4EG0aEEDiPPOx8ts+AEDS4a2XVFnFBZHoIR5ggSDmZIjKqQHFgm2yTU0Jn0HaPUpVFJ8JVPyWfx3ZipaDZ9Ro801Umn/Pi8UvK4trAuBLyIzs4/1cM2lRLWNM1fUWZEkzfDME3QeiisZHe/xmZ/t7bgbQtHLWBM//tGFZEdx96s6zb6cXH2Zf3JI+Bg+3UeBdxX0s4o5wSXiIBJtnIj/R5Xwa7h9aC6RyTT0Ht9GY454SFF29xcwkvmc89eyexhY3cRhgxVSvoE+Ih8kBZBCDN9FB+KXR2xMOODJwd+BFGf/ko7++lKxK4Jn7LEuhNhB7ntf8LVgaMx0zjo3C5gUWhmTMMcj5i3qzVR4N6jfUStKQYkbTriMiyW4RXyo7GlRnEMmGyQlaHEF87/NE+05uqsKWT/rxSraZuHoywOf5VCo5xQx1mLFM4/xk2xANbUc44mdF+21f/2hq3LwetlNV/u6Q4dcv0ySLt/5SZFDM42kweyKjz7D5S78ReYeekqJcqLpZE1jpRP7ciBbXIaka95axUOb2nEsYSpn3LZNetrdr9V1LstMgQUNLTCN9gVAYLFzVuthQwYWKyViwzS4gNaXboIMZ2dojuGPoiqkp7Z68FE6VkJJ/uCJnyZDwx5iZh1VVazSlQMWFOT7uuWL1YqnkMscnanVbozeIDqMz0Zm0eJE6DXIivtcvA== X-Microsoft-Antispam-Message-Info: A5+T4NM2njXz+L6imzaD5B4dqT9N+OERHp2lDiMMV/bfgOTvWP73F6LACC9PTIKwaaaWOjBFG6JCTV2xzD/yctUHvCkZnd0JymuEIpyloK2tpdyUDhBk8igLYAk5uu8XYcYjOseVRRz6+tEwNps5llvq8f9jX5wDwNOI644T9HxiskYxKIHm3x5pGbAG7WPTsr6nOx5e+IfSqAV5NAuIgegWPVS1/f3IHZnby7uyt/vXo7f56XsaFlfbtUmLOm+zxZNQ5JkOyPQvQv+MoI4yygwWWmUjj6GxMKJ7heede8O2DyMsOC7T0pFEmZRC+PIQpd9Zr9BPo52MKHGaCZyObSAJPgYkVKxQ+dHCgn57vQ8= X-Microsoft-Exchange-Diagnostics: 1;SN6PR07MB4399;6:0kxKgW/1QFkLQg8rKP0MsKv/ymxGHeUXA6RgncYLXeskSv0iTC0UiIXoBZ/i1TAmu6f1oFBIA37TDIiDu/wJVVMW3lMiTp359mOqb7lsf8EQwUSE7iggdIhYBa7dzpxrqzH9mLU3H8BztUjnQUKJ/gD9llVt5k0vQvr80EPCuaPMAQSJzHCHbmVYA/y32bUEUaqALFvBk7vNTtqdnDDoMCZLmINgLH9s1w0heTPXi0kNTk+ohtrmFHCRDXTyEnpjtvPCQ0FkRIZrg4/rJsyFI/R5hcEn1knVmrrwdqNXoWIbW/TYCsNvdT+7O2QFTaI9K4e3cT9j/iXI5HEJy+QZnbonczbVG/Q5N95xqbuSXxHkVoCk26I878PwscD9ya20O5cER+7YOH/i0SF2DTDS/I2n4xpsj/gutHHbG1rIyh2NPhDo/vpAEdMqbzs6sQDLe6sc+SkvWhf3Vpy4SCe+QA==;5:u20l69O8KfJjdo769S4bLaujRdH3zUqTBQRk9KniXxRY1bpR1+sFdq/nUca/ulW2IepDqpb29VYoqM0d1j0EEUbk1u4KVSdat5+5seICCBALfb4Jwe697gexaVLko4M4RQUYtGtxcqjY4UJ9LTjrDgpFozC6qlEZv1PmdogSae4=;7:DEowimfJeRhagmDiIlcdXHi5OnbAbNGTDcFSCIERxqOK+qnYtPycbgB1smr3WAI382fU8IulphqdZTut6s0cIgddzwwBe8lBugoVzZZPBzYD565ltmUioKqKbDyMW2cX/43DPZZS/ZKPllTnyTlWQgBAoZmCfu6pbfCS/Z1Rk+fM04zB1XKfKBOY2rIael3dyv2ZRNrlAvp2rxlaLB2qB1VrMzxJNDtL79U/qO7PxQdogPeLdhHMpDgzQ7UglqdR SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2018 21:19:29.2054 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 251e7f5f-4c32-4a30-a7a1-08d612ac19b8 X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194;Ip=[50.232.66.26];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4399 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran When driver detect CTIO_INVALID_RX_ID status for CTIO, print message with correct information to help with debugging. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 12 +++++++++++- drivers/scsi/qla2xxx/qla_target.h | 1 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 29fbb0aad489..3796525aec71 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -3291,6 +3291,7 @@ int qlt_xmit_response(struct qla_tgt_cmd *cmd, int xmit_type, cmd->state = QLA_TGT_STATE_PROCESSED; /* Mid-level is done processing */ cmd->cmd_sent_to_fw = 1; + cmd->ctio_flags = le16_to_cpu(pkt->u.status0.flags); /* Memory Barrier */ wmb(); @@ -3369,6 +3370,7 @@ int qlt_rdy_to_xfer(struct qla_tgt_cmd *cmd) cmd->state = QLA_TGT_STATE_NEED_DATA; cmd->cmd_sent_to_fw = 1; + cmd->ctio_flags = le16_to_cpu(pkt->u.status0.flags); /* Memory Barrier */ wmb(); @@ -3942,12 +3944,20 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha, if (unlikely(status != CTIO_SUCCESS)) { switch (status & 0xFFFF) { + case CTIO_INVALID_RX_ID: + if (printk_ratelimit()) + dev_info(&vha->hw->pdev->dev, + "qla_target(%d): CTIO with INVALID_RX_ID ATIO attr %x CTIO Flags %x|%x\n", + vha->vp_idx, cmd->atio.u.isp24.attr, + ((cmd->ctio_flags >> 9) & 0xf), + cmd->ctio_flags); + + break; case CTIO_LIP_RESET: case CTIO_TARGET_RESET: case CTIO_ABORTED: /* driver request abort via Terminate exchange */ case CTIO_TIMEOUT: - case CTIO_INVALID_RX_ID: /* They are OK */ ql_dbg(ql_dbg_tgt_mgt, vha, 0xf058, "qla_target(%d): CTIO with " diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h index fecf96f0225c..cda41f2074cf 100644 --- a/drivers/scsi/qla2xxx/qla_target.h +++ b/drivers/scsi/qla2xxx/qla_target.h @@ -908,6 +908,7 @@ struct qla_tgt_cmd { u64 unpacked_lun; enum dma_data_direction dma_data_direction; + uint16_t ctio_flags; uint16_t vp_idx; uint16_t loop_id; /* to save extra sess dereferences */ struct qla_tgt *tgt; /* to save extra sess dereferences */