From patchwork Wed Oct 10 15:35:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 10634767 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3F26C13AD for ; Wed, 10 Oct 2018 15:35:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E378C2A71F for ; Wed, 10 Oct 2018 15:35:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D7B9B2A722; Wed, 10 Oct 2018 15:35:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 100512A720 for ; Wed, 10 Oct 2018 15:35:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726840AbeJJW6B (ORCPT ); Wed, 10 Oct 2018 18:58:01 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:47938 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726479AbeJJW6A (ORCPT ); Wed, 10 Oct 2018 18:58:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hSpYJEpcolzqjEw6RQAzVzcr/jcdCB4VUg1+lNVAvwU=; b=hUiSM16DuerCbvqarzuIXzdNBl 2gn98JFywFk2/kHfdR8ZL7yC3fMwvZsH/QXb0Xhz+QQTAr96Bcjoy/gjZTEenBDJUE8uLDlvljdCJ WKKj6/7rhd8mGd5FgOpXR7nG0+PQ+J3mcy+B+yk+iACcIOpEasATLteMM3Qr1OMpaV1pJw+wbqH+7 akTne9tbu4VqDmS5hg9VmQ5RXbBo5OXwcPT6atKd1ucg6JGf/tLhgsye49lvxjSlIE0XtVMaP+gzL 6W0OVyBHZAqXszELnqMa+3QrLy6iWXWUUGf7l0sEUo/pRdYQtZ1bAhSPyULw/M6yuw61z0yipoHSR mhCTuLlw==; Received: from 089144207060.atnat0016.highway.bob.at ([89.144.207.60] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gAGW4-00025h-PO; Wed, 10 Oct 2018 15:35:17 +0000 From: Christoph Hellwig To: linux-scsi@vger.kernel.org Cc: Michael Schmitz , Finn Thain , Hannes Reinecke , Thomas Bogendoerfer , "David S . Miller" Subject: [PATCH 2/4] sun_esp: don't use GFP_ATOMIC for command block allocation Date: Wed, 10 Oct 2018 17:35:05 +0200 Message-Id: <20181010153507.8020-3-hch@lst.de> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181010153507.8020-1-hch@lst.de> References: <20181010153507.8020-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP esp_sbus_map_command_block is called straight from the probe routine without any locks held, so we can safely use GFP_KERNEL here. Signed-off-by: Christoph Hellwig --- drivers/scsi/sun_esp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/sun_esp.c b/drivers/scsi/sun_esp.c index 747ee64a78e1..c7b60ed61c38 100644 --- a/drivers/scsi/sun_esp.c +++ b/drivers/scsi/sun_esp.c @@ -104,7 +104,7 @@ static int esp_sbus_map_command_block(struct esp *esp) esp->command_block = dma_alloc_coherent(&op->dev, 16, &esp->command_block_dma, - GFP_ATOMIC); + GFP_KERNEL); if (!esp->command_block) return -ENOMEM; return 0;