From patchwork Wed Oct 17 23:40:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10646607 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 242D53C13 for ; Wed, 17 Oct 2018 23:40:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 15DD5285F2 for ; Wed, 17 Oct 2018 23:40:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 07336288CF; Wed, 17 Oct 2018 23:40:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CEF5428893 for ; Wed, 17 Oct 2018 23:40:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727253AbeJRHi7 (ORCPT ); Thu, 18 Oct 2018 03:38:59 -0400 Received: from out002.mailprotect.be ([83.217.72.86]:40239 "EHLO out002.mailprotect.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727175AbeJRHi7 (ORCPT ); Thu, 18 Oct 2018 03:38:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mailprotect.be; s=mail; h=Content-Transfer-Encoding:MIME-Version:References :In-Reply-To:Message-Id:Date:Subject:Cc:To:From:reply-to:sender:bcc: content-type; bh=q+qIdieIZ5qyRzkNOTSukKaBqLei9azppFKJUjUGN3c=; b=ZTwXcFrYRm8v pSd1HiDCCxnjlru2YroUzDJKNQmae0lUOgc5kbtvhUz+2jIJjnXJ6ZWGzxSZ37xi/JmH/b2AwG5Sm J/QILgqbb2B+rM0ypwp9LNVIsRmrz0DFlvW9sLJ33MculF9h2tyVAeoU424OCSiHI8Lu6yzCScqqx CcqHprpEysIFlFBak7qlIfBUQaOmwTZzKFCGB8XKvaNIGWLTq6dhvxVWLkU+ghRJhdi2YjNw4phf2 nPpbNWh18rBZTo4/7W6ggDigZhkwQjb1NwJgamOm/41uRrdnF3c44HV/POmztqkiAdPpNSJjNVfRA BmlDZQLhV7S+s1cLGZx82g==; Received: from smtp-auth.mailprotect.be ([178.208.39.155]) by com-mpt-out002.mailprotect.be with esmtp (Exim 4.89) (envelope-from ) id 1gCvQg-000D3I-G9; Thu, 18 Oct 2018 01:40:43 +0200 Received: from desktop-bart.svl.corp.google.com (unknown [104.133.8.89]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth.mailprotect.be (Postfix) with ESMTPSA id 16188C06B7; Thu, 18 Oct 2018 01:40:23 +0200 (CEST) From: Bart Van Assche To: "Martin K . Petersen" , "James E . J . Bottomley" Cc: Greg Kroah-Hartman , linux-scsi@vger.kernel.org, Bart Van Assche , Lee Duncan , Hannes Reinecke , Luis Chamberlain , Johannes Thumshirn , Christoph Hellwig Subject: [PATCH v2 4/7] drivers/base, __device_release_driver(): Do not wait for asynchronous probing Date: Wed, 17 Oct 2018 16:40:03 -0700 Message-Id: <20181017234006.124251-5-bvanassche@acm.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog In-Reply-To: <20181017234006.124251-1-bvanassche@acm.org> References: <20181017234006.124251-1-bvanassche@acm.org> MIME-Version: 1.0 X-Originating-IP: 178.208.39.155 X-SpamExperts-Domain: mailprotect.be X-SpamExperts-Username: 178.208.39.128/27 Authentication-Results: mailprotect.be; auth=pass smtp.auth=178.208.39.128/27@mailprotect.be X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.04) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5ml9eUB9DDXe9CT+BJmOD7p602E9L7XzfQH6nu9C/Fh9KJzpNe6xgvOx q3u0UDjvO1tLifGj39bI0bcPyaJsYTbYPg/zpkSiMTw4RmnfxRCXFU82axTVwUv6v8rWwOPbn8ST Ksl9SxC91yR06AZxhKQie9+9sv+uW/xhFRf3rOAhFEAZ5tLgtxeh4W43PRo1gyVBZhJdB8oBIQVB HyeF+GyojOI3mdswqRrDTMbSijPikzUjpLbYv+k6wc7gZffRufoNd/18byQB0A6J7qtkYo2nkoP/ 7uxT5ANOZNNW1Q/z0yLvsMb+uiAAjdbSeQ5TrAFR//DqOZ7gBtaFV3NEPd9B3ylJDm+BpEBBclKF yxopgN4JfSdG4+vA3R3fKJCA/m/fDy/eqb5U4J5qWPtxGNTs+ee45CKjCUs1S8nYM4EQyrccvRl7 LodRnoQ8/VwOaw+gz/ZKpG7S9PROnRo5n5USQWn9OYmU74xfbcEYge/f7INkM1D8D0wcffXFPtzu Go+eFJImtabaGYRoWdcAtjCcAuDIQf0tklPcA7SYKMcZaFryuM28yfNoRiP4LXR95v/77cCko/EG 7+7uLxBlLaVvfCJf9c87raNJ3rEEAH2+T1zD59o8cPYKs494BBiYWZDfGiqYJbsV6Bia58mKB6GP R9UyIYODc1wVguED8Bfu31/E3ahF5MMcDI7KdpjQKcwi9Jk69TnSHoh9VM4qIjsvP92yJqFDUMWg YkYfhC80sNoIrLcCnn2MFoRBwXu4i9adXN8QoJkCGUT+/nq62lQ14TiNHZBO9dkjkpbpFG8w6J1f hOzjF0b4LXcjJZ5loquFk+pkh+w6U8HrQHUPSWrvc2Dse4DtQMNd1OJpSyWyQnh/kQTWargBlegu JyyioEcV0wEj9itRcd7KH+nVDjFllXn2maRqR4xJOvVleQ85XMfPU/A6Zs85EHjl8kedTQDBddgS itHw/K1calPLDDrKATDDBZ7fFc0FDw0l2bg+z2YoA4glpLgakSw0zRVimFZZLnlzJNjoM9o1R1rc vo3QJ+IRuv3GmkX8LPVuVC3UyB2oVjwpD0SDGnhQZ7XpT35mKiWY4qyAovTKsLgKiJqTF6ymUAav ae3aV27dM5QN3KVLwP/pKIIHQBh4yd/8+tEyvDkN3AfUBddcu9g0Uhw/YHGGdt5eD9ya81kvI1of 3IOsrfnTjx5M5ZqkPpQBrM2wWVbjHO/cpJpsYlvFhM+mW297Uqw0ZsTjLTJBUO9GfzrLxVhP0uel tSacMfCNTlvBloR44kmvlvy5XDsjxS0= X-Report-Abuse-To: spam@com-mpt-mgt001.mailprotect.be Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since __device_release_driver() is called with the device lock held and since the same device lock is obtained by the functions that perform asynchronous probing (driver_attach_async() and __device_attach_async_helper()), asynchronous probing is already serialized against __device_release_driver(). Remove the async_synchronize_full() call from __device_release_driver() to avoid that a deadlock is triggered. Fixes: 765230b5f084 ("driver-core: add asynchronous probing support for drivers"). Acked-by: Dmitry Torokhov Cc: Lee Duncan Cc: Hannes Reinecke Cc: Luis Chamberlain Cc: Johannes Thumshirn Cc: Christoph Hellwig Cc: Greg Kroah-Hartman Signed-off-by: Bart Van Assche --- drivers/base/dd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index f8d645aa09be..0a3c9f8702de 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -999,9 +999,6 @@ static void __device_release_driver(struct device *dev, struct device *parent) drv = dev->driver; if (drv) { - if (driver_allows_async_probing(drv)) - async_synchronize_full(); - while (device_links_busy(dev)) { device_unlock(dev); if (parent)