From patchwork Thu Oct 18 22:45:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10648357 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A8E6A13B0 for ; Thu, 18 Oct 2018 22:46:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 96D0D28C5A for ; Thu, 18 Oct 2018 22:46:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8771028C66; Thu, 18 Oct 2018 22:46:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2F0B128C5A for ; Thu, 18 Oct 2018 22:46:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727175AbeJSGtc (ORCPT ); Fri, 19 Oct 2018 02:49:32 -0400 Received: from com-out001.mailprotect.be ([83.217.72.83]:39223 "EHLO com-out001.mailprotect.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726530AbeJSGtc (ORCPT ); Fri, 19 Oct 2018 02:49:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mailprotect.be; s=mail; h=Content-Transfer-Encoding:MIME-Version:References :In-Reply-To:Message-Id:Date:Subject:Cc:To:From:reply-to:sender:bcc: content-type; bh=iVeCb+B4S4OcYuyQhTo+ebxPJWOgp4P+D6TXxE0JHC8=; b=lSGQn1nWoPid NrS9Jz8z8GXQWHdoNg94wJHsJfNZP5RwWtmNQU0ZmLpKe+q5TSM1E8gWd4qS6HK67rTK8jjBS52Z+ zCCVbSLzwZ9ku+dIgfMqlLjJTjr0gAOdeYLinR9FKXcw9zvQqy9LUREEh032CYPoWe/qM6ck4rFo6 cLqEPKK2Wd0dfqj1uVgH2ucDK88lcBzjOrxbQbo++lGPzJHDI2cT4OIQhVajnO1D23SDvXq28dj5w zRko2DrA1lKPJrBWbcy9C5hsRcJ+f3krG1DgcAjZJtWGgi+hhGaNWuOf7Bl1jG6Y+l4IWW+x3nhH/ pxmfNhyeSMqVoewysTWDyg==; Received: from smtp-auth.mailprotect.be ([178.208.39.159]) by com-mpt-out001.mailprotect.be with esmtp (Exim 4.89) (envelope-from ) id 1gDH3Z-0009jX-UZ; Fri, 19 Oct 2018 00:46:18 +0200 Received: from desktop-bart.svl.corp.google.com (unknown [104.133.8.89]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth.mailprotect.be (Postfix) with ESMTPSA id C5C1DC0948; Fri, 19 Oct 2018 00:46:03 +0200 (CEST) From: Bart Van Assche To: "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, Bart Van Assche , Himanshu Madhani Subject: [PATCH 6/7] qla2xxx: Make sure that qlafx00_ioctl_iosb_entry() initializes 'res' Date: Thu, 18 Oct 2018 15:45:45 -0700 Message-Id: <20181018224546.189268-7-bvanassche@acm.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog In-Reply-To: <20181018224546.189268-1-bvanassche@acm.org> References: <20181018224546.189268-1-bvanassche@acm.org> MIME-Version: 1.0 X-Originating-IP: 178.208.39.159 X-SpamExperts-Domain: mailprotect.be X-SpamExperts-Username: 178.208.39.128/27 Authentication-Results: mailprotect.be; auth=pass smtp.auth=178.208.39.128/27@mailprotect.be X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.29) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5tU5qcUyt3FD+g3KoBeoNxh602E9L7XzfQH6nu9C/Fh9KJzpNe6xgvOx q3u0UDjvO1tLifGj39bI0bcPyaJsYTarjontMPw7f3NqDIrNV7pphXnBH4p08Ft9j1x3N/nLO18D Od3nQsC62ajtEOV/fohsGOPFT2pee2Xw2nnaC+uuZzUV2SSE877X6ek5VphlU4lE4xwlSMNZQReC h1BkhSvwYJg8Zt8D44lX+/mPOqzZYqVFg3z5lbRdfQAf/u3PyUGlz8CJSOMrvzx9TVg3RkVIB/By MNbUX7EZfs40fNTJ+yiBn1++U1P6gFCnKfjMMqxWoq/FM2XXTzjR7Qr2fwMMkuAhrQsaE4EFItc3 F3UBTqn1gyiGMs00+yjdEjhJY611qc5TTtnihBuF8qtjLQ8qKjBgnhkDdZyt5hDIfQWKNv5BuPUK FL0zB1N5cuImBZB4RMjNrYhKfl0SAFHN1M5EDBffVZVjmVaNbG4ZJG7Ff0+2U06FHKGGFNW71s0u W88WrhLmFL/jnsAXfPxLyzjzxdxlFfinQQaq5wl/I9BovCrJPmnnTHzVkpybMK7ZTTCS3QnTZ9ql TgOmsfE7BE1z8Ne0ck6P4ivKdWmRJx+gQYzna0TUPxp4FPQssSWHj7R1IoyVcpAXxfUeXJw8PSKZ yxi/aFboTUAaA09dklP/aIfVaCHpEB6cFH6WJxE4ZuXQEFqM1vccOzPcPFsPwfK8UcVk6hjRxQmD Dj6E/uD+wccV1Pe/GGVvsrigw1B7Vd89OVhGIz4XNIPo1k/OgsY0wu7hsg0KKTp14lShhltI/LkL W6eiryQjwVOtGwt2QIsEMysPur9wmiDBurOy6iSG6b/fgtlHDkX18Z9N16MyYEBkrhhCSE3l+hqP hVgOJOadjlR3ghD00hMB10wfWyGCr6CrA4gNGHQiTbQ5a4CNZuM7jUXIESohoO51xWmU8czCEOxz /0BeOl9RtvpQQNIAY8GGzvEuQ/UbbinoS2ia9cWG5T+iUuLiPEkCpP4nehmok11u89pTKgJ27pjs IdJdnSA6TSRMmUFdTg/ucnvNo0E7UOWuGn2ne/goKp9SNIalL4LoE8AgSzw+KJWjcRuRcNd9tiaL vbHyK6vNP7FLLRiiuePC9LaWqfSSfvDlMCVzN5/dW7beNptJSTOj3Yk= X-Report-Abuse-To: spam@com-mpt-mgt001.mailprotect.be Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Only one of the two code paths in qlafx00_ioctl_iosb_entry() initializes the variable 'res'. Make sure that 'res' is initialized before sp->done(sp, res) is called. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche Acked-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index 2d96f3b7e3e3..b8f967e61891 100644 --- a/drivers/scsi/qla2xxx/qla_mr.c +++ b/drivers/scsi/qla2xxx/qla_mr.c @@ -2212,7 +2212,7 @@ qlafx00_ioctl_iosb_entry(scsi_qla_host_t *vha, struct req_que *req, struct bsg_job *bsg_job; struct fc_bsg_reply *bsg_reply; struct srb_iocb *iocb_job; - int res; + int res = 0; struct qla_mt_iocb_rsp_fx00 fstatus; uint8_t *fw_sts_ptr;