From patchwork Thu Oct 18 22:45:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10648349 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8A0761508 for ; Thu, 18 Oct 2018 22:46:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A90F28C5A for ; Thu, 18 Oct 2018 22:46:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6D6EE28C62; Thu, 18 Oct 2018 22:46:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 134EA28C5A for ; Thu, 18 Oct 2018 22:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726916AbeJSGtZ (ORCPT ); Fri, 19 Oct 2018 02:49:25 -0400 Received: from com-out001.mailprotect.be ([83.217.72.83]:56919 "EHLO com-out001.mailprotect.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725777AbeJSGtZ (ORCPT ); Fri, 19 Oct 2018 02:49:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mailprotect.be; s=mail; h=Content-Transfer-Encoding:MIME-Version:References :In-Reply-To:Message-Id:Date:Subject:Cc:To:From:reply-to:sender:bcc: content-type; bh=tdRh4NEUros+Wwc0hjntWnSJNSQiwlVAyDhDfvP+sxU=; b=LosyWZBxuA4T L3gombY7YpBfXB3b54penHTrwVchpcuuzmHAtMCJz0f0pG08boABY86kEnRpeBsk0DUjX1hht0ZH5 GXCxp91Tlc6OuZJaCjxJbAJJacM0quR4YKzNnDPXU+7/9mI3GX5Swnis1vF6jJ7S4LvC9R6Oy4U71 jziqmJQuPW40evsVBkZT8KWpW1c5DI6NLan2cq8B7XxPSiE1OnizmZLip0aoIeYS7JmOfpqXDK6bc WdULZ+9OanPIv7B47OiRDQZS1NTeIxJcci5eW+yOuB+j/CwmEMj2vnLwNRghvNu1M77ZWFgZ76Vz4 4ppCyMbyqHLluOu4BTj3VA==; Received: from smtp-auth.mailprotect.be ([178.208.39.159]) by com-mpt-out001.mailprotect.be with esmtp (Exim 4.89) (envelope-from ) id 1gDH3S-0009jv-E9; Fri, 19 Oct 2018 00:46:11 +0200 Received: from desktop-bart.svl.corp.google.com (unknown [104.133.8.89]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth.mailprotect.be (Postfix) with ESMTPSA id 3930BC09A6; Fri, 19 Oct 2018 00:46:05 +0200 (CEST) From: Bart Van Assche To: "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, Bart Van Assche , Himanshu Madhani Subject: [PATCH 7/7] qla2xxx: Remove two arguments from qlafx00_error_entry() Date: Thu, 18 Oct 2018 15:45:46 -0700 Message-Id: <20181018224546.189268-8-bvanassche@acm.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog In-Reply-To: <20181018224546.189268-1-bvanassche@acm.org> References: <20181018224546.189268-1-bvanassche@acm.org> MIME-Version: 1.0 X-Originating-IP: 178.208.39.159 X-SpamExperts-Domain: mailprotect.be X-SpamExperts-Username: 178.208.39.128/27 Authentication-Results: mailprotect.be; auth=pass smtp.auth=178.208.39.128/27@mailprotect.be X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.11) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5nRcTsuFHExsE2I/na15xqF602E9L7XzfQH6nu9C/Fh9KJzpNe6xgvOx q3u0UDjvO1tLifGj39bI0bcPyaJsYTarjontMPw7f3NqDIrNV7pphXnBH4p08Ft9j1x3N/nLO18D Od3nQsC62ajtEOV/fohsGOPFT2pee2Xw2nnaC+uuZzUV2SSE877X6ek5VphlU4lE4xwlSMNZQReC h1BkhSvwYJg8Zt8D44lX+/mPOqzZYqVFg3z5lbRdfQAf/u3PyUGlz8CJSOMrvzx9TVg3RkVgf1NI Xmo6OyQUiwsS5y8c+yiBn1++U1P6gFCnKfjMMqxWoq/FM2XXTzjR7Qr2fwMMkuAhrQsaE4EFItc3 F3UBTqn1gyiGMs00+yjdEjhJY611qc5TTtnihBuF8qtjLQ8qKjBgnhkDdZyt5hDIfQWKNv5BuPUK FL0zB1N5cuImBZB4RMjNrYhKfl0SAFHN1M5EDBffVZVjmVaNbG4ZJG7Ff0+2U06FHKGGFNW71s0u W88WrhLmFL/jnsAXfPxLyzjzxdxlFfinQQaq5wl/I9BovCrJPmnnTHzVkpybMK7ZTTCS3QnTZ9ql TgOmsfE7BE1z8Ne0ck6P4ivKdWmRJx+gQYzna0TUPxp4FPQssSWHj7R1IoyVcpAXxfUeXJw8PSKZ yxi/aFboTUAaA09dklP/aIfVaCHpEB6cFH6WJxE4ZuXQEFqM1vccOzPcPFsPwfK8UcVk6hjRxQmD Dj6E/uD+G6wLiuvpztxcYbTepspBcN89OVhGIz4XNIPo1k/OgsY0wu7hsg0KKTp14lShhltI/LkL W6eiryQjwVOtGwt2QIsEMysPur9wmiDBurOy6iSG6b/fgtlHDkX18Z9N16MyYEBkrhhCSE3l+hqP hVgOJA00R26L1DocNWUJ9oSlIXFut9mbGHk9HOXus3wbXZI+ZuM7jUXIESohoO51xWmU8czCEOxz /0BeOl9RtvpQQNIAY8GGzvEuQ/UbbinoS2ia9cWG5T+iUuLiPEkCpP4nehmok11u89pTKgJ27pjs IdJdnSA6TSRMmUFdTg/ucnvNo0E7UOWuGn2ne/goKp9SNIalL4LoE8AgSzw+KJWjcRuRcNd9tiaL vbHyK6vNP7FLLRiiuePC9LaWqfSSfvDlMCVzN5/dW7beNptJSTOj3Yk= X-Report-Abuse-To: spam@com-mpt-mgt001.mailprotect.be Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Move a debug statement from qlafx00_error_entry() into its caller. Remove one unused argument from that function. This patch does not change the behavior of the qla2xxx driver. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche Acked-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mr.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index b8f967e61891..60f964c53c01 100644 --- a/drivers/scsi/qla2xxx/qla_mr.c +++ b/drivers/scsi/qla2xxx/qla_mr.c @@ -2681,12 +2681,10 @@ qlafx00_multistatus_entry(struct scsi_qla_host *vha, * @vha: SCSI driver HA context * @rsp: response queue * @pkt: Entry pointer - * @estatus: - * @etype: */ static void qlafx00_error_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, - struct sts_entry_fx00 *pkt, uint8_t estatus, uint8_t etype) + struct sts_entry_fx00 *pkt) { srb_t *sp; struct qla_hw_data *ha = vha->hw; @@ -2695,9 +2693,6 @@ qlafx00_error_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, struct req_que *req = NULL; int res = DID_ERROR << 16; - ql_dbg(ql_dbg_async, vha, 0x507f, - "type of error status in response: 0x%x\n", estatus); - req = ha->req_q_map[que]; sp = qla2x00_get_sp_from_handle(vha, func, req, pkt); @@ -2745,9 +2740,11 @@ qlafx00_process_response_queue(struct scsi_qla_host *vha, if (pkt->entry_status != 0 && pkt->entry_type != IOCTL_IOSB_TYPE_FX00) { + ql_dbg(ql_dbg_async, vha, 0x507f, + "type of error status in response: 0x%x\n", + pkt->entry_status); qlafx00_error_entry(vha, rsp, - (struct sts_entry_fx00 *)pkt, pkt->entry_status, - pkt->entry_type); + (struct sts_entry_fx00 *)pkt); continue; }