From patchwork Tue Oct 23 20:41:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Smart X-Patchwork-Id: 10653635 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0F5E514BB for ; Tue, 23 Oct 2018 20:41:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EF76B2A491 for ; Tue, 23 Oct 2018 20:41:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EDF2C2A4A4; Tue, 23 Oct 2018 20:41:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 96EF12A4C5 for ; Tue, 23 Oct 2018 20:41:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727530AbeJXFGi (ORCPT ); Wed, 24 Oct 2018 01:06:38 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:35724 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725761AbeJXFGh (ORCPT ); Wed, 24 Oct 2018 01:06:37 -0400 Received: by mail-pg1-f195.google.com with SMTP id 32-v6so1218381pgu.2 for ; Tue, 23 Oct 2018 13:41:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7HCOlIoHFbSvKJjJNeSXjOBfULpd4uPCORwLiuFDQUo=; b=VHY3GnwKosNHsjyLFVImmwdOminUJjQOyF0VrvW/dX5TIm6Ai8pPjBpg9D1QzKYtrR Psv9KCq1X/MG9gF5HCO3DlCx+RAqiBvzanXZvnMM6a0oA8KIs2Fo+k783LPEA6Zmvdb5 2JG4VxCoUk47OX2bOC/dwEQQcNO634R8slMLcSgV/6xVnxkRiuoFi8wPprlqC2KH41Vi Rnqy8gGn/ewasTH4sm7zhQqYbcnGdX6C/mX6+Tu5bS9zlmAzzhracF5NdH8n9pqOFFeC +dygOvaZ1ASxxxULIaypUxrD8DYQgzVgqdXiHQmeX0yNqjVv1TATLy03IoK1qxJ8fjl6 Gn8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7HCOlIoHFbSvKJjJNeSXjOBfULpd4uPCORwLiuFDQUo=; b=ONlelF63GLu4ZzeNj0/rSrwTsV4MlKt45hGKBq2s5GLnELRUcHPYAhuU/OdPPj+uu5 1J42ar9Am6yMvr/2GqAlseXDGXp2JniG2OstIa9O07qcJY7h4vgHkG5HZbhosYteOJH+ gnn+ljQL5e/BaORkNV+CgfTRR80L7F3J8jULgQ2HH4kqqUS3BoPFQjHbceOVTMBsBlDb ix4TS8PgY1rO27oQZDcqB468h+no+b7uFKVPUfELJT6M/dFFO3tyMkM0Dgoxed27Lpo3 gUKVZnG6dtwENThdV9lRGeBQBqJE0LWNlu1zMipuVHXXYXbI+x9PwdZrO728ghCmrVsP wNqw== X-Gm-Message-State: ABuFfoiaV1kfTi1Rzm8vkr0BfcHx3cnWXSLzsIoTsnKUqoMpnw6IR6qH U6ezMddWEeJnyEGVmPsIvf8uPRMM X-Google-Smtp-Source: ACcGV61h56kfPxhBr1IECGz3DQlVuYblSY3r2xFO5XdNiUu6HgGhnfY6RSBMnUZDi+4c7w28HmIt0w== X-Received: by 2002:a62:4c3:: with SMTP id 186-v6mr50522529pfe.156.1540327295214; Tue, 23 Oct 2018 13:41:35 -0700 (PDT) Received: from pallmd1.broadcom.com ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id m11-v6sm4348752pgn.39.2018.10.23.13.41.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 23 Oct 2018 13:41:34 -0700 (PDT) From: James Smart To: linux-scsi@vger.kernel.org Cc: James Smart , Dick Kennedy Subject: [PATCH 02/12] lpfc: Fix lpfc_sli4_read_config return value check Date: Tue, 23 Oct 2018 13:41:02 -0700 Message-Id: <20181023204112.18213-3-jsmart2021@gmail.com> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20181023204112.18213-1-jsmart2021@gmail.com> References: <20181023204112.18213-1-jsmart2021@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP An error is an error - but not to the existing return value check. Revise check to handle any failure, not just EIO. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Hannes Reinecke --- drivers/scsi/lpfc/lpfc_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index c78ae81b5701..098b5ef3e9b8 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -4896,11 +4896,11 @@ lpfc_sli4_async_sli_evt(struct lpfc_hba *phba, struct lpfc_acqe_sli *acqe_sli) /* Issue READ_CONFIG mbox command to refresh supported speeds */ rc = lpfc_sli4_read_config(phba); - if (rc == -EIO) { + if (rc) { phba->lmt = 0; lpfc_printf_log(phba, KERN_ERR, LOG_SLI, "3194 Unable to retrieve supported " - "speeds\n"); + "speeds, rc = 0x%x\n", rc); } vports = lpfc_create_vport_work_array(phba); if (vports != NULL) {