From patchwork Fri Nov 2 14:37:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengguang Xu X-Patchwork-Id: 10665583 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 404D913B5 for ; Fri, 2 Nov 2018 14:37:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2E51228CB5 for ; Fri, 2 Nov 2018 14:37:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1EE5C28B81; Fri, 2 Nov 2018 14:37:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SUBJ_OBFU_PUNCT_MANY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AF27928B81 for ; Fri, 2 Nov 2018 14:37:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727744AbeKBXpQ (ORCPT ); Fri, 2 Nov 2018 19:45:16 -0400 Received: from mout.gmx.net ([212.227.15.15]:57717 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727454AbeKBXpQ (ORCPT ); Fri, 2 Nov 2018 19:45:16 -0400 Received: from localhost.localdomain ([113.116.157.11]) by mail.gmx.com (mrgmx003 [212.227.17.184]) with ESMTPSA (Nemesis) id 0M9s2y-1gPA954356-00B4B6; Fri, 02 Nov 2018 15:37:49 +0100 Received: from localhost.localdomain ([113.116.157.11]) by mail.gmx.com (mrgmx003 [212.227.17.184]) with ESMTPSA (Nemesis) id 0M9s2y-1gPA954356-00B4B6; Fri, 02 Nov 2018 15:37:49 +0100 From: Chengguang Xu To: kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, Chengguang Xu Subject: [PATCH 1/3] scsi: megaraid: remove unnecessary condition check in megaraid_mbox_teardown_dma_pools() Date: Fri, 2 Nov 2018 22:37:32 +0800 Message-Id: <20181102143734.31810-1-cgxu519@gmx.com> X-Mailer: git-send-email 2.17.2 X-Provags-ID: V03:K1:1vOuxBwR9rdv4wBCymSBu+tw7ON4HzQp4hB48fpWAzIa9ygGzRZ 7NBfM0nyZe90JDXowOu90HJu/SIL/VWiS4jeIPY82CpwLAQ36g0CUFETbKSQ7EMlBAQFdQB P7x2cPE2MK69Asw/5ITcGeXxSFX0RTmGcXr4OpJdcWpLxFyeDcCsm1kzHA22U3tfIsOJlBV gvH3ZdJYny1oW8cQzh/AQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:ShUVTO2NDZE=:3/4lCZ0A964q+C7CZ0UPEC XxnwcASmRgsjkTFahebd4fDwcIj6yE2WMBtV4f1CCQUT/d8dOphIxlpxQbf4gshV8fFu1lDCX NycOrNdSAJuKNuPGWx98HrZSkPNDQHZfgQKs/IbW/uZbvftaJfaGyXCPFvkwr/7XvrU9TS7Mv 3G9RDou+0Py059Nt3qEWkryQc7Z7sjADmZEyB/p4OGtBQTD5q/3tQg1/0UGJbStKrqPS3xWj4 yj4wlVAmTbTzM5SQ88aDC6lJ3/UxdRBSKeGKAKzc8jFsgQalV22o17zVJlK5uayS7APjNAaAt ZXdo7frXPe9xvtrgErxeq8mPj2X4O6l5M570Z8BBIrBgQyUFEie/A6USkV2XDXKcLABOyZKxA i9ze6jNOOl1nDt+HQ+GBS2wMjncXqQT+gdNy3UE8ID3Fe113/IeRPBwJCFzVOoyXEcFV6VPtj ZEKEBrEM0kTM/UC0qDyeXWZNZviZ4np3TVRe2wphC6ZT/mFk4h2rt/FA1YjlWS8aA9GV1WU0v 7xWy7FjiedU1z6ITq6Mtv8askM9u7PsirhMJtRDSCXDg5ao0AAqGHz6GdqI3ZrHDgHTyK4wOv 4R59UHwFenpn/5gbeqb/9TP1N98W+FXdyuQqsOLx0GvfqPrmNip1ELLwGiDs4zgaSoLsjzupc P3j890UcXHcms0dogYleAZBJN+TzvUyvBFqZxpkKT6frZ+9AI3RoOweiN8Dp0FrVb5GChB8AR /K87bqLb4TZ//rcrvqD1VF0ecPHgLcJ9PHgEjVdK8kDOEi27zNjtszEAlNFVgAByMfZRTfk8C Ff+XbeemvHMBLNnQvF+UHvjMLW/ng== Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP dma_pool_destroy() can handle NULL pointer correctly, so there is no need to check NULL pointer before calling dma_pool_destroy(). Signed-off-by: Chengguang Xu --- drivers/scsi/megaraid/megaraid_mbox.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_mbox.c b/drivers/scsi/megaraid/megaraid_mbox.c index 3b7abe5ca7f5..7f9ba88d1c2d 100644 --- a/drivers/scsi/megaraid/megaraid_mbox.c +++ b/drivers/scsi/megaraid/megaraid_mbox.c @@ -1243,8 +1243,7 @@ megaraid_mbox_teardown_dma_pools(adapter_t *adapter) dma_pool_free(raid_dev->sg_pool_handle, sg_pci_blk[i].vaddr, sg_pci_blk[i].dma_addr); } - if (raid_dev->sg_pool_handle) - dma_pool_destroy(raid_dev->sg_pool_handle); + dma_pool_destroy(raid_dev->sg_pool_handle); epthru_pci_blk = raid_dev->epthru_pool; @@ -1252,8 +1251,7 @@ megaraid_mbox_teardown_dma_pools(adapter_t *adapter) dma_pool_free(raid_dev->epthru_pool_handle, epthru_pci_blk[i].vaddr, epthru_pci_blk[i].dma_addr); } - if (raid_dev->epthru_pool_handle) - dma_pool_destroy(raid_dev->epthru_pool_handle); + dma_pool_destroy(raid_dev->epthru_pool_handle); mbox_pci_blk = raid_dev->mbox_pool; @@ -1261,8 +1259,7 @@ megaraid_mbox_teardown_dma_pools(adapter_t *adapter) dma_pool_free(raid_dev->mbox_pool_handle, mbox_pci_blk[i].vaddr, mbox_pci_blk[i].dma_addr); } - if (raid_dev->mbox_pool_handle) - dma_pool_destroy(raid_dev->mbox_pool_handle); + dma_pool_destroy(raid_dev->mbox_pool_handle); return; }