From patchwork Fri Nov 2 14:37:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengguang Xu X-Patchwork-Id: 10665585 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3E8B0157A for ; Fri, 2 Nov 2018 14:38:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2C02828B81 for ; Fri, 2 Nov 2018 14:38:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1CF1728D8E; Fri, 2 Nov 2018 14:38:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0A80428B81 for ; Fri, 2 Nov 2018 14:38:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727771AbeKBXpX (ORCPT ); Fri, 2 Nov 2018 19:45:23 -0400 Received: from mout.gmx.net ([212.227.15.19]:59269 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727454AbeKBXpX (ORCPT ); Fri, 2 Nov 2018 19:45:23 -0400 Received: from localhost.localdomain ([113.116.157.11]) by mail.gmx.com (mrgmx003 [212.227.17.184]) with ESMTPSA (Nemesis) id 0LnfuZ-1fcgaz1LLz-00hrtH; Fri, 02 Nov 2018 15:37:55 +0100 Received: from localhost.localdomain ([113.116.157.11]) by mail.gmx.com (mrgmx003 [212.227.17.184]) with ESMTPSA (Nemesis) id 0LnfuZ-1fcgaz1LLz-00hrtH; Fri, 02 Nov 2018 15:37:55 +0100 From: Chengguang Xu To: kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, Chengguang Xu Subject: [PATCH 2/3] scsi: megaraid: remove unnecessary condition check in mraid_mm_register_adp() Date: Fri, 2 Nov 2018 22:37:33 +0800 Message-Id: <20181102143734.31810-2-cgxu519@gmx.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181102143734.31810-1-cgxu519@gmx.com> References: <20181102143734.31810-1-cgxu519@gmx.com> X-Provags-ID: V03:K1:20R4+2gv6mb12uv+MM6E++7X9QxhU9r9BkERC0IXBSiI7tuPaTc meRnI1tueGNzmPtIijBCBf3FRXw01IFCRl4gxmtHwAQFLZd/gD2bYqEsWvfJgqMDj/fduSC 6uGP1085HwIjmS1RWuA5W33E/D10fkPpsJrDXWdb2UPbacXf7rVDds5euD8hsvhIFBAxZov 3IFkYGyNSplTE8FNX0ueA== X-UI-Out-Filterresults: notjunk:1;V01:K0:ebgmxBAXKFc=:5HcljCQNfezqXqMqQvJjAh UncF0jG+kJDfc9hWz6uYTNY0slaOCUPIgt9NnuMc+FiXrMj3Vbu5fM3YIO8JJ/3kx+K39flJd yEpXsqb2hrAoZSgCXBxLf25GmDeoReqHdY22PHhBuDvKR4pILMt9oIOjg7TnCdt9NAl0OWh87 DzqvXa89FVFiDdeg+GMvS5Lb5/4o9X3QJFcbAxVxREjnLYmbX6jOQjPxupTq3D0dCLudMX8VU 5VOL9YXwBbmYztyhVesZrSW2c4wc6XXWBLFDMrdKgmsHFs4ckxbrImAUL9XUueqenXfmRtZp9 irlnaNO/mdx3u7FSweEcNhFmXCner7+8OOv93yHQPLXkgT+eJIxUViJ0k7q3S6hWUgD3u8tUk zB2a6ugySCBmCzJlRMZLJhTw+4gUI/G8L2P5w3O2BkVKkkQZqTWzCVC5EKedAGmSuBx3aOmC1 qkdJ06Si8yDvJ27R/fRoS73qPT8TqTBSGGR4gs8CZy+LanFBkOLHsn3SPaTH9FdYVKx8t5oel XtW4s0d/oNt9r/Ux0NplGctlLWRk3DEGNxrdRJ4Pev3NNHoZwbTdqOJrKZXDL3GeCzYlstlEF cmx3e0R9MTmd03IQR4Pwt0Z4lJ06JE8B7f9rgYAsNqudmy8Wo7bgSTZoZ/F2ZWKSv1r6P0OVL kh10HBIs8L61+HYZw7oACs2fEbqaUGv9XqFlPINBVnSsUShu0xosif/dBIM/2VxosJxfQeCpb JazenwtEzCjEIKb4NKq4wPFE4KsTE+DUgruaZSMJVN1Tg2+PEywVjt7sNPQcN6+qUvrxqFvNV IsjAnZSTzMGudzbwioTvdjjCfrizg== Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP dma_pool_destroy() can handle NULL pointer correctly, so there is no need to check NULL pointer before calling dma_pool_destroy(). Signed-off-by: Chengguang Xu --- drivers/scsi/megaraid/megaraid_mm.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_mm.c b/drivers/scsi/megaraid/megaraid_mm.c index 8428247015db..ee870bba15ef 100644 --- a/drivers/scsi/megaraid/megaraid_mm.c +++ b/drivers/scsi/megaraid/megaraid_mm.c @@ -1016,10 +1016,7 @@ mraid_mm_register_adp(mraid_mmadp_t *lld_adp) kfree(adapter->kioc_list); kfree(adapter->mbox_list); - - if (adapter->pthru_dma_pool) - dma_pool_destroy(adapter->pthru_dma_pool); - + dma_pool_destroy(adapter->pthru_dma_pool); kfree(adapter); return rval;