diff mbox series

[21/25] lpfc: Enable SCSI and NVME fc4s by default

Message ID 20181226233334.27518-22-jsmart2021@gmail.com (mailing list archive)
State Superseded
Headers show
Series lpfc updates for 12.2.0.0 | expand

Commit Message

James Smart Dec. 26, 2018, 11:33 p.m. UTC 
Now that performance mods don't split resources by protocol and
enable both protocols by default, there's no reason not to enable
concurrent SCSI and NVME fc4 support.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
---
 drivers/scsi/lpfc/lpfc_attr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Hannes Reinecke Dec. 28, 2018, 12:31 p.m. UTC | #1 
On 12/27/18 12:33 AM, James Smart wrote:
> Now that performance mods don't split resources by protocol and
> enable both protocols by default, there's no reason not to enable
> concurrent SCSI and NVME fc4 support.
> 
> Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
> ---
>   drivers/scsi/lpfc/lpfc_attr.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
> index 451c610219d9..52c3908e0955 100644
> --- a/drivers/scsi/lpfc/lpfc_attr.c
> +++ b/drivers/scsi/lpfc/lpfc_attr.c
> @@ -3772,9 +3772,9 @@ LPFC_ATTR_R(nvmet_mrq_post,
>    * lpfc_enable_fc4_type: Defines what FC4 types are supported.
>    * Supported Values:  1 - register just FCP
>    *                    3 - register both FCP and NVME
> - * Supported values are [1,3]. Default value is 1
> + * Supported values are [1,3]. Default value is 3
>    */
> -LPFC_ATTR_R(enable_fc4_type, LPFC_ENABLE_FCP,
> +LPFC_ATTR_R(enable_fc4_type, LPFC_ENABLE_BOTH,
>   	    LPFC_ENABLE_FCP, LPFC_ENABLE_BOTH,
>   	    "Enable FC4 Protocol support - FCP / NVME");
>   
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
diff mbox series

Patch

diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index 451c610219d9..52c3908e0955 100644
--- a/drivers/scsi/lpfc/lpfc_attr.c
+++ b/drivers/scsi/lpfc/lpfc_attr.c
@@ -3772,9 +3772,9 @@  LPFC_ATTR_R(nvmet_mrq_post,
  * lpfc_enable_fc4_type: Defines what FC4 types are supported.
  * Supported Values:  1 - register just FCP
  *                    3 - register both FCP and NVME
- * Supported values are [1,3]. Default value is 1
+ * Supported values are [1,3]. Default value is 3
  */
-LPFC_ATTR_R(enable_fc4_type, LPFC_ENABLE_FCP,
+LPFC_ATTR_R(enable_fc4_type, LPFC_ENABLE_BOTH,
 	    LPFC_ENABLE_FCP, LPFC_ENABLE_BOTH,
 	    "Enable FC4 Protocol support - FCP / NVME");