[11/26] qedf: missing kref_put in qedf_xmit()

Message ID	20190305105901.13185-12-skashyap@marvell.com (mailing list archive)
State	Superseded
Headers	show Return-Path: <linux-scsi-owner@kernel.org> Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; From: Saurav Kashyap <skashyap@marvell.com> To: <martin.petersen@oracle.com> CC: <QLogic-Storage-Upstream@cavium.com>, <linux-scsi@vger.kernel.org> Subject: [PATCH 11/26] qedf: missing kref_put in qedf_xmit() Date: Tue, 5 Mar 2019 02:58:46 -0800 Message-ID: <20190305105901.13185-12-skashyap@marvell.com> In-Reply-To: <20190305105901.13185-1-skashyap@marvell.com> References: <20190305105901.13185-1-skashyap@marvell.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk
Series	qedf: Misc fixes for the driver. \| expand [00/26] qedf: Misc fixes for the driver. [01/26] qedf: Do not retry ELS request if qedf_alloc_cmd fails. [02/26] qedf: Correct xid range overlap between offloaded requests and libfc requests. [03/26] qedf: Add missing return in qedf_post_io_req() in the fcport offload check. [04/26] qedf: Simplify s/g list mapping. [05/26] qedf: Modify flush routine to handle all I/Os and TMF. [06/26] qedf: Modify abort and tmf handler to handle edge condition and flush. [07/26] qedf: Use a separate completion for cleanup commands. [08/26] qedf: Correct the memory barriers in qedf_ring_doorbell. [09/26] qedf: Add missing fc_disc_init call after allocating lport. [10/26] qedf: Check for link state before processing LL2 packets and send fipvlan retries. [11/26] qedf: missing kref_put in qedf_xmit() [12/26] qedf: fixup locking in qedf_restart_rport() [13/26] qedf: fixup bit operations. [14/26] qedf: Add additional checks for io_req->sc_cmd validity. [15/26] qedf: Wait for upload and link down processing during soft ctx reset. [16/26] qedf: Add missing return in qedf_scsi_done(). [17/26] qedf: fc_rport_priv reference counting fixes [18/26] qedf: Check both the FCF and fabric ID before servicing clear virtual link. [19/26] qedf: Don't queue anything if upload is in progress. [20/26] qedf: Don't send ABTS for under run scenario. [21/26] qedf: Add a flag to help debugging io_req which could not be cleaned. [22/26] qedf: Check for tm_flags instead of cmd_type during cleanup. [23/26] qedf: Cleanup rrq_work after QEDF_CMD_OUTSTANDING is cleared. [24/26] qedf: Correctly handle refcounting of rdata. [25/26] qedf: Fix lport may be used uninitialezed warning. [26/26] qedf: Update the driver version to 8.37.25.19.

Message ID

20190305105901.13185-12-skashyap@marvell.com (mailing list archive)

State

Superseded

Headers

Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not
 designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com;
 client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com;
From: Saurav Kashyap <skashyap@marvell.com>
To: <martin.petersen@oracle.com>
CC: <QLogic-Storage-Upstream@cavium.com>, <linux-scsi@vger.kernel.org>
Subject: [PATCH 11/26] qedf: missing kref_put in qedf_xmit()
Date: Tue, 5 Mar 2019 02:58:46 -0800
Message-ID: <20190305105901.13185-12-skashyap@marvell.com>
In-Reply-To: <20190305105901.13185-1-skashyap@marvell.com>
References: <20190305105901.13185-1-skashyap@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2019 10:59:36.7740
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 666bc34b-8e3e-4c47-2578-08d6a159a87a
X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: 
 TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4756
Sender: linux-scsi-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-scsi.vger.kernel.org>
X-Mailing-List: linux-scsi@vger.kernel.org
X-Virus-Scanned: ClamAV using ClamSMTP

Series

qedf: Misc fixes for the driver. | expand

Commit Message

Saurav Kashyap March 5, 2019, 10:58 a.m. UTC

From: Hannes Reinecke <hare@suse.com>

qedf_xmit() calls fc_rport_lookup(), but discards the returned
rdata structure almost immediately without decreasing the refcount.
This leads to a refcount leak and the rdata never to be freed.

Signed-off-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
---
 drivers/scsi/qedf/qedf_main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index f84552e..fb9c288 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -971,8 +971,10 @@  static int qedf_xmit(struct fc_lport *lport, struct fc_frame *fp)
 		    "Dropping FCoE frame to %06x.\n", ntoh24(fh->fh_d_id));
 		kfree_skb(skb);
 		rdata = fc_rport_lookup(lport, ntoh24(fh->fh_d_id));
-		if (rdata)
+		if (rdata) {
 			rdata->retries = lport->max_rport_retry_count;
+			kref_put(&rdata->kref, fc_rport_destroy);
+		}
 		return -EINVAL;
 	}
 	/* End NPIV filtering */

[11/26] qedf: missing kref_put in qedf_xmit()

Commit Message

Patch