From patchwork Tue Mar 5 10:58:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10839301 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C04B11390 for ; Tue, 5 Mar 2019 11:00:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ACAD42B5A5 for ; Tue, 5 Mar 2019 11:00:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AB3592B66F; Tue, 5 Mar 2019 11:00:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4213D2B665 for ; Tue, 5 Mar 2019 11:00:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727565AbfCELAR (ORCPT ); Tue, 5 Mar 2019 06:00:17 -0500 Received: from mail-eopbgr730063.outbound.protection.outlook.com ([40.107.73.63]:47520 "EHLO NAM05-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727444AbfCELAR (ORCPT ); Tue, 5 Mar 2019 06:00:17 -0500 Received: from DM6PR07CA0057.namprd07.prod.outlook.com (2603:10b6:5:74::34) by DM6PR07MB4761.namprd07.prod.outlook.com (2603:10b6:5:a1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.16; Tue, 5 Mar 2019 11:00:15 +0000 Received: from BY2NAM05FT020.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e52::207) by DM6PR07CA0057.outlook.office365.com (2603:10b6:5:74::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1665.16 via Frontend Transport; Tue, 5 Mar 2019 11:00:15 +0000 Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by BY2NAM05FT020.mail.protection.outlook.com (10.152.100.157) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1686.5 via Frontend Transport; Tue, 5 Mar 2019 11:00:15 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Tue, 5 Mar 2019 03:00:05 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x25B05id013416; Tue, 5 Mar 2019 03:00:05 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x25B05mE013409; Tue, 5 Mar 2019 03:00:05 -0800 From: Saurav Kashyap To: CC: , Subject: [PATCH 21/26] qedf: Add a flag to help debugging io_req which could not be cleaned. Date: Tue, 5 Mar 2019 02:58:56 -0800 Message-ID: <20190305105901.13185-22-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190305105901.13185-1-skashyap@marvell.com> References: <20190305105901.13185-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131962572153899851;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(376002)(39860400002)(396003)(136003)(346002)(2980300002)(1109001)(1110001)(339900001)(199004)(189003)(36756003)(26005)(5660300002)(76176011)(11346002)(446003)(54906003)(51416003)(53936002)(2616005)(106466001)(47776003)(50226002)(486006)(476003)(126002)(68736007)(50466002)(105606002)(6346003)(336012)(6666004)(48376002)(356004)(2351001)(8676002)(305945005)(81166006)(81156014)(80596001)(69596002)(8936002)(1076003)(16586007)(87636003)(6862004)(498600001)(4326008)(2906002)(316002)(42186006)(36906005)(86362001)(97736004)(26826003);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR07MB4761;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: da1dedc9-55de-4721-d606-08d6a159bf57 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600127)(711020)(4605104)(2017052603328);SRVR:DM6PR07MB4761; X-MS-TrafficTypeDiagnostic: DM6PR07MB4761: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 0967749BC1 X-Microsoft-Exchange-Diagnostics: 1;DM6PR07MB4761;23:4PoWLCEfj6QTTl+U1pr9WrKCiQLmQyqcTgmmSHFCFt+ycc2fvN7YtEnaNcCKZ6+nD2o7T40j6qYJZ8zcwBal+DYBRAh5mW6s5F5KgDT+ivLTAQh5jXPXBjGRS2Lz42mxnanmZwTj6wVW2c2duFpD+jk/iwiT8ah47hbNd6y2txhrsUmgc1WKEQnk8yJD9lOByYXbxN82Ui1tOKUgmEHfpTzVGQ6cpVgvdtY8ouOttbYh7e3S1eeiZ/I3Cg0gVdCuBWVv0YlN/rFPp+duD4WJZvka74M1WwKMO6MdBJXzZqvEPSHNYD3FXaOnwIMYRZ6kq4lwaUpRYEG4JG69dod1K8dSuqsmQywKuXkeH5WUy59cCXeZ5DgrKnVNHJ9oD+lTwcGCoZl8Aoyrn5T3Si1uWOO/gxY4EcZ8F7WZwvR0Jk3bVyf7AK8l1uPH29XMK5Ri78sYMMMhSoesNsoT9qkF8R2Y1ofAhWWZm/f0zW5djQ8rkJY3QVvYJvjQ3bVE9SkJ+uYxZUn9MSxn78+L9TEbcaH2V2hwzsMcFJ9ZDLdhfb8Sx4RrE7ckOD9DrYLBTSzl+wDtvl6bX7zwRMkRuk4JL3RnCSdlxeMxnXNE/C59F79bYjmOg8jPOX3MvQU8cb1gPQmhBHu6QGUqTNW787WZ2P+2n1Pge6mKaZzfrIrIhd3k95+FsBnex0bxLMVrH0EprlS5UqDZcOV9Q3FKBG2hMqj8BHJ4vsyFgr9sFnUlhQvJWh0WDH23qxU+2pIdEp8GgtwgujG1HpXGHCGmg3gEnDa2nOv3Erd8FciTSm8PBXVnSmQR1+V0uDFuh1veBBDUfCG/UlIGm0t8f/zs6Zs4PiQ3h7ve0D+cDMtZEfiHxYy0k9ZxTR8KhpSZBKv9TMIezYv42MFP/CeJ1LW7dw2YrUm3yI1+00m4l97CzPa74CmZ1+iDFVLiYoz7LBO4o5Q7SPz7LFFtGeZGXkTTLJFhqRhVLxL0bV8g+DIUN8pOoG5k6yvAhNR0lXYsyuGgPAfEpzGFtUsuE1q7uux04OaRuI7bbvWRhI4/Jt6w4FbihpIGrDKlla1D1kDDKVjNArkTcCjXYW/FO7WLIOXsccsfZiOXywTMlSuFjdgubgvdDk1nNaqMiUOaWD5+fr9Rjho6R5yZgfHAImhPJGmTKWheNR6WwxsfrhKxtYTktdttSL16pX+zM9NQVIx9dDvlELZ8s+cjBkRI/KUrSsnLnUnDibuNegOZBojrQ8uE1G0KQR0= X-Microsoft-Antispam-Message-Info: noUr695YGtLrQWl5W0Xfcl7C34lnSR3IAVJtaB88mBH1ms/kJkPl/BW293xngauObmaJkblN4f0YKN2Ow69gqrjpy7GMN8++7Vxwaw82EXChlJSHLARgkqrFN5NIjr8d1Sq3RCy2+V75KTbLZlaR5ynTCMITgeyROiuFuPWtqRj9DuMdAEQt2HYJDrGITbnSSLM05NKPG0AxwxeQSmz6udwj1q9MKiTvjyb/JvUwX/qhfnG484pAON3p8vBzQHV7F7XE8/aJIA7HkSovbRXRgulGqErpgSc6hzuP+NaTUHHhT+PcRi2IlZ+0nomHStoSJVUxtsZ7nKBUyeNa6rT7GX6Jt4R3DtMSNZZre3aBQmR7YnQpdGyhYeTTRk8jTbXhjrisBESfhnpEnAxWWoaSzdHSStL2AOGRALLT9HyZ2Hc= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2019 11:00:15.1327 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: da1dedc9-55de-4721-d606-08d6a159bf57 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB4761 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Shyam Sundar - The flag will help in to figure out if io_req is cleaned or not. Signed-off-by: Shyam Sundar Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 5e7745e..90d1645 100644 --- a/drivers/scsi/qedf/qedf_io.c +++ b/drivers/scsi/qedf/qedf_io.c @@ -351,6 +351,11 @@ struct qedf_ioreq *qedf_alloc_cmd(struct qedf_rport *fcport, u8 cmd_type) goto out_failed; } + if (test_bit(QEDF_CMD_DIRTY, &io_req->flags)) + QEDF_ERR(&qedf->dbg_ctx, + "io_req found to be dirty ox_id = 0x%x.\n", + io_req->xid); + /* Clear any flags now that we've reallocated the xid */ io_req->flags = 0; io_req->alloc = 1; @@ -1744,6 +1749,8 @@ void qedf_flush_active_ios(struct qedf_rport *fcport, int lun) io_req->fcport == fcport) { refcount = kref_read(&io_req->refcount); + set_bit(QEDF_CMD_DIRTY, + &io_req->flags); QEDF_ERR(&qedf->dbg_ctx, "Outstanding io_req =%p xid=0x%x flags=0x%lx, sc_cmd=%p refcount=%d cmd_type=%d.\n", io_req, io_req->xid,