From patchwork Tue Mar 26 07:38:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10870515 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D4CAC17E6 for ; Tue, 26 Mar 2019 07:39:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C1D6428FEC for ; Tue, 26 Mar 2019 07:39:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B634A2908B; Tue, 26 Mar 2019 07:39:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D23B2907B for ; Tue, 26 Mar 2019 07:39:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731092AbfCZHjr (ORCPT ); Tue, 26 Mar 2019 03:39:47 -0400 Received: from mail-eopbgr710053.outbound.protection.outlook.com ([40.107.71.53]:16736 "EHLO NAM05-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730944AbfCZHjq (ORCPT ); Tue, 26 Mar 2019 03:39:46 -0400 Received: from DM5PR07CA0109.namprd07.prod.outlook.com (2603:10b6:4:ae::38) by BN7PR07MB5363.namprd07.prod.outlook.com (2603:10b6:408:2e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.16; Tue, 26 Mar 2019 07:39:44 +0000 Received: from DM3NAM05FT017.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::200) by DM5PR07CA0109.outlook.office365.com (2603:10b6:4:ae::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.19 via Frontend Transport; Tue, 26 Mar 2019 07:39:44 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT017.mail.protection.outlook.com (10.152.98.126) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1750.4 via Frontend Transport; Tue, 26 Mar 2019 07:39:44 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Tue, 26 Mar 2019 00:39:28 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x2Q7dRC1026863; Tue, 26 Mar 2019 00:39:27 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x2Q7dR2N026862; Tue, 26 Mar 2019 00:39:27 -0700 From: Saurav Kashyap To: CC: , Subject: [PATCH v2 09/26] qedf: Add missing fc_disc_init call after allocating lport. Date: Tue, 26 Mar 2019 00:38:41 -0700 Message-ID: <20190326073858.26792-10-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190326073858.26792-1-skashyap@marvell.com> References: <20190326073858.26792-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131980595845515314;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(396003)(346002)(376002)(39860400002)(136003)(2980300002)(1109001)(1110001)(339900001)(199004)(189003)(86362001)(8676002)(85426001)(2351001)(4744005)(1076003)(36906005)(54906003)(51416003)(106466001)(6862004)(53936002)(105606002)(4326008)(87636003)(498600001)(26826003)(26005)(76176011)(50226002)(97736004)(5660300002)(305945005)(11346002)(68736007)(8936002)(81156014)(47776003)(126002)(36756003)(446003)(336012)(316002)(476003)(2906002)(16586007)(2616005)(81166006)(356004)(50466002)(48376002)(6666004)(80596001)(69596002)(42186006)(486006);DIR:OUT;SFP:1101;SCL:1;SRVR:BN7PR07MB5363;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7883d40f-0e44-4151-52ed-08d6b1be3714 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600127)(711020)(4605104)(2017052603328);SRVR:BN7PR07MB5363; X-MS-TrafficTypeDiagnostic: BN7PR07MB5363: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 09888BC01D X-Microsoft-Antispam-Message-Info: S5eY+jDy/zk/Y7eIhBcfPSu4ZSyOgon+narHi3voh6aPtl+I60PPUG+uoMKzjwhtu+pVe5oJWqb8y2KuNjwLHuOcCczM0qxq+jpFQpK66zsHe6ytbs0NS/GulP4O6MNQ2OKk2F1IsXVYX0kqYTDXSXwdlNh02D8AaxGLMqlSeiPmf+uFRJhSlL/akTY4F/Wl7RAoQUmxBX47twApqjCJ5YG3t+g9sG4ivZDj5mFPfZaKJScN16Ax1y2sA0tZ+l4SVKQLS+jndJTewQvdwveeoUYSbc8giGDnDrA57lkv1nNiduHBdPh+yavw2bhKGqEVuNe+Oc+LENu22eKNn26HT/dM2qDDauIS7gTcB6vmxA0UPvpE4Z2fhWn+S5rhA5EyGzX/Znvd61xH8rESzxoAAyZxVFo2jp8s4lpfN/iK3wo= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2019 07:39:44.2023 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7883d40f-0e44-4151-52ed-08d6b1be3714 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB5363 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Chad Dupuis When receiving an unsolicited frame we could crash on a list traversal in fc_rport_lookup while searching the rport which is associated with our lport. Initialize the lport's discovery node after allocating the lport in __qedf_probe(). Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 3fd8107..dee6fef 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -3042,6 +3042,8 @@ static int __qedf_probe(struct pci_dev *pdev, int mode) goto err0; } + fc_disc_init(lport); + /* Initialize qedf_ctx */ qedf = lport_priv(lport); qedf->lport = lport;