Message ID | 20190326073858.26792-22-skashyap@marvell.com (mailing list archive) |
---|---|
State | Accepted |
Headers | show
Return-Path: <linux-scsi-owner@kernel.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CDF0C14DE for <patchwork-linux-scsi@patchwork.kernel.org>; Tue, 26 Mar 2019 07:40:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BA6D529094 for <patchwork-linux-scsi@patchwork.kernel.org>; Tue, 26 Mar 2019 07:40:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AEC8029083; Tue, 26 Mar 2019 07:40:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 57C0A29094 for <patchwork-linux-scsi@patchwork.kernel.org>; Tue, 26 Mar 2019 07:40:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731088AbfCZHkP (ORCPT <rfc822;patchwork-linux-scsi@patchwork.kernel.org>); Tue, 26 Mar 2019 03:40:15 -0400 Received: from mail-eopbgr770058.outbound.protection.outlook.com ([40.107.77.58]:41799 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726042AbfCZHkO (ORCPT <rfc822;linux-scsi@vger.kernel.org>); Tue, 26 Mar 2019 03:40:14 -0400 Received: from DM5PR07CA0032.namprd07.prod.outlook.com (2603:10b6:3:16::18) by SN1PR07MB4030.namprd07.prod.outlook.com (2603:10b6:802:2b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.16; Tue, 26 Mar 2019 07:40:13 +0000 Received: from DM3NAM05FT029.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::205) by DM5PR07CA0032.outlook.office365.com (2603:10b6:3:16::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.18 via Frontend Transport; Tue, 26 Mar 2019 07:40:13 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT029.mail.protection.outlook.com (10.152.98.140) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1750.4 via Frontend Transport; Tue, 26 Mar 2019 07:40:12 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Tue, 26 Mar 2019 00:40:02 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x2Q7e2F7027001; Tue, 26 Mar 2019 00:40:02 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x2Q7e20j026918; Tue, 26 Mar 2019 00:40:02 -0700 From: Saurav Kashyap <skashyap@marvell.com> To: <martin.petersen@oracle.com> CC: <QLogic-Storage-Upstream@cavium.com>, <linux-scsi@vger.kernel.org> Subject: [PATCH v2 21/26] qedf: Add a flag to help debugging io_req which could not be cleaned. Date: Tue, 26 Mar 2019 00:38:53 -0700 Message-ID: <20190326073858.26792-22-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190326073858.26792-1-skashyap@marvell.com> References: <20190326073858.26792-1-skashyap@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Matching-Connectors: 131980596131276490;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(346002)(39860400002)(396003)(376002)(136003)(2980300002)(1109001)(1110001)(339900001)(199004)(189003)(86362001)(1076003)(8676002)(81156014)(81166006)(5660300002)(26826003)(356004)(69596002)(6862004)(48376002)(85426001)(6666004)(80596001)(87636003)(305945005)(4326008)(486006)(11346002)(446003)(8936002)(68736007)(126002)(2351001)(53936002)(476003)(51416003)(498600001)(47776003)(50226002)(106466001)(105606002)(2616005)(76176011)(336012)(36756003)(97736004)(26005)(36906005)(50466002)(316002)(42186006)(16586007)(2906002)(54906003);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR07MB4030;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a8cea6cb-e90d-4b48-b161-08d6b1be481c X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600127)(711020)(4605104)(2017052603328);SRVR:SN1PR07MB4030; X-MS-TrafficTypeDiagnostic: SN1PR07MB4030: X-Microsoft-Antispam-PRVS: <SN1PR07MB40306199587E68E1307C22A6D25F0@SN1PR07MB4030.namprd07.prod.outlook.com> X-Forefront-PRVS: 09888BC01D X-Microsoft-Antispam-Message-Info: CPMyH8v4pcIJu8cegZED/vi0FCGYngFN7Zj/qvhE8pv8DydQ3dsygdhArCQv2xw9+gZHbv/KX59ZY46Cvhv11nLbK9q3kEoiVY7v8akzz2NVxbMe080BSRnKLkxsV+6LmOHNznUOYrPalQE0esM8mBttHPYdY/kaPJvSce7J/k/BiUnw4w3+fu2wmB1ZI2xoXPi4S/A3c3MgbYRbfEnUpU2+mHXCzrLTBWn3uCbANg8Vs0wuT21oc/hvIVhXBUBxOrUxTrnHnujnzAlLVIPp9edlWX8LHJ7dvhV0DFM76mCmR21ZjWdTVXUOhhTeEtbmfBMdzx79Y8k+//RbpHLKOE6ajBT3YVL+emBxQEMlLxGnL2TGvgozIFSj6Pdd3El6jmkw9tejXu1miIn0PGjxgTqfOWXb5wlr3N2RSWmuhBo= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2019 07:40:12.7893 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a8cea6cb-e90d-4b48-b161-08d6b1be481c X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB4030 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: <linux-scsi.vger.kernel.org> X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
qedf: Misc fixes for the driver.
|
expand
|
diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 889b300..4a792ea 100644 --- a/drivers/scsi/qedf/qedf_io.c +++ b/drivers/scsi/qedf/qedf_io.c @@ -351,6 +351,11 @@ struct qedf_ioreq *qedf_alloc_cmd(struct qedf_rport *fcport, u8 cmd_type) goto out_failed; } + if (test_bit(QEDF_CMD_DIRTY, &io_req->flags)) + QEDF_ERR(&qedf->dbg_ctx, + "io_req found to be dirty ox_id = 0x%x.\n", + io_req->xid); + /* Clear any flags now that we've reallocated the xid */ io_req->flags = 0; io_req->alloc = 1; @@ -1744,6 +1749,8 @@ void qedf_flush_active_ios(struct qedf_rport *fcport, int lun) io_req->fcport == fcport) { refcount = kref_read(&io_req->refcount); + set_bit(QEDF_CMD_DIRTY, + &io_req->flags); QEDF_ERR(&qedf->dbg_ctx, "Outstanding io_req =%p xid=0x%x flags=0x%lx, sc_cmd=%p refcount=%d cmd_type=%d.\n", io_req, io_req->xid,