From patchwork Tue Mar 26 07:38:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurav Kashyap X-Patchwork-Id: 10870549 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5240115AC for ; Tue, 26 Mar 2019 07:40:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3D63B2908C for ; Tue, 26 Mar 2019 07:40:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2AF6629092; Tue, 26 Mar 2019 07:40:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CE93D28FEC for ; Tue, 26 Mar 2019 07:40:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730587AbfCZHkb (ORCPT ); Tue, 26 Mar 2019 03:40:31 -0400 Received: from mail-eopbgr690073.outbound.protection.outlook.com ([40.107.69.73]:54034 "EHLO NAM04-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726042AbfCZHkb (ORCPT ); Tue, 26 Mar 2019 03:40:31 -0400 Received: from DM6PR07CA0003.namprd07.prod.outlook.com (2603:10b6:5:94::16) by DM5PR07MB4022.namprd07.prod.outlook.com (2603:10b6:4:b2::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.15; Tue, 26 Mar 2019 07:40:29 +0000 Received: from DM3NAM05FT029.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::206) by DM6PR07CA0003.outlook.office365.com (2603:10b6:5:94::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.15 via Frontend Transport; Tue, 26 Mar 2019 07:40:29 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by DM3NAM05FT029.mail.protection.outlook.com (10.152.98.140) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1750.4 via Frontend Transport; Tue, 26 Mar 2019 07:40:29 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Tue, 26 Mar 2019 00:40:15 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x2Q7eFZV027017; Tue, 26 Mar 2019 00:40:15 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x2Q7eFKX027016; Tue, 26 Mar 2019 00:40:15 -0700 From: Saurav Kashyap To: CC: , Subject: [PATCH v2 25/26] qedf: Fix lport may be used uninitialezed warning. Date: Tue, 26 Mar 2019 00:38:57 -0700 Message-ID: <20190326073858.26792-26-skashyap@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190326073858.26792-1-skashyap@marvell.com> References: <20190326073858.26792-1-skashyap@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131980596296190103;(abac79dc-c90b-41ba-8033-08d666125e47);(abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(136003)(346002)(396003)(39860400002)(376002)(2980300002)(1110001)(1109001)(339900001)(199004)(189003)(51416003)(86362001)(76176011)(498600001)(87636003)(26826003)(5660300002)(126002)(476003)(486006)(36906005)(42186006)(446003)(11346002)(16586007)(316002)(2616005)(336012)(8676002)(1076003)(97736004)(305945005)(26005)(81156014)(81166006)(54906003)(14444005)(68736007)(85426001)(2906002)(6666004)(36756003)(356004)(69596002)(80596001)(6862004)(50226002)(105606002)(53936002)(106466001)(2351001)(50466002)(8936002)(48376002)(4326008)(47776003);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR07MB4022;H:CAEXCH02.caveonetworks.com;FPR:;SPF:Fail;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0781e69c-e984-4b9b-3a37-08d6b1be51f1 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(5600127)(711020)(4605104)(2017052603328);SRVR:DM5PR07MB4022; X-MS-TrafficTypeDiagnostic: DM5PR07MB4022: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 09888BC01D X-Microsoft-Antispam-Message-Info: nFcviLax7hDrR4rfTTOj3ON8a/2+NccLneolJfrZn/1q37tmqw5Qyyiv1Ug1junQJisPDkPzbs5UayBwSsY3n1BI95+94i5qILx227g8xVbm+xLF2gWo4zkfsfdp7oExMrHx9GD2m28b7kCmSt3yzqYy7kKTBK0mvZ3fRj9TdDK42skgBJDR8Sykjl6JQOgyoNlj0XIAJqnkC3seyDzOmX42ulrQ7aNX3+KMf8eTaF2C2u1SzfJ4cfQtde5/y7D3NaZzjBKDow3LKd+3ZGP1R9h9Wo0/fh5NbJ7x7/JFKEhEFKX+YRTIQ0YaHJfpOvjpIxFMIzj0C9Hhxx7mORAGKLdfhiayxVC9N5zbxhdn+OP1MJOWjHY2ZIcfRj34604sw35nt7iDay9huzP8RUYpaQO7mTDrgivED7odOpHp7Co= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2019 07:40:29.2802 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0781e69c-e984-4b9b-3a37-08d6b1be51f1 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[199.233.58.38];Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB4022 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP - lport was getting used without initialization, initialize it to fix a warning. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index b359ae3..51378e5 100644 --- a/drivers/scsi/qedf/qedf_io.c +++ b/drivers/scsi/qedf/qedf_io.c @@ -2356,7 +2356,7 @@ int qedf_initiate_tmf(struct scsi_cmnd *sc_cmd, u8 tm_flags) struct fc_rport_libfc_priv *rp = rport->dd_data; struct qedf_rport *fcport = (struct qedf_rport *)&rp[1]; struct qedf_ctx *qedf; - struct fc_lport *lport; + struct fc_lport *lport = shost_priv(sc_cmd->device->host); int rc = SUCCESS; int rval; struct qedf_ioreq *io_req = NULL; @@ -2410,8 +2410,6 @@ int qedf_initiate_tmf(struct scsi_cmnd *sc_cmd, u8 tm_flags) goto tmf_err; } - lport = qedf->lport; - if (test_bit(QEDF_RPORT_UPLOADING_CONNECTION, &fcport->flags)) { QEDF_ERR(&qedf->dbg_ctx, "Connection is getting uploaded.\n"); rc = SUCCESS;