diff mbox series

[02/15] qla2xxx: Set the qpair in SRB to NULL when SRB is released

Message ID 20190328171012.26425-3-hmadhani@marvell.com (mailing list archive)
State Superseded
Headers show
Series qla2xxx: Misc updates and bug fixes for the driver. | expand

Commit Message

Himanshu Madhani March 28, 2019, 5:09 p.m. UTC 
From: Giridhar Malavali <gmalavali@marvell.com>

Set QPair to NULL

Signed-off-by: Giridhar Malavali <gmalavali@marvell.com>
Signed-off-by: Himanshu Madhani <hmadhani@marvell.com>
---
 drivers/scsi/qla2xxx/qla_inline.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Bart Van Assche March 28, 2019, 5:36 p.m. UTC | #1 
On Thu, 2019-03-28 at 10:09 -0700, Himanshu Madhani wrote:
> From: Giridhar Malavali <gmalavali@marvell.com>
> 
> Set QPair to NULL

Same question here: why do you want to make this change? Why do you
think this change is necessary?

Thanks,

Bart.
diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/qla_inline.h b/drivers/scsi/qla2xxx/qla_inline.h
index 512c3c37b447..07c3f45d4bd7 100644
--- a/drivers/scsi/qla2xxx/qla_inline.h
+++ b/drivers/scsi/qla2xxx/qla_inline.h
@@ -240,6 +240,7 @@  qla2xxx_get_qpair_sp(scsi_qla_host_t *vha, struct qla_qpair *qpair,
 static inline void
 qla2xxx_rel_qpair_sp(struct qla_qpair *qpair, srb_t *sp)
 {
+	sp->qpair = NULL;
 	mempool_free(sp, qpair->srb_mempool);
 	QLA_QPAIR_MARK_NOT_BUSY(qpair);
 }